This question is not answered. Helpful answers available: 2. Correct answers available: 1.

Reply to this Thread Reply to this Thread Search Forum Search Forum Back to Thread List Back to Thread List

Permlink Replies: 3 - Pages: 1 - Last Post: 13 Oct 26, 13:58 Last Post By: JeffTucker Threads: [ Previous | Next ]
JeffTucker

Posts: 8,702
Registered: 31-Jan-2006
Menu choice to embed album
Posted: 21 Apr 26, 22:00 		 
  Click to reply to this thread Reply
Attachment embedError.png (26.6 KB)
With the introduction of Laza's new Embed skin, perhaps this is the time to do a little cleaning up in that general vicinity.

The menu choice for Album > Embed album should be grayed out if the current project has not been uploaded anywhere. Currently, it just coughs up an error - screenshot.

While you're in there, that menu choice should also be grayed out at all times if the skin includes an empty embed.htt file (rather than no file at all - in that case it falls back on the core default). This should be taken as an indication that the skin developer doesn't think an album made with this skin should ever be embedded.
JeffTucker

Posts: 8,702
Registered: 31-Jan-2006
Re: Menu choice to embed album
Posted: 22 Apr 26, 14:54   in response to: JeffTucker in response to: JeffTucker 		 
  Click to reply to this thread Reply
JeffTucker wrote:
While you're in there, that menu choice should also be grayed out at all times if the skin includes an empty embed.htt file...

...or let the skin disable the menu entry, perhaps by adding something to disabledControls in skin.properties.
davidekholm

Posts: 4,103
Registered: 18-Oct-2002
Re: Menu choice to embed album
Posted: 7 May 26, 16:09   in response to: JeffTucker in response to: JeffTucker 		 
  Click to reply to this thread Reply
The plan is to soon bundle Embed skin with jAlbum, then I can revisit this behavior
JeffTucker

Posts: 8,702
Registered: 31-Jan-2006
Re: Menu choice to embed album
Posted: 8 Jun 26, 19:48   in response to: davidekholm in response to: davidekholm 		 
  Click to reply to this thread Reply
Skins that supplies a custom embed.htt have full control of the code generated.

In most of my skins, I don't want Album > Embed album to be enabled at all. The albums should never be embedded. Perhaps if a skin supplies an empty embed.htt, the core could take the hint, and gray out that menu option.

ETA: Here's the logic:

  • Skin includes an empty embed.htt, gray out Album > Embed album at all times.
  • If the album hasn't be uploaded, gray out Album > Embed album.
  • Skin includes a non-empty embed.htt or no template, and album has been uploaded, enable Album > Embed album.

Edited by: JeffTucker on 13 Oct 2026, 07:56
Pages: 1
Back to Thread List Back to Thread List
Threads: [ Previous | Next ]
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums