Permlink Replies: 23 - Pages: 2 [ Previous | 1 2 ] - Last Post: 22 Jan 26, 21:04 Last Post By: RobM Threads: [ Previous | Next ]
phil44

Posts: 190
Registered: 18-Jun-2010
Re: Zip of folder images is broken
Posted: 22 Jan 26, 11:21   in response to: phil44 in response to: phil44
  Click to reply to this thread Reply
Hello,

Unfortunately, the version 7.4.2 (with jAlbum core 39.0.7) did not fix the errors I'm encountering.

Furthermore (and this is related), I noticed that the Make Slides setting was always enabled in my albums, even when I forced it to *off*!

The problem is more complex than it initially appears:

  • I found the setMakeSlides() function in Gui.java, which forces Make Slides to on in these cases (this isn't mentioned or documented anywhere):
    • Facebook, Threads, or BlueSky share enabled and share enabled in the Lightbox
    • Generation of sitemap.xml enabled with slide inclusion
  • When Make Slides is on (due to the implicit activation above) and the Zip file doesn't exist in the destination directory, then the zipping mechanism always tries to retrieve the images from the album's destination directory and not from the slides directory :(
  • The error is still not reported to the user
Laza

Posts: 1,511
Registered: 6-Sep-2005
Re: Zip of folder images is broken
Posted: 22 Jan 26, 13:30   in response to: phil44 in response to: phil44
  Click to reply to this thread Reply
You are right. The skin has turned off "Make slides" during testing.

I'll notify David that it's still not working. It clearly returns the imagePath, closeupPath, and videoPath variables, as if we were still in the slides folder.
Laza

Posts: 1,511
Registered: 6-Sep-2005
Re: Zip of folder images is broken
Posted: 22 Jan 26, 15:02   in response to: phil44 in response to: phil44
  Click to reply to this thread Reply
It turned out David had already fixed this; it's just that the Beta core update tool can't grab the latest version, 39.1b1. Use this link: https://jalbum.net/download/beta/jalbum-core.jar
JeffTucker

Posts: 8,335
Registered: 31-Jan-2006
Re: Zip of folder images is broken
Posted: 22 Jan 26, 15:04   in response to: Laza in response to: Laza
  Click to reply to this thread Reply
Finding David's latest beta core file is always a bit of an adventure.
phil44

Posts: 190
Registered: 18-Jun-2010
Re: Zip of folder images is broken
Posted: 22 Jan 26, 19:00   in response to: Laza in response to: Laza
  Click to reply to this thread Reply
Laza wrote:
It turned out David had already fixed this; it's just that the Beta core update tool can't grab the latest version, 39.1b1. Use this link: https://jalbum.net/download/beta/jalbum-core.jar
Oops, I'm unable to get the jar. The browser error message says that the file can't be read on the server...
JeffTucker

Posts: 8,335
Registered: 31-Jan-2006
Re: Zip of folder images is broken
Posted: 22 Jan 26, 19:07   in response to: phil44 in response to: phil44
  Click to reply to this thread Reply
Can't imagine why. I just downloaded it.
phil44

Posts: 190
Registered: 18-Jun-2010
Re: Zip of folder images is broken
Posted: 22 Jan 26, 19:20   in response to: phil44 in response to: phil44
  Click to reply to this thread Reply
It's fine, I have the file. It was just a problem in the browser (clicking the link = download failed, right-clicking the link then clicking Download in the context menu = OK).
phil44

Posts: 190
Registered: 18-Jun-2010
Re: Zip of folder images is broken
Posted: 22 Jan 26, 19:35   in response to: phil44 in response to: phil44
  Click to reply to this thread Reply
Good news ! The problem seems to be fixed in my main album :)

Tested with this config : core V39.1b1, Tiger 7.4.2, no zip file present is the output folder, download activated for scaled-down images, download button shown in the Lighbox, share activated for Threads and BlueSky.

No error is reported in the console on Make and the zip file is generated as expected.
The download controls works as expected in the browser.

Thanks Laza, Jeff and David for your efforts to fix this!
RobM

Posts: 3,982
Registered: 4-Aug-2006
Re: Zip of folder images is broken
Posted: 22 Jan 26, 21:04   in response to: Laza in response to: Laza
  Click to reply to this thread Reply
Laza wrote:
It turned out David had already fixed this; it's just that the Beta core update tool can't grab the latest version, 39.1b1. Use this link: https://jalbum.net/download/beta/jalbum-core.jar
Just tried the beta core update and it does miss this file because the server is reporting the timestamp as older than the installed file. Oddly, once downloaded the timestamp shows it as newer. So I've modified the tool, if it misses a beta update due to timestamps you can now do a forced update (previously it just tried to do an update.
Tool updated at https://jalbum.net/forum/thread.jspa?messageID=354212&#354212
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums