Posts:
8,335
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
28 Sep 25, 06:41
in response to: davidekholm
|
|
|
b16 now available via the beta jar file.
A good beginning, but lots of problems. I haven't had much time to play with it, but.... In no particular order:
I'm running into a lot of instability. Start a new project, add a few objects, then try to assign a representing image (an RI) to one of them. I don't get a file selector. No error, just nothing. Close jAlbum, launch again, reopen the project, and now I can choose an RI. But the thumbnail in the Explore view isn't showing it. Another shutdown and relaunch, and the thumbnail shows the RI.
I've also encountered situations in which opening the primary image for editing is, instead, showing me the RI, as if I were going to edit it.
Using Jupiter, which supports MP3's in a very straightforward way, I'm still getting the error I was getting with THM's. Assign an RI to the MP3. Under Images, include only originals, and make the album. The slide page can't find a poster image. If you use scaled images, instead, it works.
I think we're going to need to "rip off the bandage," and abandon THM files in one fell swoop. At the moment, both RI's and THM's are still supported, and that, of course, is a recipe for trouble. As I suggested in an earlier exchange, if you open an older project with jAlbum 38, it should seek out THM's, convert them to RI's, and delete the THM files. Newly-added THM files should be ignored, just like any other unsupported AO type.
I'll do some more experimenting as time permits, but there's a beach and a boardwalk that need my attention.
|
|
|
Posts:
3,966
Registered:
18-Oct-2002
|
|
|
|
Re: Cleaning up path variables
Posted:
28 Sep 25, 18:08
in response to: RobM
|
|
|
b16 now available via the beta jar file.
Changes:
- Introduces a more generic Attachments concept*. One can now attach multiple files to any album object, currently the audio clip and a representing image. You can now easily attach a suitable image to represent a pdf or xls file for instance. This new addition does away with the clunky THM files. Just attach an image to use instead. Attachments need not have the same file name as the object they're attached to
Is the method to get the attachments the same e.g. AlbumObjectProperties props = ao.getProperties();
if(props.get("audioClipPath") != null) {
It's still that property for audio clips, but if it's a relative name, the base directory is now .jalbum/attachments/fileName/ and not .jalbum/audioClips. If you instead rely on the "audioClipPath" variable, then you get the correct path to the audio clip, as reachable from within the album.
There is also the new Attachments API that will give you the full original path to an attachment, which is ao.getAttachments().get(Attachments.Type.AUDIO) or ao.getAttachments().get(Attachments.Type.IMAGE)
Missive skin allows for images to have an alternative version, so the viewer can swap between the two. Would an alternative image be a good fit for an attachment? It would save having to generate unused thumbnails and slide pages for the alternative image. I think Jeff mentioned an alternative image for pano thumbnails too.
We're at least paving the way for this. Currently you can attach an image to an image. Only one will be processed, but as you can access the original as well, then you have access to both.
|
|
|
Posts:
3,983
Registered:
4-Aug-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
28 Sep 25, 19:57
in response to: davidekholm
|
|
|
It's still that property for audio clips, but if it's a relative name, the base directory is now .jalbum/attachments/fileName/ and not .jalbum/audioClips. If you instead rely on the "audioClipPath" variable, then you get the correct path to the audio clip, as reachable from within the album.
There is also the new Attachments API that will give you the full original path to an attachment, which is ao.getAttachments().get(Attachments.Type.AUDIO) or ao.getAttachments().get(Attachments.Type.IMAGE)
Great, I won't need to modify anything
Missive skin allows for images to have an alternative version, so the viewer can swap between the two. Would an alternative image be a good fit for an attachment? It would save having to generate unused thumbnails and slide pages for the alternative image. I think Jeff mentioned an alternative image for pano thumbnails too.
We're at least paving the way for this. Currently you can attach an image to an image. Only one will be processed, but as you can access the original as well, then you have access to both.
OK, Will have a think about that, probably leave it as is for now.
|
|
|
Posts:
8,335
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
28 Sep 25, 20:36
in response to: RobM
|
|
|
Currently you can attach an image to an image. Only one will be processed, but as you can access the original as well, then you have access to both.
OK, Will have a think about that, probably leave it as is for now.
I'll have to mull that over, as well. I guess the question is, why would a user attach a JPG to a JPG (or other image type)? And what would that mean about how they would want it to be handled?
For use as an alternate image on a page, you might want both the primary and linked images to be scaled. You might want to be able edit both! That gets pretty byzantine, and only one skin currently supports it.
But turning to the rest of the skins, the only use that comes immediately to mind is for a pano, where you'd want it to use the linked image as the thumbnail, and the primary for the slide. Would you want the primary to be scaled? Would you want to be able to edit it? In the case of a pano primary, the answer might be "no" to both questions. Should the core treat the primary like a GIF, automatically tagging it as "use original?"
Needs some speculation, so we don't paint ourselves into a corner.
|
|
|
Posts:
3,983
Registered:
4-Aug-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
28 Sep 25, 21:12
in response to: JeffTucker
|
|
|
Currently you can attach an image to an image. Only one will be processed, but as you can access the original as well, then you have access to both.
OK, Will have a think about that, probably leave it as is for now.
I'll have to mull that over, as well. I guess the question is, why would a user attach a JPG to a JPG (or other image type)? And what would that mean about how they would want it to be handled?
For use as an alternate image on a page, you might want both the primary and linked images to be scaled. You might want to be able edit both! That gets pretty byzantine, and only one skin currently supports it.
But turning to the rest of the skins, the only use that comes immediately to mind is for a pano, where you'd want it to use the linked image as the thumbnail, and the primary for the slide. Would you want the primary to be scaled? Would you want to be able to edit it? In the case of a pano primary, the answer might be "no" to both questions. Should the core treat the primary like a GIF, automatically tagging it as "use original?"
Needs some speculation, so we don't paint ourselves into a corner.
Can't find the post, possibly deleted as it was a long time ago, but at least one user wanted to display a front view and a back view. The only way to do it is to make a skin that shows both on the same (slide) page or the way I did it - toggle the images on the slide/index page.
Since I have a working version and I don't recall any user recently asking for it, maybe best to put it on the end of the maybe to do list.
|
|
|
Posts:
3,966
Registered:
18-Oct-2002
|
|
|
|
Re: Cleaning up path variables
Posted:
28 Sep 25, 22:23
in response to: JeffTucker
|
|
|
b16 now available via the beta jar file.
A good beginning, but lots of problems. I haven't had much time to play with it, but.... In no particular order:
I'm running into a lot of instability. Start a new project, add a few objects, then try to assign a representing image (an RI) to one of them. I don't get a file selector. No error, just nothing. Close jAlbum, launch again, reopen the project, and now I can choose an RI. But the thumbnail in the Explore view isn't showing it. Another shutdown and relaunch, and the thumbnail shows the RI.
Now fixed. (b17)
I've also encountered situations in which opening the primary image for editing is, instead, showing me the RI, as if I were going to edit it.
Do you only want the thumbnail to be affected? The main purpose of this feature will likely be to have icons replaced by images. For such cases you'll likely not want to see the icon when entering edit mode
Using Jupiter, which supports MP3's in a very straightforward way, I'm still getting the error I was getting with THM's. Assign an RI to the MP3. Under Images, include only originals, and make the album. The slide page can't find a poster image. If you use scaled images, instead, it works.
I guess the correct behaviour would be to generate the thumbnail only, right? That's what I get with minimal.
I think we're going to need to "rip off the bandage," and abandon THM files in one fell swoop. At the moment, both RI's and THM's are still supported, and that, of course, is a recipe for trouble. As I suggested in an earlier exchange, if you open an older project with jAlbum 38, it should seek out THM's, convert them to RI's, and delete the THM files. Newly-added THM files should be ignored, just like any other unsupported AO type.
I wonder if users would accept it if I simply ignored THM files altogether? Keeps things cleaner
|
|
|
Posts:
8,335
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
28 Sep 25, 22:47
in response to: davidekholm
|
|
|
I wonder if users would accept it if I simply ignored THM files altogether? Keeps things cleaner
Sure, it would be cleaner. But a user who has laboriously created THM files for 100 PDF's is not going to be happy the first time he hits Make Album, and all of his thumbnails revert to generic PDF icons.
On first project load with jAlbum 38, it really needs to find those THM's, rename them JPG's, and attach them to their parent AO's.
|
|
|
Posts:
8,335
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
28 Sep 25, 22:59
in response to: davidekholm
|
|
|
|
|
Using Jupiter, which supports MP3's in a very straightforward way, I'm still getting the error I was getting with THM's. Assign an RI to the MP3. Under Images, include only originals, and make the album. The slide page can't find a poster image. If you use scaled images, instead, it works.
I guess the correct behaviour would be to generate the thumbnail only, right? That's what I get with minimal.
Actually, that's not what happens now. Consider a project with a regular JPG, an MP4 with a THM, a PDF with a THM, and an MP3 with a PDF. See screenshot of project - that thumbnail for the Chrome video is not coming from the video - it's a THM.
Linking to scaled images only, the slides directory contains a slide image for each one of them.- screenshot. Minimal uses the slide image for the MP4 as a poster image, before you hit Play. It doesn't need to use it for the PDF, but the slide image is actually there (in my lightbox skins, that's the image that "expands" from the thumbnail, so I am using it). Minimal doesn't use the poster image for the MP3, but Jupiter certainly does.
But now switch to linking to originals. The only poster image that lands in slides is the one for the MP4 - see screenshot.
They should all behave the same way. Regardless of whether it's linking to scaled or linking to originals, we need to have a poster image for each AO land in slides.
(ETA: And that, of course, is where things get murky when you're attaching a JPG to a JPG. In that case, you probably want only a thumbnail coming from the linked file.)
|
|
|
Posts:
8,335
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
28 Sep 25, 23:06
in response to: davidekholm
|
|
|
I'm running into a lot of instability.
Now fixed. (b17)
Yes, that seems to be operating cleanly now. 
|
|
|
Posts:
8,335
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
28 Sep 25, 23:16
in response to: davidekholm
|
|
|
I've also encountered situations in which opening the primary image for editing is, instead, showing me the RI, as if I were going to edit it.
Do you only want the thumbnail to be affected? The main purpose of this feature will likely be to have icons replaced by images. For such cases you'll likely not want to see the icon when entering edit mode
Opening an AO for editing should show you only the AO, and never its RI. After all, you can't actually edit the RI. So, if you enter edit mode for a PDF, it should probably display just the generic PDF icon. Only in the Explore view should you be seeing the RI, as a thumbnail.
(And to mix subjects, when you go to a folder that has internally linked objects, you shouldn't be able to enter edit mode for those at all, since the core is not going to generate different versions of those images.)
|
|
|
Posts:
3,966
Registered:
18-Oct-2002
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 13:12
in response to: JeffTucker
|
|
|
|
b18 now available as a beta core update. It now imports THM files as attachments. I've also removed other code kludges that manages THM files now.
If I include only thumbnails and originals, I get a generated thumbnail file for a pdf file having an attached image, but no closeup image. I think that's what you'd expect. I see no negative by allowing the editing of an attached image either. We never touch the original, so why not allow that flexibility? I'd have to write more code to disallow it.
|
|
|
Posts:
8,335
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 14:30
in response to: davidekholm
|
|
|
b18 now available as a beta core update. It now imports THM files as attachments. I've also removed other code kludges that manages THM files now.
I think that's working properly, but I'll have to do some tinkering. It's a tough thing to test - I need to reinstall jAlbum 37 to create projects for testing. It does appear to be ignoring newly-added THM files, happily.
If I include only thumbnails and originals, I get a generated thumbnail file for a pdf file having an attached image, but no closeup image. I think that's what you'd expect.
For a PDF, that's true. But for an MP3, that leaves me with no image to use as a poster on the slide page - no scaled image, no original image. For an MP4, that would also leave me with no poster image to show before the visitor hits "play." And the lack of a poster image for the MP3 produces the classic "broken image" icon on the slide page. The user is then boxed in. If he wants to show a poster image for an MP3 or MP4, he must include scaled images for the whole project.
I see no negative by allowing the editing of an attached image either. We never touch the original, so why not allow that flexibility? I'd have to write more code to disallow it.
I suppose that for PDF's or MP3's, that's fine, as long as the user can remember that the image editing options at the top apply to the RI, but the right-panel things like the skin-specific custom UI items apply to the AO.
But attach an RI to an MP4, then enter edit mode. You're seeing the JPG RI. But the slide controls at the bottom apply to the MP4, even though you can't see what they're doing! And if I touch the video slider at all, I end up with a "red X" thumbnail. A bit of a muddle.
The situation with an JPG AO and a JPG RI is even more perplexing. Rather than try to describe it, I'll just let you try it. Try using something obvious, like "invert" on the image edit. Pay attention to what you're seeing in the Explore view, and what images are landing in the album output. Now tag the AO as "use original," and see what happens. Fun for the whole family!
|
|
|
Posts:
8,335
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 15:31
in response to: JeffTucker
|
|
|
I think that's working properly, but I'll have to do some tinkering. It's a tough thing to test - I need to reinstall jAlbum 37 to create projects for testing. It does appear to be ignoring newly-added THM files, happily.
Reinstalled jAlbum 37 (much easier to keep multiple versions on a Mac than on Windows), and the importing of existing THM files, and the ignoring of attempts to add new ones, both working well. 
|
|
|
Posts:
3,966
Registered:
18-Oct-2002
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 15:49
in response to: JeffTucker
|
|
|
|
b20 now available, adding a context menu when clicking an attachment and also fixing a thumbnail rendering performance issue introduced with attachments.
|
|
|
Posts:
8,335
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 16:18
in response to: JeffTucker
|
|
|
If I include only thumbnails and originals, I get a generated thumbnail file for a pdf file having an attached image, but no closeup image. I think that's what you'd expect.
For a PDF, that's true.
I spoke too soon. For a PDF, my lightbox skins use that full-sized image (i.e., not a thumbnail) for the lightbox "expansion" display. If there's no poster image to use, the visitor sees a "broken image" icon while the thumbnail is zoomed out to the lightbox. Once the PDF loads, of course, that broken image disappears.
So, for a PDF, an MP3, or an MP4, I need to have a poster image available, scaled or original, no matter what other settings options are chosen. I don't much care where it is, as long as I can reliably call the path to it.
|
|
|
|
Legend
|
|
Forum admins
|
|
Helpful Answer
|
|
Correct Answer
|
|