This question is answered. Helpful answers available: 0. Correct answers available: 1.


Permlink Replies: 25 - Pages: 2 [ Previous | 1 2 ] - Last Post: 19 Aug 25, 22:30 Last Post By: JeffTucker
RobM

Posts: 3,877
Registered: 4-Aug-2006
Re: About page question
Posted: 18 Aug 25, 21:14   in response to: RobM in response to: RobM
Helpful
  Click to reply to this thread Reply
Alternatively you could change the PhotoBlogger>Side bar>Custom content code first two lines
from
<p>${comment|HelpComment}</p>
</div>

to
<ja:if not test="${currentObject}" value="About.htt"><p>${comment|HelpComment}</p></div></ja:if>
That will remove the comment from the side bar.
jeffkolker

Posts: 84
Registered: 27-Feb-2021
Re: About page question
Posted: 19 Aug 25, 00:43   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
Thanks for the options.

I'll consider those. Or I might not do anything and leave it as is. It's not terrible, but it does look a bit funny.

I would prefer to keep it in the sidebar. So...we'll see what happens.

Thanks again!
Jeff
JeffTucker

Posts: 8,009
Registered: 31-Jan-2006
Re: About page question
Posted: 19 Aug 25, 01:12   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
I don’t know if PhotoBlogger is the only bundled skin that has a configuration that lets this duplication happen.

Tiger and Plain do the same thing. Not surprised - like me, Laza takes advantage of "convergent code." Something works in one skin, no sense reinventing it for another - just copy the code!
Laza

Posts: 1,438
Registered: 6-Sep-2005
Re: About page question
Posted: 19 Aug 25, 16:26   in response to: jeffkolker in response to: jeffkolker
 
  Click to reply to this thread Reply
As I see you're using the sidebar's Custom code section for displaying the ${comment} variable. Well, this is not something I foresaw.

When I created Story skin, which can display custom pages embedded within the index page, I found it challenging to enter text on Empty pages. Hence, I started to display the comment field just like the page content. BTW, entering a comment for a custom page would be pointless otherwise. Then I made other templates to display the comments, too.

You can use some conditional coding to avoid duplication on the custom pages:
<%= pageTpe === "page" ? "" : comment %>
jeffkolker

Posts: 84
Registered: 27-Feb-2021
Re: About page question
Posted: 19 Aug 25, 17:34   in response to: Laza in response to: Laza
 
  Click to reply to this thread Reply
Laza wrote:
As I see you're using the sidebar's Custom code section for displaying the ${comment} variable. Well, this is not something I foresaw.

I got it working the way I wanted. I used Rob's example to remove the comment field from the About page, but nowhere else. I then created a custom variable, put the About page comment code in it, and used the same example from Rob to add that variable ONLY to the About page.

It seems to work just fine.
Laza

Posts: 1,438
Registered: 6-Sep-2005
Re: About page question
Posted: 19 Aug 25, 19:15   in response to: jeffkolker in response to: jeffkolker
 
  Click to reply to this thread Reply
In that code, I see a closing div that doesn't have an opening tag. This can wreak havoc on the page.
RobM

Posts: 3,877
Registered: 4-Aug-2006
Re: About page question
Posted: 19 Aug 25, 20:20   in response to: Laza in response to: Laza
 
  Click to reply to this thread Reply
Laza wrote:
In that code, I see a closing div that doesn't have an opening tag. This can wreak havoc on the page.
I noticed that and thought it odd in the original content, but leaving it out left a very small yellow box with no content. Don't know why so I left it in the if tag coding.
jeffkolker

Posts: 84
Registered: 27-Feb-2021
Re: About page question
Posted: 19 Aug 25, 20:38   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
Laza wrote:
In that code, I see a closing div that doesn't have an opening tag. This can wreak havoc on the page.
I noticed that and thought it odd in the original content, but leaving it out left a very small yellow box with no content. Don't know why so I left it in the if tag coding.

Because I'm inserting this code in the middle of other code, that "/div" is required to close out the box the text is in. My next set of code duplicates the previously issued "div" in Laza's code, starting a new box. Then finally, after the last of my code, Laza's code issues the final "/div", closing out the custom content section.
RobM

Posts: 3,877
Registered: 4-Aug-2006
Re: About page question
Posted: 19 Aug 25, 21:24   in response to: jeffkolker in response to: jeffkolker
 
  Click to reply to this thread Reply
Odd, I just counted the number of opening and closing div tags and got 34 opening and 33 closing. The difference in the count is found here
<footer class="footer">
..<div class="cont full">
....<div class="bottom-navigation">
......<a href="About.html">About</a>
......<a href="Contact.html">Contact</a>
......<a href="Contents-1.html">Contents</a>
......<a href="Sitemap.html">Site Map</a>
....</div> //end of bottom-navigation
....<div class="custom-cont">
......<div class="folder-info">
........<div class="counts">
..........492 Images on page
........</div> //end of counts
........<span class="counts" id="jdkpubdate"></span>
......</div> //end of folder-info
....</div> //end of custom-cont
// no end of cont full
</footer>

Worth someone double checking it, I used an editor with 'find all' and entered <div and then </div
jeffkolker

Posts: 84
Registered: 27-Feb-2021
Re: About page question
Posted: 19 Aug 25, 22:01   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
Odd, I just counted the number of opening and closing div tags and got 34 opening and 33 closing. The difference in the count is found here

Worth someone double checking it, I used an editor with 'find all' and entered <div and then </div

Seems there was an error in the footer section, which may explain why it wasn't noticed in the output. The final "/div" was missing.

I had 7 "div" and 6 "/div". I fixed.

I performed a search using the now-published source and found 74 instances of "div" and 74 instances of "/div".

Thanks!
JeffTucker

Posts: 8,009
Registered: 31-Jan-2006
Re: About page question
Posted: 19 Aug 25, 22:28   in response to: jeffkolker in response to: jeffkolker
Helpful
  Click to reply to this thread Reply
This is why I use Total Validator. It picks up all sorts of things, and works like a champ.

Not a freebie, alas, but the pro version can check my entire skin demo website, including all the user's manual pages, in about 30 seconds - over 600 pages. I do the validation on my local hard drive before uploading, of course - it would take much longer checking the live site.
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums