Split skin testing ... - jAlbum forums

Laza

Posts: 1,438
Registered: 6-Sep-2005

Split skin testing
Posted: 5 Jun 25, 15:37

Reply

Split.jaskin (1.2 MB)

I created a new, simple skin that displays thumbnails and the lightbox side by side.

Not all features are yet functional, and only the Dark style has been elaborated.

Let me know what you think!

Sample album

JeffTucker

Posts: 8,009
Registered: 31-Jan-2006

Re: Split skin testing
Posted: 5 Jun 25, 16:04

in response to: Laza

Reply

A nice return to a style that we haven't seen in a while. You should have used FRAMESETs.

One quick suggestion: change Show Title and Description to Show Title and Comment. Every jAlbum user in the world knows about these two variables - let's not start using different words for them!

I would also add a checkbox to that one, Use file name if no title, active only if the primary checkbox is chosen. I've got a whole set of test image files that are purposely named things like 1897 Daimler.jpg, to make life simpler.

davidekholm

Posts: 3,802
Registered: 18-Oct-2002

Re: Split skin testing
Posted: 5 Jun 25, 16:12

in response to: Laza

Reply

Really like this one Laza!

I got a scripting error when feeding it a gallery containing an empty sub folder:

Stack trace for jAlbum 37.5.6 using skin Split 0.9:
 
se.datadosen.util.ScriptException: <eval>:7 ReferenceError: "themePath" is not defined in lightbox.inc at line number 1
	at se.datadosen.util.ScriptException.of(ScriptException.java:59)
	at se.datadosen.jalbum.ast.ScriptletNode.doEval(ScriptletNode.java:99)
	at se.datadosen.jalbum.ast.ASTNode.eval(ASTNode.java:50)
	at se.datadosen.jalbum.ast.GroupNode.doEval(GroupNode.java:78)
	at se.datadosen.jalbum.ast.IncludeNode.doEval(IncludeNode.java:89)
	at se.datadosen.jalbum.ast.ASTNode.eval(ASTNode.java:50)
	at se.datadosen.jalbum.ast.GroupNode.doEval(GroupNode.java:78)
	at se.datadosen.jalbum.ast.EnterNode.doEval(EnterNode.java:23)
	at se.datadosen.jalbum.ast.ASTNode.eval(ASTNode.java:50)
	at se.datadosen.jalbum.ast.GroupNode.doEval(GroupNode.java:78)
	at se.datadosen.jalbum.ast.ASTNode.eval(ASTNode.java:50)
	at se.datadosen.jalbum.AST.eval(AST.java:75)
	at se.datadosen.jalbum.AlbumBean.makeIndexPages(AlbumBean.java:4219)

davidekholm

Posts: 3,802
Registered: 18-Oct-2002

Re: Split skin testing
Posted: 5 Jun 25, 16:15

in response to: davidekholm

Reply

I guess polishing the provided set of styles is an ongoing work? You don't need so many styles I think. Now they are plenty of them, but few if any change certain background colors.

Laza

Posts: 1,438
Registered: 6-Sep-2005

Re: Split skin testing
Posted: 5 Jun 25, 16:20

in response to: davidekholm

Reply

That's just a debug print. The real code does check the existence first.

Laza

Posts: 1,438
Registered: 6-Sep-2005

Re: Split skin testing
Posted: 5 Jun 25, 16:23

in response to: JeffTucker

Reply

It's the folder description for real, but I will have to clarify that it's about the Title page, not the lightbox image captions. That will be another box.

Laza

Posts: 1,438
Registered: 6-Sep-2005

Re: Split skin testing
Posted: 14 Jun 25, 12:51

in response to: Laza

Reply

Jeff, can you please create a "Split" forum?

JeffTucker

Posts: 8,009
Registered: 31-Jan-2006

Re: Split skin testing
Posted: 14 Jun 25, 14:15

in response to: Laza

Reply

Laza wrote:
Jeff, can you please create a "Split" forum?

Done. Skin entry in the repository seems OK, now.