|
Replies:
13
-
Pages:
1
-
Last Post:
6 Feb 25, 17:49
Last Post By: Laza
|
|
|
Posts:
170
Registered:
18-Jun-2010
|
|
|
|
Minor Gui bug report - wrong folder modification date label
Posted:
4 Feb 25, 23:19
|
|
|
|
|
Hello,
In the parameters panel, in Site / Hero / Title, the label for the folder modification date parameter is displayed as : <b><font color="blue">${folderModDate} =</font></b>
This remains understandable however
Edited by: JeffTucker on 4 Feb 2025, 17:23, to add "code" tags
|
|
|
Posts:
8,088
Registered:
31-Jan-2006
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
4 Feb 25, 23:27
in response to: phil44
|
|
|
|
I'm afraid I don't understand what you mean. Please tell us what you think the problem is.
|
|
|
Posts:
3,903
Registered:
4-Aug-2006
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
5 Feb 25, 00:26
in response to: phil44
|
|
|
It would appear to be a bug with Tiger. The gui seems to be using, for example
add("br", new JLabelFor("${folderModDate} =", folderDateSource));
Other gui elements are using the texts files as, for example
add("br", new JLabelFor(getText("ui.caption"), titleCaptionPresets));
It might be intended but looks wrong.
|
|
|
Posts:
8,088
Registered:
31-Jan-2006
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
5 Feb 25, 00:30
in response to: RobM
|
|
|
|
I think it's entirely intentional. It's telling the user, "if you use this variable as part of your custom caption template, this is what information it's going to grab." Anything else would be much more opaque.
|
|
|
Posts:
3,903
Registered:
4-Aug-2006
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
5 Feb 25, 00:37
in response to: JeffTucker
|
|
|
|
If you look at the image attached above you'll see (ringed in red) that the gui label for folderModDate is ${folderModDate}=
The texts file, for English shows
ui.folderModDate=Last file modification date
Maybe it is intentional, just looks weird though.
|
|
|
Posts:
3,903
Registered:
4-Aug-2006
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
5 Feb 25, 00:53
in response to: RobM
|
|
|
Ah, ok, sedation has worn off. ${folderModDate} appears on
https://jalbum.net/help/en/Skin/Tiger/Header/Hero
which includes both design and title tabs but the caption template doesn't appear on the gui's Hero>Title tab.
|
|
|
Posts:
8,088
Registered:
31-Jan-2006
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
5 Feb 25, 01:02
in response to: RobM
|
|
|
|
Well, it does, eventually. If you choose [Custom] as the Caption, then click somewhere below, the custom template appears. It's a little balky. In light of that, the JComboBox for ${folderModDate} probably shouldn't be visible until you've chosen to use a custom caption.
|
|
|
Posts:
170
Registered:
18-Jun-2010
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
5 Feb 25, 09:22
in response to: phil44
|
|
|
Jeff, I think you haven't seen the screenshot attached to the initial post: the problem is not in the choice of the title and its value, but in the Tiger GUI itself!
Apart from what is displayed in the Tiger panel, the parameter works as expected, the generated code and what is displayed in the galleries works fine
Also note that the modification you made in my original post does not reflect the problem encountered: what I had reported is not code, nor the content of a field filled by the user.
Sorry if I didn't express myself well at the beginning...
|
|
|
Posts:
1,464
Registered:
6-Sep-2005
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
5 Feb 25, 10:22
in response to: phil44
|
|
|
|
As long as the folder caption template was displayed as HTML code, it was clear that ${folderModDate} referred to a variable in the box above. But I changed it so the caption template is only displayed when the (Custom) option is used, as the HTML code was intimidating for many users. Now, it's confusing to see in this form, even though I'd like to keep the date source selector visible, as some options in that caption box are still using the date. I'll change the variable name to some more human-readable label, e.g., "Date source."
|
|
|
Posts:
8,088
Registered:
31-Jan-2006
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
5 Feb 25, 11:43
in response to: phil44
|
|
|
Jeff, I think you haven't seen the screenshot attached to the initial post: the problem is not in the choice of the title and its value, but in the Tiger GUI itself!
I am looking at the screenshot. We are all looking at the screenshot. And we still don't know what you think the problem is. Saying, "the problem is in the Tiger GUI itself" doesn't tell us anything.
What. Do. You. Think. The. Problem. Is?
|
|
|
Posts:
170
Registered:
18-Jun-2010
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
5 Feb 25, 17:02
in response to: JeffTucker
|
|
|
...
I am looking at the screenshot. We are all looking at the screenshot. And we still don't know what you think the problem is. Saying, "the problem is in the Tiger GUI itself" doesn't tell us anything.
What. Do. You. Think. The. Problem. Is?
The problem is that the JComboBox label is cryptic and doesn't explain what the JComboBox is for. I know what ${folderModDate} is (and so do you  ), but I think that's not the case for a lot of people.
When I was developing GUIs, there were 2 important rules:
- The label of an input component should explain what is being entered with that component. For example, Position or Caption are OK, but ${folderModDate} = is definitely not an explanation, especially for users who don't know jAlbum variables.
- A data should always be referred to in the same way or with the same wording, regardless of the location. Here, the data is the date, and is referred to as "date" in the caption predefined values, and "${folderModDate} =" in the dropdown label, and both refer to the same thing: this is inconsistent IMHO.
So, to be consistent, either should be "date" or "${folderModDate}", but I admit that a predefined Caption like "Title + ${folderModDate} + Description" is not very nice...
And just a note: this combo is displayed, even if there is no date in the selected caption (at least with predefined captions), it is not necessary. However, for custom captions, this is useful.
|
|
|
Posts:
170
Registered:
18-Jun-2010
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
6 Feb 25, 13:09
in response to: Laza
|
|
|
As long as the folder caption template was displayed as HTML code, it was clear that ${folderModDate} referred to a variable in the box above. But I changed it so the caption template is only displayed when the (Custom) option is used, as the HTML code was intimidating for many users. Now, it's confusing to see in this form, even though I'd like to keep the date source selector visible, as some options in that caption box are still using the date. I'll change the variable name to some more human-readable label, e.g., "Date source."
Thanks Laza !
Here is a proposed modification (based on version 6.4.3) that seems good to me: the date combo only appears when necessary and the date label matches the choice in the title combo.
If you like it, maybe you can integrate it into the next version of Tiger...
|
|
|
Posts:
170
Registered:
18-Jun-2010
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
6 Feb 25, 16:49
in response to: phil44
|
|
|
|
|
|
Oops, looks like there was a problem with the attachment, fixed!
|
|
|
Posts:
1,464
Registered:
6-Sep-2005
|
|
|
|
Re: Minor Gui bug report - wrong folder modification date label
Posted:
6 Feb 25, 17:49
in response to: phil44
|
|
|
|
Thanks. The next release will contain this logic.
|
|
|
|
Legend
|
|
Forum admins
|
|
Helpful Answer
|
|
Correct Answer
|
|