Posts:
103
Registered:
18-Jun-2010
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
5 Aug 24, 18:24
in response to: phil44
|
|
|
I tested the improvements David introduced in v35.0.5, here is what I think:
- As Jeff said, keeping titles and comments is a must-have.
- A hidden image is no longer hidden. I sometimes use a hidden image for the header, it can be annoying if this image suddenly becomes visible is you overwrite it.
- The image rating and color (red/green/blue...) are lost, this should not happen.
- The image data is also lost ("Hide GPS location" among others), this error prone.
- Like Jeff, I do not use keywords, but IMHO this could be a problem for keyword users.
- About image edition (e.g. cropping), I am uncertain
- It is reasonable to assume that if an image is overwritten in jAlbum, it is because it has been modified (probably enhanced) by a third-party tool, and therefore in this case, it is not necessary to keep the editing parameters specific to jAlbum.
- There is still a case that contradicts this: an image without position is imported into jAlbum and edited. When the user geotags the image in an external tool such as GeoSetter, he re-imports the image into jAlbum. In this case, the editing done on the image would be lost
However, this kind of case should be quite rare.
- Note: it is not currently possible to geotag the image in jAlbum since the map is no longer displayed in the editing tab.
|
|
|
Posts:
8,431
Registered:
31-Jan-2006
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
5 Aug 24, 19:23
in response to: phil44
|
|
|
If the .info file for an object is retained, most of those things would be preserved - title, flag, rating, keywords, and image editing.
Trying to figure out what image editing choices should be retained vs. what should not be retained, begins to get rather byzantine. The app can't really guess what you want, when considering things like level, gamma, effects, and so on. If you've done any image editing within jAlbum, but then replace the image, it's a simple matter for the user to remove all of the image editing and redo it.
Keeping the geotagging trickier. If you've manually geotagged the image, that's stored in the image's metadata. If the file is different, the new file brings its own metadata with it, as it should
Keeping the object excluded is not part of the .info file, but is, instead, part of albumfiles.txt. I suspect that retaining that setting would be fairly easy.
|
|
|
Posts:
103
Registered:
18-Jun-2010
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
5 Aug 24, 19:53
in response to: JeffTucker
|
|
|
If the .info file for an object is retained, most of those things would be preserved - title, flag, rating, keywords, and image editing.
Note that this file contains also image data and user variables:
<object class="java.util.HashMap">
<void method="put"><string>panorama</string><boolean>false</boolean></void>
<void method="put"><string>hideFotomoto</string><boolean>false</boolean></void>
<void method="put"><string>hideLocation</string><boolean>true</boolean></void>
<void method="put"><string>userVariables</string>...
ETA: I deduce from this manual page , custom panel section, that this kind of stuff can come from the skin...
Trying to figure out what image editing choices should be retained vs. what should not be retained, begins to get rather byzantine. The app can't really guess what you want, when considering things like level, gamma, effects, and so on. If you've done any image editing within jAlbum, but then replace the image, it's a simple matter for the user to remove all of the image editing and redo it.
Keeping the geotagging trickier. If you've manually geotagged the image, that's stored in the image's metadata. If the file is different, the new file brings its own metadata with it, as it should
Keeping the object excluded is not part of the .info file, but is, instead, part of albumfiles.txt. I suspect that retaining that setting would be fairly easy.
I agree!
|
|
|
Posts:
3,612
Registered:
18-Oct-2002
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
13 Aug 24, 10:11
in response to: phil44
|
|
|
Back from vacation  . Sounds to me that we're to keep the .info files and ideally also the excluded state.
|
|
|
Posts:
3,612
Registered:
18-Oct-2002
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 14:36
in response to: davidekholm
|
|
|
You can now try v35.1b1 which saves metadata as well when replacing an existing image within jAlbum. All at https://jalbum.net/download/beta/jalbum-core.jar
(This one isn't keeping the included state though. That's harder to fix)
|
|
|
Posts:
8,431
Registered:
31-Jan-2006
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 16:12
in response to: davidekholm
|
|
|
In some quick tests, it seems to be well-behaved. I think this will do was most users want, in most situations. There will probably be exceptions, but the app can't read the user's mind every time, and in those situations, workarounds are available.
There is still one image replacement quirk, only tangentially related to this, and it's been there forever. It involves replacing the image that is being used for the theme/hero image.
Say you replace the image that's being used as the theme image with an image with the same name, but different content. Or you replace the image with one that's been cropped differently, outside of jAlbum. The thumbnail and slide image are regenerated, which is exactly what you want. But the theme image is not regenerated.
The workarounds are very simple. You can quickly select another image as the theme image, then immediately choose the original one again. Or you can just "tap" the theme image crop mask. Or you can change the file name of the image (add an "A" to it, for example). If you do any one of those things, you get a new theme image, and everything's good.
In short, it might not be worth tackling this. I suspect it happens pretty rarely, and even when it does, the fix is easy.
|
|
|
Posts:
103
Registered:
18-Jun-2010
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 17:15
in response to: davidekholm
|
|
|
Here is what I see when I overwrite an image:
- Comments are kept.
- Titles are kept, as well as the data stored in the .info file (variables, image data, etc).
- The fact that an image is excluded is lost.
- Keywords of an image are also lost (but this does not matter for me).
Except the 3rd point, all that seems pretty good to me
Edited by: phil44 on 14 Aug 2024, 17:51
Rewritten after correct installation of the beta (35.1b1)
|
|
|
Posts:
8,431
Registered:
31-Jan-2006
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 17:38
in response to: phil44
|
|
|
|
When restarted, the jAlbum version displayed in About is still 35.0.5. Correct?
Nope. You should be seeing this - screenshot.
|
|
|
Posts:
3,612
Registered:
18-Oct-2002
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 17:53
in response to: JeffTucker
|
|
|
You really need to replace the old jalbum-core.jar file, not just rename it for instance. The splash screen should read v35.1b1
|
|
|
Posts:
3,972
Registered:
4-Aug-2006
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 18:01
in response to: phil44
|
|
|
You could use this external tool to do the replacement for you.
|
|
|
Posts:
103
Registered:
18-Jun-2010
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 18:04
in response to: davidekholm
|
|
|
You really need to replace the old jalbum-core.jar file, not just rename it for instance. The splash screen should read v35.1b1
Thanks David & Jeff for yours hints, this is correct now on my side.
Please see my comments in my previous post which I have edited with my latest test results.
|
|
|
Posts:
8,431
Registered:
31-Jan-2006
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 18:18
in response to: phil44
|
|
|
- Keywords of an image are also lost
In my tests, keywords are retained.
For testing, add some keywords, then close and reopen the project before replacing the image. I have a suspicion that this is the sort of information that may not get written out to the control files immediately, but only upon project closing. Just a hunch.
|
|
|
Posts:
3,612
Registered:
18-Oct-2002
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 19:03
in response to: JeffTucker
|
|
|
When I test, keywords are kept. They are written to the .info files as soon as you edit them.
|
|
|
Posts:
103
Registered:
18-Jun-2010
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 19:21
in response to: JeffTucker
|
|
|
|
- Keywords of an image are also lost
In my tests, keywords are retained.
For testing, add some keywords, then close and reopen the project before replacing the image. I have a suspicion that this is the sort of information that may not get written out to the control files immediately, but only upon project closing. Just a hunch.
There is some strange behavior with the keywords, I don't know if this is related to the changes in the beta:
- Lets say I have project A and project B
- I open project A and in the explorer view, I set the keywords to be visible (button in the upper right corner)
- I set a keyword on a image, then I switch to project B to be sure the keyword is stored somewhere, then I reopen project A : the keyword is displayed. I close and re-open jAlbum, the keyword is always here. Oddly, it seems that no control file within the project is modified after entering the keyword.
- I overwrite the image having the keyword: the keyword is no longer here under the thumbnail, but is always visible in the bottom of the screen (see screenshots).
- I switch to project B and return to project A : the keyword is definitely lost!
|
|
|
Posts:
103
Registered:
18-Jun-2010
|
|
|
Re: Please keep comments when an image is overwritten
Posted:
14 Aug 24, 19:52
in response to: davidekholm
|
|
|
|
When I test, keywords are kept. They are written to the .info files as soon as you edit them.
I have more details on this. You have two ways to enter keywords:
- In explore view, keywords mode. Here you can enter keywords directly under a thumbnail
- In edit view, there is a field for keywords in the Description pane (see capture)
If I enter keywords using the 1st method, I have the behavior you describe David & Jeff, and the .info file is modified accordingly (strangely, the file contents changes, but not the file modification time).
But if I enter the keywords using the 2nd method, I have the behavior I described before 
|
|
|
|
Legend
|
|
Forum admins
|
|
Helpful Answer
|
|
Correct Answer
|
|