This question is answered. Helpful answers available: 2. Correct answers available: 1.


Permlink Replies: 39 - Pages: 3 [ 1 2 3 | Next ] - Last Post: 15 Aug 24, 13:42 Last Post By: phil44 Threads: [ Previous | Next ]
phil44

Posts: 89
Registered: 18-Jun-2010
Please keep comments when an image is overwritten
Posted: 20 Jul 24, 16:42
 
  Click to reply to this thread Reply
Let's say you have an image in an album and that image has comments.

If you edit the original image (the one that was copied to the album) and drag and drop that image into jAlbum again, it detects that the image already exists in the album. So it displays a dialog box to let the user choose the appropriate action. If you choose to replace (overwrite) the existing image, its comment will be deleted!

It would be nice if the comment was kept in such a case :-)
JeffTucker

Posts: 8,225
Registered: 31-Jan-2006
Re: Please keep comments when an image is overwritten
Posted: 20 Jul 24, 17:03   in response to: phil44 in response to: phil44
 
  Click to reply to this thread Reply
I agree - this has annoyed me in the past.

Pro tip, however: do your image file replacement outside of jAlbum, in the operating system. When you reopen the project, jAlbum will know that it has to reprocess the images, but the titles and comments will still be there. :)
phil44

Posts: 89
Registered: 18-Jun-2010
Re: Please keep comments when an image is overwritten
Posted: 21 Jul 24, 12:01   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
JeffTucker wrote:
Pro tip, however: do your image file replacement outside of jAlbum, in the operating system.
When you reopen the project, jAlbum will know that it has to reprocess the images, but the titles and comments will still be there. :)

Thanks Jeff for this way of doing things, I hadn't thought of that.

However, in this way, we must be careful when importing a batch of images mixing new images and already existing images: to do this correctly, we must drag & drop the new images into the jAlbum window and manually copy existing images modified outside jAlbum. Not very convenient :-(
davidekholm

Posts: 3,483
Registered: 18-Oct-2002
Re: Please keep comments when an image is overwritten
Posted: 31 Jul 24, 19:29   in response to: phil44 in response to: phil44
 
  Click to reply to this thread Reply
In the current versions, jAlbum's comment source has priority so you should just be able to import any batch of images and still see your comments.
JeffTucker

Posts: 8,225
Registered: 31-Jan-2006
Re: Please keep comments when an image is overwritten
Posted: 31 Jul 24, 19:48   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
Start a new project. Add one image. Enter a comment for it. Now add the same image again, and tell jAlbum to replace the object. The comment vanishes.

ETA: Ditto for an entered title. It appears that a "replace" does a "delete" (which cleans out "unneeded" stuff), followed by an "add."
davidekholm

Posts: 3,483
Registered: 18-Oct-2002
Re: Please keep comments when an image is overwritten
Posted: 1 Aug 24, 12:02   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
JeffTucker wrote:
Start a new project. Add one image. Enter a comment for it. Now add the same image again, and tell jAlbum to replace the object. The comment vanishes.

ETA: Ditto for an entered title. It appears that a "replace" does a "delete" (which cleans out "unneeded" stuff), followed by an "add."


Yes, when you select "replace" jAlbum does a delete prior to replacing. I've now removed the delete call in v35.0.4. Just do a core update to get it.
JeffTucker

Posts: 8,225
Registered: 31-Jan-2006
Re: Please keep comments when an image is overwritten
Posted: 1 Aug 24, 12:46   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
Attachment ss012461.png (231.9 KB)
There's a catch. There's always a catch. If you replace an image with one that has the same name, but is actually a different image, weird things sometimes happen.

The attached screenshot is an extreme example. I replaced an image (classic auto) with an image with the same name, but it's a different image (Death Valley). The project thumbnail and the theme image have changed, but the object thumbnail has not. And the generated album is still using the classic auto, even for the theme image.

A Force Remake clears up the album, but the Explore view thumbnail remains unless you manually delete the cached thumbnail.

The same problem shows up if you edit the image outside of jAlbum (cropping it, for example), then add it again, as a "replace." The album build doesn't use the new version of the image until you force the issue. This is more serious, since it's a much more common user action.

There was a good reason for doing a "delete" when there was a replacement - it was much more reliable when it came to the follow-on effects. Needs a little rethink.
JeffTucker

Posts: 8,225
Registered: 31-Jan-2006
Re: Please keep comments when an image is overwritten
Posted: 1 Aug 24, 13:31   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
I haven't tested it, but I suspect there will also be a problem with image editing information being retained following a replacement, something you probably don't want to have happen. The "deletion first" took care of that.
davidekholm

Posts: 3,483
Registered: 18-Oct-2002
Re: Please keep comments when an image is overwritten
Posted: 3 Aug 24, 19:21   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
Ok, I've now adjusted jAlbum so all files but the comments are deleted when replacing existing objects. Just get v35.0.5 via a core update.
JeffTucker

Posts: 8,225
Registered: 31-Jan-2006
Re: Please keep comments when an image is overwritten
Posted: 3 Aug 24, 20:30   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
Yes, that's much better behaved. :)

I'd vote for hanging on to entered titles as well as comments, though since those are shorter, it's somewhat less important. Still, having to reenter a bunch of them would be irritating.

Someone will probably also ask for keywords. About that, I don't care, since I never use them. Not sure how many users make extensive use of them, however.
davidekholm

Posts: 3,483
Registered: 18-Oct-2002
Re: Please keep comments when an image is overwritten
Posted: 3 Aug 24, 22:08   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
JeffTucker wrote:
Yes, that's much better behaved. :)

I'd vote for hanging on to entered titles as well as comments, though since those are shorter, it's somewhat less important. Still, having to reenter a bunch of them would be irritating.

Someone will probably also ask for keywords. About that, I don't care, since I never use them. Not sure how many users make extensive use of them, however.


In case I keep titles and comments, I'll happily keep edits as well. That way I can simply leave the .info files.
JeffTucker

Posts: 8,225
Registered: 31-Jan-2006
Re: Please keep comments when an image is overwritten
Posted: 3 Aug 24, 22:48   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
I'll have to mull that over, and other users might have some thoughts about that.

If someone has been using the image editing tools, then replaces the original, he probably deserves whatever he gets. And he can always just remove all of the edits with a click, and start over.

I'm not sure about the effects with other kinds of AO's, like videos, in which other info about the object is stored in those files. But this might be wandering into "fringe case" territory.
davidekholm

Posts: 3,483
Registered: 18-Oct-2002
Re: Please keep comments when an image is overwritten
Posted: 3 Aug 24, 22:51   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
I'll be going on a one week trip to Croatia, so you will probably not hear from me during this time, but I'll check out the votes here when I get back :-)
JeffTucker

Posts: 8,225
Registered: 31-Jan-2006
Re: Please keep comments when an image is overwritten
Posted: 3 Aug 24, 22:55   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
Now, I thought we had cleared up the matter of these unauthorized absences, during our little conference with the HR people last week.
davidekholm

Posts: 3,483
Registered: 18-Oct-2002
Re: Please keep comments when an image is overwritten
Posted: 3 Aug 24, 23:10   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
Uh, me bad, me bad ... ;-)
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums