|
Replies:
10
-
Pages:
1
-
Last Post:
31 Jul 23, 16:48
Last Post By: RobM
|
Threads:
[
Previous
|
Next
]
|
|
Posts:
1,116
Registered:
14-Dec-2007
|
|
|
|
Bug: Image edits are not applied to the theme image.
Posted:
30 Jul 23, 10:34
|
|
|
If you edit an image in jAlbum, the changes are only applied in the slide image.
But if you use the same image as theme image, the edits are not applied.
As an example see this slide image where the skewed horizon has been corrected. But as you see here, the horizon in the theme image is still skewed. |
|
|
Posts:
4,133
Registered:
4-Aug-2006
|
|
|
|
Re: Image edits are not applied to the theme image.
Posted:
30 Jul 23, 11:09
in response to: AndreWolff
|
|
|
|
Moved to feature requests, it is not a bug.
|
|
|
Posts:
1,116
Registered:
14-Dec-2007
|
|
|
|
Re: Image edits are not applied to the theme image.
Posted:
30 Jul 23, 11:24
in response to: RobM
|
|
|
Moved to feature requests, it is not a bug.
Of course this is a bug, why would someone want to show the same photo twice, once with a crooked horizon and once with a straight horizon?
There's nothing wrong with the word bug, the very best programs still contain bugs!
You should not change posts of the original poster! |
|
|
Posts:
4,133
Registered:
4-Aug-2006
|
|
|
|
Re: Image edits are not applied to the theme image.
Posted:
30 Jul 23, 11:55
in response to: AndreWolff
|
|
|
|
How theme images are implemented is a function of the core and/or the skin. There are three ways of generating the theme image, one being under skin control.
Also image edits can include cropping and other actions, some of which the end user may or may not want to be applied to the theme image.
The simple solution is to correct the photographer’s error when taking the photos or before importing to jAlbum. After that double processing the image to correct the photo.
We’ll see what David has to say.
|
|
|
Posts:
1,116
Registered:
14-Dec-2007
|
|
|
|
Re: Image edits are not applied to the theme image.
Posted:
30 Jul 23, 13:31
in response to: RobM
|
|
|
Also image edits can include cropping and other actions, some of which the end user may or may not want to be applied to the theme image.
Yes, therefore it should be possible to edit the theme image as I proposed here.
The simple solution is to correct the photographer’s error when taking the photos or before importing to jAlbum. After that double processing the image to correct the photo.
Of course, I think all photo edit functions should be removed from jAlbum, which leads to less maintenance and a more simple UI. |
|
|
Posts:
4,059
Registered:
18-Oct-2002
|
|
|
|
Re: Image edits are not applied to the theme image.
Posted:
31 Jul 23, 12:42
in response to: AndreWolff
|
|
|
|
I'll ponder on this. It seems reasonable that either, the edits to the target image are applied to the theme image as well or that you can do separate edits to the theme image.
However, respecting edits to the target image may give unwanted changes to existing galleries when rebuilding them...
|
|
|
Posts:
4,133
Registered:
4-Aug-2006
|
|
|
|
Re: Image edits are not applied to the theme image.
Posted:
31 Jul 23, 12:55
in response to: davidekholm
|
|
|
I'll ponder on this. It seems reasonable that either, the edits to the target image are applied to the theme image as well or that you can do separate edits to the theme image.
However, respecting edits to the target image may give unwanted changes to existing galleries when rebuilding them...
Is there, or will there be a way of implementing this using method 3, postdir.groovy for creating theme images? |
|
|
Posts:
8,652
Registered:
31-Jan-2006
|
|
|
|
Re: Image edits are not applied to the theme image.
Posted:
31 Jul 23, 13:52
in response to: davidekholm
|
|
|
|
|
|
The same thing applies to images used as folder thumbnails. The image edits are applied to the single image, but not to the folder thumbnail.
In the attached screenshots, I purposely made the image crooked, using the jAlbum image editor, just to make the problem obvious. The jAlbum edit (making it crooked) is applied to the single image, but the folder thumbnail is using the original, unedited version.
There shouldn't be any conflicts between uses of the image - single image, folder thumbnail, theme image - for most editing operations, like straightening, color correction, gamma, etc.
It only threatens to get a little weird when dealing with cropping. That's where you might want to apply different cropping to the image, especially when you're talking about single image vs. theme image. But if someone really wants different cropping for the theme image, he should add a copy of the original image, use it for the theme, then exclude it.
|
|
|
Posts:
8,652
Registered:
31-Jan-2006
|
|
|
|
Re: Image edits are not applied to the theme image.
Posted:
31 Jul 23, 14:26
in response to: JeffTucker
|
|
|
|
|
|
One more little tidbit.... The Explore view shows the edited folder thumbnail (attached). The finished album uses the unedited version.
|
|
|
Posts:
4,059
Registered:
18-Oct-2002
|
|
|
|
Re: Image edits are not applied to the theme image.
Posted:
31 Jul 23, 16:30
in response to: RobM
|
|
|
That's an option. You just need to call ai.applyFilters(stage here) to apply filters as well, and not just the crop filter, so instead of just: ai = ai.scaleToFit(themeDim);
write ai = ai.applyFilters(JAFilter.ALL_POSTSCALE_STAGE);
ai = ai.scaleToFit(themeDim);
ai = ai.applyFilters(JAFilter.CLOSEUPS_POSTSCALE_STAGE);
|
|
|
Posts:
4,133
Registered:
4-Aug-2006
|
|
|
|
Re: Image edits are not applied to the theme image.
Posted:
31 Jul 23, 16:41
in response to: davidekholm
|
|
|
That's an option. You just need to call ai.applyFilters(stage here) to apply filters as well, and not just the crop filter, so instead of just: ai = ai.scaleToFit(themeDim);
write ai = ai.applyFilters(JAFilter.ALL_POSTSCALE_STAGE);
ai = ai.scaleToFit(themeDim);
ai = ai.applyFilters(JAFilter.CLOSEUPS_POSTSCALE_STAGE);
Thanks, that makes it something skin developers can easily do for the theme images. |
|
|
|
Legend
|
|
Forum admins
|
|
Helpful Answer
|
|
Correct Answer
|
|
