This question is answered. Helpful answers available: 2. Correct answers available: 1.


Permlink Replies: 8 - Pages: 1 - Last Post: 17 Sep 23, 22:46 Last Post By: JeffTucker Threads: [ Previous | Next ]
JeffTucker

Posts: 7,991
Registered: 31-Jan-2006
Remove requiredJavaVersion from skin.properties
Posted: 28 Apr 23, 15:17
 
  Click to reply to this thread Reply
The core is no longer checking the value of requiredJavaVersion that's stored in skin.properties, so it's not serving any purpose. Stale values that are still there are just misleading - what really matters is the version of jAlbum that's required, which implies the Java version that's available in the bundle. A skin developer shouldn't be compiling things like the UI to any higher version of Java (and at present, should probably be sticking to Java 14 as the source/binary).

The field also needs to be removed from the skin properties editor (ALT-S). Invoking the editor and saving the file results in a saved value of 1.5.

The skin properties editor could use some refreshing (missing fields), but since a user should never be tinkering with those settings, further refinement is a very low priority. I use it only to bump the last modified date. For anything else, I just open it in a text editor.
JeffTucker

Posts: 7,991
Registered: 31-Jan-2006
Re: Remove requiredJavaVersion from skin.properties
Posted: 13 Sep 23, 16:43   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
A few more thoughts on this....

The skin properties editor should sort the file entries automatically (just as .jap file entries are now sorted). If I open one of those files in a text editor, I have to go hunting for things. If I sort the entries, but then later use the editor to bump the modified date, for example, the entries are once again unsorted, which is irritating.

Ideally, the skin properties editor should include all of the available fields, listed here:

https://jalbum.net/api/se/datadosen/jalbum/SkinProperties.html

But in addition to REQUIRED_JAVA_VERSION, which is no longer used, it's also time to retire TRUE_ORIGINAL_PATH, also obsolete. And is there any current skin that's using the COMPATIBILITY_MODE flag? Maybe leave it in the core to accommodate ancient skins, but no need for it in the skin properties editor.
davidekholm

Posts: 3,433
Registered: 18-Oct-2002
Re: Remove requiredJavaVersion from skin.properties
Posted: 16 Sep 23, 15:28   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
Thanks. I'll put this on the todo.
JeffTucker

Posts: 7,991
Registered: 31-Jan-2006
Re: Remove requiredJavaVersion from skin.properties
Posted: 16 Sep 23, 16:29   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
Sorting the lines is high on my list. The rest of it is much less important, since I'm often just modifying the properties files in a text editor anyway.

Did a quick check, and no current skin is using compatibility mode. Given how old it is (jAlbum 10.3 was released in January, 2012, and that's the version that triggered the need for it), that could probably be stripped out of the core entirely. It probably falls into the category of "unreachable code." ;)
davidekholm

Posts: 3,433
Registered: 18-Oct-2002
Re: Remove requiredJavaVersion from skin.properties
Posted: 16 Sep 23, 18:39   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
Attachment JTextPad.jar (112.8 KB)
Ok, do a core update to 32.1.5 now in order to get ordered skin properties. Also, here's an updated skin property editor attached. Put it inside jAlbum's ext folder.
JeffTucker

Posts: 7,991
Registered: 31-Jan-2006
Re: Remove requiredJavaVersion from skin.properties
Posted: 16 Sep 23, 19:05   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
Big improvements. Thanks. :)
davidekholm

Posts: 3,433
Registered: 18-Oct-2002
Re: Remove requiredJavaVersion from skin.properties
Posted: 17 Sep 23, 13:57   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
You're welcome :-)
mrag

Posts: 336
Registered: 26-Jul-2003
Re: Remove requiredJavaVersion from skin.properties
Posted: 17 Sep 23, 21:04   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
Totally off-topic, but at least half the US of A has no clue how and when to employ your or you're and the Swedish guy gets it on the first try.
JeffTucker

Posts: 7,991
Registered: 31-Jan-2006
Re: Remove requiredJavaVersion from skin.properties
Posted: 17 Sep 23, 22:46   in response to: mrag in response to: mrag
 
  Click to reply to this thread Reply
David actually left the company about a year ago. This poster is a chatbot.
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums