Posts:
8,099
Registered:
31-Jan-2006
|
|
|
|
Re: Testing the new Plain skin
Posted:
28 Apr 23, 15:01
in response to: RobM
|
|
|
Not had a chance to try the skin yet, but I noticed in skin properties you have
requiredJavaVersion=1.8
Isn’t it time to move to 14?
The core doesn't actually check that value any longer. It should be removed from skin.properties entirely.
(ETA: And it needs to be removed from the skin properties editor, because the editor puts it back, with a default value of 1.5.)
And since there isn't anything in Plain that's compiled, the only relevant requirement is the version of jAlbum itself that's needed.
If a skin developer does have a compiled UI, for example, and he foolishly compiles it to a Java version that's higher than what the required jAlbum version provides, the skin won't load. It's an instantly-recognizable mistake.  |
|
|
Posts:
8,099
Registered:
31-Jan-2006
|
|
|
|
Re: Testing the new Plain skin
Posted:
3 May 23, 18:42
in response to: JeffTucker
|
|
|
Probably the same error as Jeff reported, with production 30.2 now.
No, completely different. It's triggered if you turn off folder thumbnail processing under Settings > Images > General.
Still getting this crash in v. 0.91. If you turn off folder thumbnail processing, it crashes, even if you've told the skin to mix the folder thumbnails with the regular image thumbnails. |
|
|
Posts:
8,099
Registered:
31-Jan-2006
|
|
|
|
Re: Testing the new Plain skin
Posted:
3 May 23, 20:43
in response to: JeffTucker
|
|
|
|
|
This looks like a style error, to me. With the light style, I'm getting a top level page in one color scheme, but subfolders in another.
https://jefftucker.jalbum.net/plaintest/
In the same album, I'm getting some thumbnail justification failures. See the screenshot. |
|
|
Posts:
1,116
Registered:
14-Dec-2007
|
|
|
|
Re: Testing the new Plain skin
Posted:
4 May 23, 11:50
in response to: Laza
|
|
|
Hi Laza,
I tried to test your new skin with this video test album made with my PhotoSwipe skin , but I get a crash:
Stack trace for jAlbum 30.2 using skin Plain 0.92:
se.datadosen.util.ScriptException: <eval>:20 ReferenceError: "thumbboxHeight" is not defined in common.css at line number 4
at se.datadosen.util.ScriptException.of(ScriptException.java:59)
at se.datadosen.jalbum.ast.ScriptletNode.doEval(ScriptletNode.java:99)
Quit frankly I don't understand that you did select the PhotoSwipe light-box, because this light-box has no video support, no slide show and no next slide transitions.
These items are all supported by the lightGallery light-box which is easy to integrate, see my LightGallery skin.
I added both video support and slide-show support to the PhotoSwipe light-box, but certainly the combination of both items is quit tricky.
Anyhow I have one request for your new skin:
Please add support for a menu.
If you as the master skin developer implements that, it can be copied to other skin developers with less experience like me.
I have implemented a menu in my skins, but that design has been copied from your old Base skin. I still works as you can see here but I think that code is very old and difficult to maintain, so a new design is very welcome! |
|
|
Posts:
8,099
Registered:
31-Jan-2006
|
|
|
|
Re: Testing the new Plain skin
Posted:
4 May 23, 13:23
in response to: AndreWolff
|
|
|
|
The Plain skin handles videos without any problem. That's not the source of the error you're getting. I've already identified the source of the error, above.
The lack of slide transitions, if that's true, is certainly a problem, when there are other, better lightbox scripts available. For a simple, plain skin, the lack of an automated slideshow doesn't concern me. If a user wants a timed slideshow, there are plenty of other skins available.
But if the PhotoSwipe lightbox script is unsuitable, why haven't you retired the PhotoSwipe skin? Does it offer something your other skins do not?
|
|
|
Posts:
1,116
Registered:
14-Dec-2007
|
|
|
|
Re: Testing the new Plain skin
Posted:
4 May 23, 14:09
in response to: JeffTucker
|
|
|
The Plain skin handles videos without any problem. That's not the source of the error you're getting. I've already identified the source of the error, above.
Well I don't know what you did, but indeed if I import the settings from your album, the crash is absent.
I get this Plain video test album, normal videos are OK, although the videos don't start automatilly, but YouTube anf Vimeo videos are only on the thumbnails page, not in the light-box.
But if the PhotoSwipe lightbox script is unsuitable, why haven't you retired the PhotoSwipe skin? Does it offer something your other skins do not?
I did not say that the PhotoSwipe lightbox script is unsuitable, I said that the LightGallery light-box requires less extra code and has far better transitions.
Edited by: AndreWolff on 4 May 2023, 14:11 |
|
|
Posts:
8,099
Registered:
31-Jan-2006
|
|
|
|
Re: Testing the new Plain skin
Posted:
5 May 23, 23:18
in response to: JeffTucker
|
|
|
It's triggered if you turn off folder thumbnail processing under Settings > Images > General.
Still crashing in the released v. 1.0. |
|
|
Posts:
1,116
Registered:
14-Dec-2007
|
|
|
|
Re: Testing the new Plain skin
Posted:
6 May 23, 08:45
in response to: Laza
|
|
|
And I will also have to write some code to use the variants on the thumbnails too.
Please give me one good reason, why you should use variants for thumbnails. |
|
|
Posts:
1,631
Registered:
6-Sep-2005
|
|
|
|
Re: Testing the new Plain skin
Posted:
7 May 23, 20:49
in response to: JeffTucker
|
|
|
folder thumbnail processing
What is that option for? Why would anybody disable it? |
|
|
Posts:
1,631
Registered:
6-Sep-2005
|
|
|
|
Re: Testing the new Plain skin
Posted:
7 May 23, 20:50
in response to: AndreWolff
|
|
|
Please give me one good reason, why you should use variants for thumbnails.
Any device with retina screen. |
|
|
Posts:
8,099
Registered:
31-Jan-2006
|
|
|
|
Re: Testing the new Plain skin
Posted:
7 May 23, 21:15
in response to: Laza
|
|
|
folder thumbnail processing
What is that option for? Why would anybody disable it?
Granted, no one should disable it. But the skin should make that checkbox inaccessible, and force it to "enabled." No setting should ever cause a crash.
In skin.properties: disabledControls=processFolderThumbs
And in init.js: engine.setProcessFolderThumbs(true);
ETA: Of course, if you don't think anyone would ever disable that setting, why is this code in common.css? if (engine.isProcessFolderThumbs()) {
folderboxWidth = maxFolderThumbWidth + (useLineborder ? (2 * (borderPadding + borderWidth)) : 0);
folderboxHeight = maxFolderThumbHeight + (useLineborder ? (2 * (borderPadding + borderWidth)) : 0);
} else {
folderboxWidth = thumbboxWidth;
folderboxHeight = thumbboxHeight;
}
This is where the crash is coming from - thumbboxHeight is undefined. |
|
|
Posts:
8,099
Registered:
31-Jan-2006
|
|
|
|
Re: Testing the new Plain skin
Posted:
7 May 23, 21:17
in response to: Laza
|
|
|
I selected this lightbox because David has fallen in love with a gallery on dpreview that was using this script. 
The lack of smooth image transitions makes it look like someone else's skin.
ETA: Of course, a user could just use Neptune, and turn off the theme image if he wants to keep it even more simple:
https://jefftucker.jalbum.net/skins/neptune/light/
 |
|
|
Posts:
8,099
Registered:
31-Jan-2006
|
|
|
|
Re: Testing the new Plain skin
Posted:
7 May 23, 21:22
in response to: Laza
|
|
|
It's version 1.0 - it was never intended to display Youtube or Vimeo videos. Perhaps later. But this skin is not made to replace Tiger. It's called "Plain" with a reason.
Supporting YouTube and Vimeo, as you know, always requires a fair amount of "screwing around" (technical term), and the results are never wonderful, anyway. I'd leave it out of a "plain" skin. I decided to include it in Atom only because I was bored one afternoon. There are plenty of other skins that support YouTube videos - it doesn't have to be in every skin.
(BTW, the last time I looked at the YouTube API, it was still a festival of incorrect stuff. Truth is that they really want viewers to come to their site, where they can generate ad revenue.) |
|
|
|
Legend
|
|
Forum admins
|
|
Helpful Answer
|
|
Correct Answer
|
|
