Posts:
8,222
Registered:
31-Jan-2006
|
|
|
|
Re: Skin style files are not always copied
Posted:
13 Feb 23, 16:32
in response to: davidekholm
|
|
|
|
Basic rule for regression: a new capability that alters an expected behavior, one that an unknown number of skins may be relying on, should default to false, to avoid breakage.
I don't want to resurrect retired skins, solely to make this change. But people are still using them, and now they'll start getting incorrect results, and will assume it's a bug. That's exactly what ctwist assumed when he first encountered the problem, just as I did, the first time I hit it.
|
|
|
Posts:
3,480
Registered:
18-Oct-2002
|
|
|
|
Re: Skin style files are not always copied
Posted:
13 Feb 23, 16:43
in response to: JeffTucker
|
|
|
|
I agree with that principle. I'm just hoping and assuming that, with now detecting style changes as well, we're down to very few skins.
|
|
|
Posts:
8,222
Registered:
31-Jan-2006
|
|
|
|
Re: Skin style files are not always copied
Posted:
13 Feb 23, 16:45
in response to: davidekholm
|
|
|
I'm just hoping and assuming that... we're down to very few skins.
We'll never know. Which is sort of the point.  |
|
|
Posts:
443
Registered:
27-Sep-2003
|
|
|
|
Re: Skin style files are not always copied
Posted:
13 Feb 23, 18:38
in response to: davidekholm
|
|
|
|
After upgrading to 30.0.1, jAlbum refuses to start. Task Manager shows that no jAlbum or Java processes are running. jAlbum.exe, StartjAlbum.cmd and StartjAlbum-debug.cmd all have the same behaviour.
I reverted to 30.0.0, and jAlbum.exe starts normally. In Help/About/System, I verified that all the correct folders are accessed (i.e. no components from old Java).
|
|
|
Posts:
8,222
Registered:
31-Jan-2006
|
|
|
|
Re: Skin style files are not always copied
Posted:
13 Feb 23, 18:50
in response to: ctwist
|
|
|
|
Strange - works fine for me.
|
|
|
Posts:
3,480
Registered:
18-Oct-2002
|
|
|
|
Re: Skin style files are not always copied
Posted:
14 Feb 23, 10:28
in response to: ctwist
|
|
|
After upgrading to 30.0.1, jAlbum refuses to start. Task Manager shows that no jAlbum or Java processes are running. jAlbum.exe, StartjAlbum.cmd and StartjAlbum-debug.cmd all have the same behaviour.
I reverted to 30.0.0, and jAlbum.exe starts normally. In Help/About/System, I verified that all the correct folders are accessed (i.e. no components from old Java).
Strange. Try running jAlbum using the "StartJAlbum-debug.cmd" and report any error message printed to the command window (use window control menu, then copy and paste the text content) |
|
|
Posts:
3,480
Registered:
18-Oct-2002
|
|
|
|
Re: Skin style files are not always copied
Posted:
14 Feb 23, 10:31
in response to: JeffTucker
|
|
|
I'm just hoping and assuming that... we're down to very few skins.
We'll never know. Which is sort of the point.
I've updated to v30.0.2 now. This version should really reduce this problem further: I now also check if the file sizes between the source and destination folders differ. If they do, I always copy the resource file. (Doing this check costs no further IO as I'm reading all file attributes from the source and destination folders anyway) |
|
|
Posts:
8,222
Registered:
31-Jan-2006
|
|
|
|
Re: Skin style files are not always copied
Posted:
14 Feb 23, 10:47
in response to: davidekholm
|
|
|
|
I surrender. If you get any support cases regarding one of my defunct skins, send them to me, and I'll provide a patched "final version" of the skin in question.
Silly me, thinking there was a simple solution.
|
|
|
Posts:
3,480
Registered:
18-Oct-2002
|
|
|
|
Re: Skin style files are not always copied
Posted:
14 Feb 23, 12:40
in response to: JeffTucker
|
|
|
|
The only scenario I can think of where there will be problems is when the skin lacks the "cleanResFolder=true" property AND it intends to copy different resource files with the same name and the same length. In such scenario, the resource file wouldn't be copied.
|
|
|
Posts:
443
Registered:
27-Sep-2003
|
|
|
|
Re: Skin style files are not always copied
Posted:
14 Feb 23, 14:23
in response to: davidekholm
|
|
|
Strange. Try running jAlbum using the "StartJAlbum-debug.cmd" and report any error message printed to the command window (use window control menu, then copy and paste the text content)
I had overlooked a message that scrolled off the top: Error: se.datadosen.jalbum.JAlbum
java.lang.ClassNotFoundException: se.datadosen.jalbum.JAlbum
at java.base/java.net.URLClassLoader.findClass(Unknown Source)
at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
at se.datadosen.jalbum.Main.main(Main.java:40)
URLs found:
< long list of URLs>
|
|
|
Posts:
443
Registered:
27-Sep-2003
|
|
|
|
Re: Skin style files are not always copied
Posted:
14 Feb 23, 14:32
in response to: ctwist
|
|
|
|
However, 30.0.2 starts without a problem.
This will have to remain a mystery.
|
|
|
Posts:
3,480
Registered:
18-Oct-2002
|
|
|
|
Re: Skin style files are not always copied
Posted:
14 Feb 23, 16:11
in response to: ctwist
|
|
|
|
That kind of error is to be expected if the jalbum-core.jar file isn't found or broken.
|
|
|
|
Legend
|
|
Forum admins
|
|
Helpful Answer
|
|
Correct Answer
|
|
