This question is answered. Helpful answers available: 2. Correct answers available: 1.


Permlink Replies: 4 - Pages: 1 - Last Post: 31 Dec 22, 23:34 Last Post By: PhilippeCharles Threads: [ Previous | Next ]
PhilippeCharles

Posts: 131
Registered: 8-Dec-2012
Projector - Bug report - Regression for comment display
Posted: 12 Nov 22, 15:47
 
  Click to reply to this thread Reply
A small regression has been introduced around the version 2.3.0, that is visible only when you display an album on a mobile device with lower resolution than today's standard (e.g. 1280x720 instead of 1920x1080 pixels).

It looks like the left and right margins to display a comment versus the edge of the image has been increased a lot, apparently up to 160 pixels. This adds to the margin of the image itself versus the edge of the screen (32 pixels).

This means that on a 1280x720 pixels screen, when you hold your device vertically, the text of your comment is now displayed on a width of:
720 - 2*160 - 2*32 = 336 pixels only ... less than half of your screen!

Thus your comment text is now displayed on 4 lines instead of 2 earlier (see the attached mobile screenshot).

This margin of 160 pixels is hard-coded; the solution to this would be to let the user configure this margin manually from the skin settings; just leave the 160 pixels by default, we would be able to reduce it when needed.

Edited by: PhilippeCharles on 13 Nov 2022, 09:41
PhilippeCharles

Posts: 131
Registered: 8-Dec-2012
Re: Projector - Bug report - Regression for comment display
Posted: 26 Dec 22, 15:32   in response to: PhilippeCharles in response to: PhilippeCharles
 
  Click to reply to this thread Reply
Hello Laza,

I changed smartphone since my last post above and even with a FullHD+ screen, the problem is still present (tested on a Pixel 6a).

As you can see in the 2 new attached screenshots, the side margins you have changed in version 2.3.0 does not seem to be set in pixels, but somehow related to the screen size.

This side margin is way too large and makes the reading of the comment quite awkward. This was quite OK before: why did you change that?

I suggest you the following:
1) Set by default the size of comment box (i.e. the box with dark background in my case, including image numbers and comment) to the maximum width of a picture, given the screen orientation. See red annotation in screen shot #4.
2) Optionally, define a new user-defined parameter that can only increase the margin (and thus reduce the width of the comment box).

I regenerated all my albums with the version 2.3.0 to fix other issues, but I saw this regression only later: so now I have to redo it once again, once you will have fixed this ;-).

Thank you for your support.
Laza

Posts: 1,869
Registered: 6-Sep-2005
Re: Projector - Bug report - Regression for comment display
Posted: 26 Dec 22, 16:51   in response to: PhilippeCharles in response to: PhilippeCharles
 
  Click to reply to this thread Reply
No margins are used, it's a side-effect of using the left: 50% for centering the caption. It seems I haven't tested long comments on small screens. When the left position is set as 50%, even though it's moved halfway left, the width still remains max. 50% of the picture size. That's how absolutely positioned elements work. I will have to find out a better way.
Laza

Posts: 1,869
Registered: 6-Sep-2005
Re: Projector - Bug report - Regression for comment display
Posted: 26 Dec 22, 17:05   in response to: PhilippeCharles in response to: PhilippeCharles
 
  Click to reply to this thread Reply
Attachment Projector.jaskin (3.3 MB)
Can you please test this version?
PhilippeCharles

Posts: 131
Registered: 8-Dec-2012
Re: Projector - Bug report - Regression for comment display
Posted: 31 Dec 22, 23:29   in response to: Laza in response to: Laza
 
  Click to reply to this thread Reply
Hello Laza,

Thank you for your reactivity, this is indeed much better now, as it looks like you are now giving to the comment up to 100% of the max image width.

So this is solving my problem :-) !

I wish you and the jAlbum team a happy new year 2023.
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums