Thread Locked This thread is locked - replies are not allowed.



Permlink Replies: 150 - Pages: 11 [ Previous | 1 ... 5 6 7 8 9 10 11 | Next ] - Last Post: 27 Sep 22, 21:55 Last Post By: davidekholm Threads: [ Previous | Next ]
AndreWolff

Posts: 1,158
Registered: 14-Dec-2007
Re: jAlbum on Java 18
Posted: 22 Sep 22, 15:56   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
I'd recommend that, but check out whether the fix I made is enough.

I don’t get it: a fix for what?
AndreWolff

Posts: 1,158
Registered: 14-Dec-2007
Re: jAlbum on Java 18
Posted: 22 Sep 22, 16:13   in response to: JeffTucker in response to: JeffTucker
JeffTucker wrote:
Or here's a radical idea: a separate app, called jAlbumBS (I like it! ).
I vote for that, I am not sure whether I have the energy to dive into the Groovy world, unless it is a very simple conversion process
It would really just be a clone of jAlbum 28, riding on Java 14.
Why can’t we save the current Java 18 beta as jAlbumBS I see no problems with my BeanShell skins.
JeffTucker

Posts: 8,357
Registered: 31-Jan-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 16:19   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
I took a deep plunge in the BeanShell internals and made a quick hack.

That does cure the Java 18 loading problem for the four "problem" skins. No telling what other effects it might have - I'm not even sure what kinds of tests might reveal some lurking danger.
davidekholm

Posts: 3,533
Registered: 18-Oct-2002
Re: jAlbum on Java 18
Posted: 22 Sep 22, 16:40   in response to: JeffTucker in response to: JeffTucker
JeffTucker wrote:
davidekholm wrote:
I took a deep plunge in the BeanShell internals and made a quick hack.

That does cure the Java 18 loading problem for the four "problem" skins. No telling what other effects it might have - I'm not even sure what kinds of tests might reveal some lurking danger.


The error that could potentially happen is that the wrong method is being called, but I can't foresee how that would happen in reality.
JeffTucker

Posts: 8,357
Registered: 31-Jan-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 16:46   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
The error that could potentially happen is that the wrong method is being called, but I can't foresee how that would happen in reality.

I'd vote to stick it in the final jAlbum 29 release and see what happens. Easy enough to back it out quickly if there are smoke and flames.

So, in the pompous jargon of the OpenJDK folks, are we now in Rampdown Phase II on jAlbum 29? Just curious, since I'm in the midst of converting my skins to Groovy. But I'm also a week away from heading off for my usual sojourn at the Delaware shore, where I'm not out of touch, but not in a place to be doing development. Hoping to run into Joe and Jill (whenever there's a picture of Biden on the beach or on his bike, I can usually ID the precise location of the photo, ± 25 meters).
RobM

Posts: 3,918
Registered: 4-Aug-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 19:23   in response to: JeffTucker in response to: JeffTucker
Unless there is a way of compiling a Groovy UI for an external tool then the complete lack of BeanShell means a problem for some of my external tools. Loading, for example reading mp3 tags, could take a very long time to load.

Maybe the question that needs to be asked is what external tools do users still want.
MarkusD

Posts: 667
Registered: 13-Apr-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 19:29   in response to: RobM in response to: RobM
RobM wrote:
Maybe the question that needs to be asked is what external tools do users still want.
Very good question. :-)

What I use constantly is:
textsToComments.bsh
Look up keywords.groovy

What I tried today is "Reset file date to camera date.groovy", which ended in an error:
 Exception in thread "ScriptingThread" java.lang.ExceptionInInitializerError
	at org.codehaus.groovy.runtime.InvokerHelper.<clinit>(InvokerHelper.java:88)
	at groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:46)
	at groovy.lang.GroovyObjectSupport.<init>(GroovyObjectSupport.java:32)
	at groovy.lang.Binding.<init>(Binding.java:36)
	at org.codehaus.groovy.jsr223.GroovyScriptEngineImpl$2.<init>(GroovyScriptEngineImpl.java:222)
	at org.codehaus.groovy.jsr223.GroovyScriptEngineImpl.eval(GroovyScriptEngineImpl.java:222)
	at org.codehaus.groovy.jsr223.GroovyCompiledScript.eval(GroovyCompiledScript.java:71)
	at java.scripting/javax.script.CompiledScript.eval(Unknown Source)
	at se.datadosen.jalbum.AlbumBean.processExpression(AlbumBean.java:3019)
	at se.datadosen.jalbum.AlbumBean.processScript(AlbumBean.java:2941)
	at se.datadosen.jalbum.JExternalToolsMenu$ToolAction$1.run(JExternalToolsMenu.java:90)
Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. Module [groovy-jsr223 is loaded in version 3.0.9 and you are trying to load version 4.0.4
	at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:510)
	at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
	at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
	at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
	at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:54)
	at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.<init>(MetaClassRegistryImpl.java:125)
	at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.<init>(MetaClassRegistryImpl.java:86)
	at groovy.lang.GroovySystem.<clinit>(GroovySystem.java:37)
	... 11 more
RobM

Posts: 3,918
Registered: 4-Aug-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 20:18   in response to: MarkusD in response to: MarkusD
MarkusD wrote:
What I tried today is "Reset file date to camera date.groovy", which ended in an error:
 Exception in thread "ScriptingThread" java.lang.ExceptionInInitializerError
	at org.codehaus.groovy.runtime.InvokerHelper.<clinit>(InvokerHelper.java:88)
	at groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:46)
	at groovy.lang.GroovyObjectSupport.<init>(GroovyObjectSupport.java:32)
	at groovy.lang.Binding.<init>(Binding.java:36)
	at org.codehaus.groovy.jsr223.GroovyScriptEngineImpl$2.<init>(GroovyScriptEngineImpl.java:222)
	at org.codehaus.groovy.jsr223.GroovyScriptEngineImpl.eval(GroovyScriptEngineImpl.java:222)
	at org.codehaus.groovy.jsr223.GroovyCompiledScript.eval(GroovyCompiledScript.java:71)
	at java.scripting/javax.script.CompiledScript.eval(Unknown Source)
	at se.datadosen.jalbum.AlbumBean.processExpression(AlbumBean.java:3019)
	at se.datadosen.jalbum.AlbumBean.processScript(AlbumBean.java:2941)
	at se.datadosen.jalbum.JExternalToolsMenu$ToolAction$1.run(JExternalToolsMenu.java:90)
Caused by: groovy.lang.GroovyRuntimeException: Conflicting module versions. Module [groovy-jsr223 is loaded in version 3.0.9 and you are trying to load version 4.0.4
	at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl$DefaultModuleListener.onModule(MetaClassRegistryImpl.java:510)
	at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromProperties(ExtensionModuleScanner.java:87)
	at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanExtensionModuleFromMetaInf(ExtensionModuleScanner.java:81)
	at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModulesFrom(ExtensionModuleScanner.java:63)
	at org.codehaus.groovy.runtime.m12n.ExtensionModuleScanner.scanClasspathModules(ExtensionModuleScanner.java:54)
	at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.<init>(MetaClassRegistryImpl.java:125)
	at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.<init>(MetaClassRegistryImpl.java:86)
	at groovy.lang.GroovySystem.<clinit>(GroovySystem.java:37)
	... 11 more
Mac OS jAlbum 29b14 run 'Reset file date to camera date.groovy' with no error.
MarkusD

Posts: 667
Registered: 13-Apr-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 20:26   in response to: RobM in response to: RobM
RobM wrote:
Mac OS jAlbum 29b14 run 'Reset file date to camera date.groovy' with no error.
I'm on Windows 10 with jAlbum 28.1.5. Do you think that the upcoming version 29 will fix this issue?
JeffTucker

Posts: 8,357
Registered: 31-Jan-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 20:27   in response to: RobM in response to: RobM
RobM wrote:
Mac OS jAlbum 29b14 run 'Reset file date to camera date.groovy' with no error.

No problem in Windows with jAlbum 29b15, either.

I haven't done any tools development, but is a Groovy-based UI really that bad? And if so, perhaps David can point the way towards compiling them?
RobM

Posts: 3,918
Registered: 4-Aug-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 20:33   in response to: MarkusD in response to: MarkusD
MarkusD wrote:
RobM wrote:
Maybe the question that needs to be asked is what external tools do users still want.
Very good question. :-)

What I use constantly is:
textsToComments.bsh

A button, a File chooser, two sets of three radio buttons and the OK/Cancel button. That might be a bit slow in loading, but probably acceptable - especially if there is no alternative (other than letting users hard code their choice of settings). On my watch list for Groovyfication.
MarkusD

Posts: 667
Registered: 13-Apr-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 20:34   in response to: JeffTucker in response to: JeffTucker
JeffTucker wrote:
RobM wrote:
Mac OS jAlbum 29b14 run 'Reset file date to camera date.groovy' with no error.

I haven't done any tools development, but is a Groovy-based UI really that bad?

My impression is, that the GUI of all tools is not that important, some of them don't have any. You see some radiobuttons, checkboxes, entry fields, buttons, that's all, no fancy things.
MarkusD

Posts: 667
Registered: 13-Apr-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 20:37   in response to: RobM in response to: RobM
RobM wrote:
MarkusD wrote:
RobM wrote:
Maybe the question that needs to be asked is what external tools do users still want.
Very good question. :-)

What I use constantly is:
textsToComments.bsh

A button, a File chooser, two sets of three radio buttons and the OK/Cancel button. That might be a bit slow in loading, but probably acceptable...
I agree with that. Showing that dialog lasts maybe 1 second, totally OK for me.
JeffTucker

Posts: 8,357
Registered: 31-Jan-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 20:40   in response to: RobM in response to: RobM
RobM wrote:
...Groovyfication.

We need to have a chat about spelling. My spell checker is of no assistance in this matter. Groovyfy or Groovify? I've been using the latter. But maybe just use Groovy as a verb: "I will Groovy this code. Now, it's been Groovied."

ETA: Or is it, "Now, it's been Groovyed?" I'm so confused....
RobM

Posts: 3,918
Registered: 4-Aug-2006
Re: jAlbum on Java 18
Posted: 22 Sep 22, 21:09   in response to: JeffTucker in response to: JeffTucker
JeffTucker wrote:
RobM wrote:
...Groovyfication.

We need to have a chat about spelling. My spell checker is of no assistance in this matter. Groovyfy or Groovify? I've been using the latter. But maybe just use Groovy as a verb: "I will Groovy this code. Now, it's been Groovied."

ETA: Or is it, "Now, it's been Groovyed?" I'm so confused....

You are using English, as a native I'm allowed to abuse it. Let's call the whole thing off ;)
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums