Thread Locked This thread is locked - replies are not allowed.


This question is answered. Helpful answers available: 2. Correct answers available: 1.


Permlink Replies: 3 - Pages: 1 - Last Post: 28 Apr 22, 16:34 Last Post By: davidekholm
JeffTucker

Posts: 8,292
Registered: 31-Jan-2006
Folder thumb naming problem
Posted: 26 Apr 22, 22:12
 
If folder names contain multiple dots, the jAlbum core fails to name the folder thumbnails properly, and the album can end up using the same thumbnail for multiple folders.

For example, if folders are named F1.1.1 and F1.1.2, the folder thumbnail for both is thumbs/F1.1.jpg

Here's a zipped-up project that illustrates the problem:

(demo zip removed)

Edited by: JeffTucker on 28 Apr 2022, 10:34
davidekholm

Posts: 3,935
Registered: 18-Oct-2002
Re: Folder thumb naming problem
Posted: 28 Apr 22, 15:53   in response to: JeffTucker in response to: JeffTucker
 
Ouch, that's a nasty one. The root of the problem is that jAlbum's logic that figures out the base name of a file isn't handling directories, so the last dot is always removed. For directories, no dot should be considered an "extension introducer". I therefore needed to rewrite deep parts of jAlbum to pass on File references instead of just strings so the logic can treat directories differently. Seems to work now, but I BET I've introduced some other bugs, so please test.

The new beta is b7, available as a core update
JeffTucker

Posts: 8,292
Registered: 31-Jan-2006
Re: Folder thumb naming problem
Posted: 28 Apr 22, 16:05   in response to: davidekholm in response to: davidekholm
 
Ah, yes, I can "feel" the underlying problem there.

This seems to take care of the immediate problem. I'll keep an eye out for side effects.
davidekholm

Posts: 3,935
Registered: 18-Oct-2002
Re: Folder thumb naming problem
Posted: 28 Apr 22, 16:32   in response to: JeffTucker in response to: JeffTucker
 
Thanks Jeff
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums