Permlink Replies: 74 - Pages: 5 [ 1 2 3 4 5 | Next ] - Last Post: 20-Jul-2020 00:30 Last Post By: RobM Threads: [ Previous | Next ]
davidekholm

Posts: 3,136
Registered: 18-Oct-2002
jAlbum 21 beta for testing
Posted: 14-Jul-2020 14:27
  Click to reply to this thread Reply
Working on 21 here (yes, v20.3 became 21). This version has three new improvements:

  • Embedded WYSIWYG HTML editor. Right-click a comment or description and select "Open HTML Editor" and take it from there. (This editor can be configured under system/editor.html for the javascript daring developers among you).
  • New shared system/base.css file that gets added on top of common.css for each skin, providing styles the new html editor uses.
  • Supports 4 new look and feels thanks to the open source FlatLaf project . These will replace Darcula, which is abandonware and not really compatible with future Java versions (notice the errors when running jAlbum from the command line). FlatLaf has theme support, and one theme mimics Darcula so well that I don't think moving from Darcula to Flat will upset anyone :-)
  • Supports Oracle's new GraalJS JavaScript engine, which will replace the Nashorn JavaScript engine skins like Tiger and PhotoBlogger currently run on. (Nashorn is no longer present in the next Java version to come)
  • Various bug fixes (for instance editing folder titles and descriptions and losing changes if directly thereafter navigating to other folders using the folder tree)

I'll post more on the GraalJS engine support later one. Will now focus on the new Flat look&feel:

Here's a demo album showcasing jAlbum running on the 5 themes of Flat look & feel that we currently support:


This look&feel is both open source, actively supported and used by the just released Netbeans 12, so one can assume it has been battle-tested well. If you find any issues with it, report here or directly to the Flat look & feel project .

If you like to customize it, open system/themes and edit your own theme file, then restart jAlbum to have your new theme appear in the list of available look&feels.

Installers:
Windows: http://jalbum.net/download/jAlbum-install.exe
Mac: http://jalbum.net/download/jAlbum.dmg
Any system: http://jalbum.net/download/jAlbum.zip
jGromit

Posts: 6,751
Registered: 31-Jan-2006
Re: jAlbum 21 beta for testing
Posted: 14-Jul-2020 14:39   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
What happened to Minimal 7.1.5?

(And while you're at it, update the skin page for it: https://jalbum.net/skins/skin/Minimal/)
jGromit

Posts: 6,751
Registered: 31-Jan-2006
Re: jAlbum 21 beta for testing
Posted: 14-Jul-2020 14:52   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
The HTML editor inserts some unwanted <p> tags, which leads to edited comments, for example, taking more display space on the slide page than unedited comments.

A quick example: create a Minimal album with a couple of images. Enter a one-word comment for both images. On one of the images, invoke the HTML editor - no need to make any actual edits. Now make the album and look at the slide pages. The gap between image and caption isn't the same on both slides.

Similar unwanted effects in other skins and in other locations (like thumbnail captions).
RobM

Posts: 3,094
Registered: 4-Aug-2006
Re: jAlbum 21 beta for testing
Posted: 14-Jul-2020 14:53   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
davidekholm wrote:
Working on 21 here (yes, v20.3 became 21). This version has three new improvements:
If you like to customize it, open system/themes and edit your own theme file, then restart jAlbum to have your new theme appear in the list of available look&feels.
Just a reminder that custom skins can be added easily by adding a theme’s Json file to a ‘themes’ folder in the config folder. Example Json file
jGromit

Posts: 6,751
Registered: 31-Jan-2006
Re: jAlbum 21 beta for testing
Posted: 14-Jul-2020 15:12   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
davidekholm wrote:
Working on 21 here (yes, v20.3 became 21).

My nefarious scheme for World Domination is making headway.
RobM

Posts: 3,094
Registered: 4-Aug-2006
Re: jAlbum 21 beta for testing
Posted: 15-Jul-2020 00:26   in response to: jGromit in response to: jGromit
  Click to reply to this thread Reply
The wysiwyg editor isn't!
Set text to bold (strong) and it looks like plain text.
Set text to italic and it looks plain too.

Come out of the HTML editor and then you can see the texts as they should be.

The editor really needs tooltips for the icons
jGromit

Posts: 6,751
Registered: 31-Jan-2006
Re: jAlbum 21 beta for testing
Posted: 15-Jul-2020 00:31   in response to: RobM in response to: RobM
  Click to reply to this thread Reply
Attachment ss007629.png (5.1 KB)
Attachment ss007630.png (108.7 KB)
RobM wrote:
The wysiwyg editor isn't!

Hmmmm... I'm getting the promised WYSIWYG - see screenshots.

ETA: Ah, but only in Windows! Now there's a switch. In macOS 10.15.5, no WYSIWYG.
RobM

Posts: 3,094
Registered: 4-Aug-2006
Re: jAlbum 21 beta for testing
Posted: 15-Jul-2020 08:39   in response to: jGromit in response to: jGromit
  Click to reply to this thread Reply
jGromit wrote:
RobM wrote:
The wysiwyg editor isn't!

Hmmmm... I'm getting the promised WYSIWYG - see screenshots.

ETA: Ah, but only in Windows! Now there's a switch. In macOS 10.15.5, no WYSIWYG.

Yes, really odd. I even tried different looks in case it was related to 'jAlbum's skin'.
davidekholm

Posts: 3,136
Registered: 18-Oct-2002
Re: jAlbum 21 beta for testing
Posted: 15-Jul-2020 10:07   in response to: jGromit in response to: jGromit
  Click to reply to this thread Reply
jGromit wrote:
What happened to Minimal 7.1.5?

(And while you're at it, update the skin page for it: https://jalbum.net/skins/skin/Minimal/)


Oops. Will include
davidekholm

Posts: 3,136
Registered: 18-Oct-2002
Re: jAlbum 21 beta for testing
Posted: 15-Jul-2020 10:09   in response to: RobM in response to: RobM
  Click to reply to this thread Reply
RobM wrote:
The wysiwyg editor isn't!
Set text to bold (strong) and it looks like plain text.
Set text to italic and it looks plain too.

Come out of the HTML editor and then you can see the texts as they should be.

The editor really needs tooltips for the icons


That's a Mac issue that's still unresolved.
davidekholm

Posts: 3,136
Registered: 18-Oct-2002
Re: jAlbum 21 beta for testing
Posted: 15-Jul-2020 10:11   in response to: RobM in response to: RobM
  Click to reply to this thread Reply
Yes, the Mac version has a problem with showing bold and italic. All source code is under system/editor.html in case you can figure out the cause. Perhaps we need to change default font?
RobM

Posts: 3,094
Registered: 4-Aug-2006
Re: jAlbum 21 beta for testing
Posted: 15-Jul-2020 12:08   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
Attachment editor.html (1.2 KB)
Not sure of the exact cause, but…If you open the editor.html file in a browser, it works.

If you use Quill's quick start code, instead of that in the editor.html it crashes, errors are that the functions makeDark, ReadDOM and replaceDOM are missing. They must be hard coded as they are not called by the editor.html. Opening that version of the editor.html file works correctly in a browser. Attached is the editor.html file using Quill's quick start.

So, the problem is in the javascript implementation of the editor. A clue might be that if there is no text in the comment field, when entering the editor you do not see
'Plain text
Hello World!
Some initial text'
jGromit

Posts: 6,751
Registered: 31-Jan-2006
Re: jAlbum 21 beta for testing
Posted: 15-Jul-2020 13:13   in response to: jGromit in response to: jGromit
  Click to reply to this thread Reply
jGromit wrote:
The HTML editor inserts some unwanted <p> tags....

It's even worse than I thought. Say a user enters this as his comment, in the regular jAlbum edit mode:
This is line 1.
This is line 2.
This is line 3.
In my skins, the image comment, whether for a thumbnail or slide image, will appear exactly as he's entered it - three lines of text. Why? Because the skin replaces the newlines with HTML breaks, since HTML ignores newlines. In Tiger, however, the comment appears as a single line - the skin doesn't make the substitution (I regard that as a bug).

Now the user enters that comment in the new HTML editor. The editor "helpfully" puts paragraph tags around each line. In my skins, the comment now appears on six lines - they're double-spaced, because that's what HTML does with paragraph tags. In Tiger, it's even more fun. As a thumbnail caption, it appears as a single line. As a slide caption, it appears on six lines. (A side note: in Tiger, I can't figure out how to force the comment to appear on three lines when used as a thumbnail caption. To me, that's also a bug.)

And it's a trap door - the skin can't tell who has inserted the extra HTML tags, the user or the editor. And the only way to back out the extra tags is to edit the comment manually, in the regular jAlbum edit mode, and laboriously delete each unwanted tag.

Summary: this new editor makes a bad situation even worse.

ETA: In Tiger, you can cure the problem by telling the skin to "preformat" the text. But after all these years, I still don't know what "preformat" means. There's HTML, and there's not HTML. This option seems to be converting some HTML to some other HTML.
jGromit

Posts: 6,751
Registered: 31-Jan-2006
Re: jAlbum 21 beta for testing
Posted: 15-Jul-2020 13:21   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
davidekholm wrote:
jGromit wrote:
What happened to Minimal 7.1.5?

(And while you're at it, update the skin page for it: https://jalbum.net/skins/skin/Minimal/)

Oops. Will include


If you would just update the skin page, this would pretty much take care of itself.
jGromit

Posts: 6,751
Registered: 31-Jan-2006
Re: jAlbum 21 beta for testing
Posted: 15-Jul-2020 13:46   in response to: jGromit in response to: jGromit
  Click to reply to this thread Reply
jGromit wrote:
It's even worse than I thought.

And now it's been released. Wonderful. I'm not going to do any more beta testing if the results of that testing are going to be ignored.

Note to all users of my skins: DO NOT USE THE NEW HTML EDITOR. It will make a mess of your projects, and you'll have to spend a lot of time manually fixing things.
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums