This question is answered.


Permlink Replies: 250 - Pages: 17 [ Previous | 1 ... 11 12 13 14 15 16 17 | Next ] - Last Post: 20 Jul 21, 17:45 Last Post By: davidekholm Threads: [ Previous | Next ]
RobM

Posts: 3,748
Registered: 4-Aug-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 17 Jul 21, 22:12   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
xexyl wrote:
Ah, so it's only macOS? Good. Then I can commit on my local git repo that fix.

In what way did you have to refactor your skins?

Maybe that is the wrong term. I had to re-add the libraries, see attached. The last one is only needed if you want to support the HTML editor.

Edited by: RobM on 17 Jul 2021, 21:19
Oops! attached now
RobM

Posts: 3,748
Registered: 4-Aug-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 17 Jul 21, 22:15   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
JeffTucker wrote:
RobM wrote:
The path to the core file will have changed if you use Mac OS and are now running Big Sur

I never saw NetBeans complain on the Mac (I'm usually on Windows), and couldn't figure out why, until I remembered what I had done. I routinely copy the latest jalbum-core.jar from the package to the NetBeans directory itself, and just use that as the library. I did that originally because NetBeans wouldn't let me navigate into the package contents to grab the library. Haven't tried it lately....

I opened the app package in Finder and made an alias to the lib folder. Then put that alias in a folder with older, or new beta, versions of jAlbum. That way I could always get to the files.
ETA: The NetBeans people finally fixed that. :)
Must have a try, never thought about it being fixed.
JeffTucker

Posts: 8,122
Registered: 31-Jan-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 17 Jul 21, 22:17   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
Must have a try, never thought about it being fixed.

Not sure when it happened, but in NB 12.4, you can happily navigate into the app's package contents.
xexyl

Posts: 157
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 17 Jul 21, 22:27   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
xexyl wrote:
Ah, so it's only macOS? Good. Then I can commit on my local git repo that fix.

In what way did you have to refactor your skins?

Maybe that is the wrong term. I had to re-add the libraries, see attached. The last one is only needed if you want to support the HTML editor.

Edited by: RobM on 17 Jul 2021, 21:19
Oops! attached now


Maybe it is the wrong term. It took me a second to fix the build path so I'm not bothered. But I have both good news and bad news which I'll make a comment by itself.
xexyl

Posts: 157
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 17 Jul 21, 22:32   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
Good news: an older version works.

Bad news: the current version does not.

Worse news: I don't know why.

Slightly bad news: I need to figure out what versions will work.

I also have to test if it's only macOS or also Linux (I don't have a Windows box so I can't test it).

Worse of all: I have so much going on that I don't even know that I have the energy to do these tasks (I guess other people might say: 'don't we all and especially in the past year and a half?' but it's not the same thing though that's not to say that their issues are any less significant). I guess I'll make a note on the skin page though that at the least macOS is affected. But of course that also makes the skin next to useless on the more recent versions of jAlbum. However at least I can do what I wanted to do!

David... Any comments on what might be going on? I'm utterly baffled why this would happen. Amusingly (since I know the recent version of jAlbum has this capability) included in filters not working right is a mirror filter that I wrote back in 2009 or 2010 (though much improved since then and more feature than just mirror an image)... It's not the only filter but that's one of the filters.
RobM

Posts: 3,748
Registered: 4-Aug-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 17 Jul 21, 22:40   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
xexyl wrote:
Good news: an older version works.

Bad news: the current version does not.

Worse news: I don't know why.

Slightly bad news: I need to figure out what versions will work.

I also have to test if it's only macOS or also Linux (I don't have a Windows box so I can't test it).

Is there a simple error message in the System console or loads of stuff? If simple what is the error code? Maybe also upload the skin so others can have a look (I'm going off-line for now, I have some serious goggle box viewing to catch up on ;) )
xexyl

Posts: 157
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 17 Jul 21, 22:51   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
xexyl wrote:
Good news: an older version works.

Bad news: the current version does not.

Worse news: I don't know why.

Slightly bad news: I need to figure out what versions will work.

I also have to test if it's only macOS or also Linux (I don't have a Windows box so I can't test it).

Is there a simple error message in the System console or loads of stuff? If simple what is the error code? Maybe also upload the skin so others can have a look (I'm going off-line for now, I have some serious goggle box viewing to catch up on ;) )

Hope you had a good time.

Hmm I didn't think of errors actually and right now I have the old version installed so that I can make use of the filters. I'm really happy with the result! Having more fun with my fractals. As for uploading it's the most recent on my page. Or you mean the source code? I do have the source code for the skin but not the filters; they're kind of a mess and I don't think anyone would want to go through them anyway. I'll wait and see what David has to say first (David or Dave, I don't remember what he prefers to go by - my best mate is called Dave, my dad is David...).

Thank you for the tips etc. If David doesn't reply in a few days and I remember (ha!) I'll see about moving forward in the problem.

Cheers mate.

JeffTucker

Posts: 8,122
Registered: 31-Jan-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 17 Jul 21, 23:33   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
Doesn't seem to be working on Windows, either. Not really a surprise, since Java is Java, no matter where you're running it. In any event, no signs of trouble in the system console:
Skin loading: 0.087s
 
** Dumping filter settings **
Reflect images down
Reflection ratio is 100.00%
Paint reflections
Gradient paint direction is down
Gradient paint is acyclic
Gradient paint ratio is 100.00%
Gradient paint opacity is 30.00%
First gradient paint colour is #000000
Second gradient paint colour is #111111
Don't paint before reflecting
Don't apply specular highlights
Don't make images translucent
 
** End dump **
Make all
C:\Users\jefft\xampp\htdocs\abc
Make album: 0.694s
The slide images appear to have a very dark gray border at the bottom, about 50px deep, instead of the reflection.

Sorry, but filters aren't my thing, so I can't offer any words of wisdom in this case.
xexyl

Posts: 157
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 00:03   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
JeffTucker wrote:
Doesn't seem to be working on Windows, either. Not really a surprise, since Java is Java, no matter where you're running it. In any event, no signs of trouble in the system console:
Skin loading: 0.087s
 
** Dumping filter settings **
Reflect images down
Reflection ratio is 100.00%
Paint reflections
Gradient paint direction is down
Gradient paint is acyclic
Gradient paint ratio is 100.00%
Gradient paint opacity is 30.00%
First gradient paint colour is #000000
Second gradient paint colour is #111111
Don't paint before reflecting
Don't apply specular highlights
Don't make images translucent
 
** End dump **
Make all
C:\Users\jefft\xampp\htdocs\abc
Make album: 0.694s
The slide images appear to have a very dark gray border at the bottom, about 50px deep, instead of the reflection.

Sorry, but filters aren't my thing, so I can't offer any words of wisdom in this case.


Thank you for testing mate! Yeah it might be the filter settings. But I also know that if you use jAlbum's internal previewer it shows some dark grey at the bottom of the image (I think bottom) and that might be what you're seeing?

This is really baffling me... But I'll worry about it another time or day as i'm going for the night.

Cheers and thank you for testing! Much appreciated.

Edit: Oh and true, Java is Java. I was thinking maybe a jAlbum change that only was on macOS like the jar file path changing under macOS Big Sur. But now I know that it's also under Windows too and I seriously doubt it's unaffected under Linux.

Edited by: xexyl on 17 Jul 2021, 15:07
JeffTucker

Posts: 8,122
Registered: 31-Jan-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 00:09   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
xexyl wrote:
Thank you for testing mate! Yeah it might be the filter settings. But I also know that if you use jAlbum's internal previewer it shows some dark grey at the bottom of the image (I think bottom) and that might be what you're seeing?

No, I'm talking about going to the output directory and opening the slide image in the OS's default image viewer. At that point, jAlbum isn't involved at all. The reflection simply isn't baked into the slide image, as it should be.
RobM

Posts: 3,748
Registered: 4-Aug-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 00:11   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
jAlbum 23.1 release note:
Faster filter processing due to better use of multiple threads. Image filters are now required to be thread safe (i.e. not contain state that changes during execution of the filter() method). (Filters that aren't thread safe should have their filter() method marked with the java "synchronized" keyword.)
xexyl

Posts: 157
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 00:11   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
Please attach an image so I can explain what you're seeing as i'm sure it is working okay. Maybe I should have the gradient paint disabled by default; I don't know. But it was originally there for a reason but I can see how it might not be desired by everyone. It was a niche skin and filter set to be sure!

I'll react tomorrow but if you attach an image I can explain what you're seeing.
xexyl

Posts: 157
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 00:12   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
jAlbum 23.1 release note:
Faster filter processing due to better use of multiple threads. Image filters are now required to be thread safe (i.e. not contain state that changes during execution of the filter() method). (Filters that aren't thread safe should have their filter() method marked with the java "synchronized" keyword.)

Already fixed that so I can't imagine it's that.

Edit: Meaning I did mark filter() synchronized.

Edited by: xexyl on 17 Jul 2021, 15:12
JeffTucker

Posts: 8,122
Registered: 31-Jan-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 00:26   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
Attachment a06.jpg (181.5 KB)
xexyl wrote:
I'll react tomorrow but if you attach an image I can explain what you're seeing.

This is with the skin's default settings. Take a look at the bottom edge - there is a reflection there, but it's only the bottom 10% of the image.

(Unrelated, but the skin forces the linking to change to Link to originals via scaled images. This just makes the output huge, and it all gets uploaded. Or is there some other reason for doing this?)
ctwist

Posts: 476
Registered: 27-Sep-2003
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 00:45   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
This thread has some useful information about this problem https://jalbum.net/forum/thread.jspa?threadID=57082. In my skin, I was unable to fix the problem; I hope you are more fortunate.
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums