This question is answered.


Permlink Replies: 250 - Pages: 17 [ Previous | 1 ... 8 9 10 11 12 13 14 | Next ] - Last Post: 20 Jul 21, 17:45 Last Post By: davidekholm Threads: [ Previous | Next ]
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 7 Jul 20, 22:43   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
In the wiki, there is https://jalbum.net/help/en/Plugin_development
With a link to image filters plugins that go into 'Edit' mode. https://code.google.com/p/jalbum-imagefilters/

IS that of any use?


Ahh it's under plugins. Okay. You know it might be of use. I have actually seen that before but I forgot about it. I'll take a look when I get a chance. Thanks mate!
ctwist

Posts: 665
Registered: 27-Sep-2003
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 8 Jul 20, 02:08   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
Your hints.jap sets rows to 99999

You can force the same behaviour by setting rows to 0 (just in case somebody generates an album with 100000+ rows).

No I don't spend all of my spare time re-reading this thread. I am just taking a short break from the 34°C temperature here in the Great White North.
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 8 Jul 20, 22:43   in response to: ctwist in response to: ctwist
 
  Click to reply to this thread Reply
ctwist wrote:
Your hints.jap sets rows to 99999

You can force the same behaviour by setting rows to 0 (just in case somebody generates an album with 100000+ rows).


Ta. I did see that but that was from old. I've updated it and it'll go with the next commit on my git repo.


No I don't spend all of my spare time re-reading this thread. I am just taking a short break from the 34°C temperature here in the Great White North.

Nasty. The record here is 47 but fortunately this year we've only so far that I'm aware of have had maybe 35. It's going to get worse. It always does. Last year this time we already saw the 40s. We regularly get mid to high 40s. Hell, we've had 35+ in the winter months! Thankfully I have air conditioning....

Stay cool and thanks for the tip!
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 9 Jul 20, 18:40   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
In the wiki, there is https://jalbum.net/help/en/Plugin_development
With a link to image filters plugins that go into 'Edit' mode. https://code.google.com/p/jalbum-imagefilters/

IS that of any use?


Btw checking the link in the Downloads tab (and also a couple others) I get:

There was an error getting resource 'downloads':
401: Anonymous caller does not have storage.objects.get access to the Google Cloud Storage object.

So I can't actually download it. Maybe it's the same that's bundled with jAlbum though? Anyway I really just have to look at the JAlbumContext class etc. (whatever else it takes) and work on implementing it - but I don't know when I'll get to this. But thought one of you ought to know that the download isn't working (though maybe I have to be logged in, I don't know).

Cheers.
RobM

Posts: 3,949
Registered: 4-Aug-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 9 Jul 20, 18:55   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
davidekholm

Posts: 3,827
Registered: 18-Oct-2002
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 9 Jul 20, 23:15   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
xexyl wrote:
Another question for you David.

I was thinking back on the thing you said about effects versus filters. It occurred to me that for at least one of my filters it would be rather useful to have a filter control panel UI where I could preview the changes (like you can with effects in the Effects tab).

I noticed AbstractFilter and looking at an old version of GrayscaleFilter.java I noticed it extends AbstractFilter and it has a UI instance as well as a private class that extends ControlPanel.

Looking at these very quickly in my tired eyes I guess that this is part of how it's done but there would also I guess have to be a way to install it into the jAlbum UI (I presume that just like a skin has to add itself to the UI so too do filters/effects?).

Is there more information on this? Looking at the extensions forums quickly I did not see many things on effects and given that the current version of GrayscaleFilter doesn't seem to use AbstractFilter I don't know.

Any feedback here would be good. Oh and if it's in the wiki I apologise for not seeing it. I do remember skins being there but don't recall effects. Thanks.


There is an API to extend the type of image filters we call "Image tools" under the Edit panel. These are also filters technically speaking. But, we currently don't have an open API to extend the "effects" (i.e. filters with user interfaces that by default apply to all images). It's on the long todo list to unify these filters under the same API as they technically speaking all do the same thing - manipulate images. I guess you're looking for an extension API so you can add your own effect, right? Or do you prefer to install your filter as an "Image tool" under Edit?
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 10 Jul 20, 17:57   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply

That works, thanks mate.
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 10 Jul 20, 18:04   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
davidekholm wrote:>
There is an API to extend the type of image filters we call "Image tools" under the Edit panel. These are also filters technically speaking. But, we currently don't have an open API to extend the "effects" (i.e. filters with user interfaces that by default apply to all images). It's on the long todo list to unify these filters under the same API as they technically speaking all do the same thing - manipulate images. I guess you're looking for an extension API so you can add your own effect, right? Or do you prefer to install your filter as an "Image tool" under Edit?

What I would like is to be able to change the settings and see a live preview like you can of the Arty, Greyscale, Text effects. The reason is that one of my filters has a lot of settings and it would be great to see it without having to force rebuild an album and then look at it. This would help not only in finding better settings but it would also make it easier in general.

So yes I would like to add my own effect indeed. If the other option has a preview that would be fine too but I don't think it does? Oh actually I see it does but does it have a way to set parameters? That's the key - I would like to install it into the UI and then be able to say: I want to run this filter on this image but be able to update the parameters. Is that possible?

Thanks for the reply and any help you can provide here! Same goes to the others of course.

Oh btw is there a way to make it so that the rebuild always runs filters - that is as if it does force rebuild? Since my skin basically has filters as part of it it would be better to have the filters always be run. Thanks.
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 13 Jul 20, 18:10   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
jGromit wrote:
The basic way to turn off widget support is to plant this in the skin.properties file:
autoWidgetInjection=false

Is there incidentally a way to disable it in new projects? What I mean to say is: I can set the default (in my profile) skin to be my skin but even new projects still have widget support enabled so every time I make a new album and build it I get the warning. I could disable it of cf course but it's a valid point you made.

I didn't see anything in the documentation though that doesn't necessarily mean I was looking in the right place or that I didn't miss it.

Thanks.
RobM

Posts: 3,949
Registered: 4-Aug-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 13 Jul 20, 19:59   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
Update your defaults, make sure Settings>Advanced>Metadata>Include JAlbum widget support is off, then do Menu>File>Save as default.
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 13 Jul 20, 20:14   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
Right. That makes sense. I've even done that before but prior to disabling widget support in the skin. I did try the autoWidgetInjection property manually but of course it's actually widgetInjection so it didn't work.

This past weekend I made a new filter and some significant skin updates for the filters too. Now it's a matter of making documentation and example albums the former of which I don't currently have the energy to do.

Anyway thanks for the help here too. Much appreciated.

Cheers.
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 30 Jul 20, 22:24   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
Attachment index.htt (7.2 KB)
I've made a lot of improvements and have added quite a few new features (skin and filters plus a new filter) but I have run into a snag that I want your thoughts on. Perhaps this goes esp to jGromit but anyone else is by all means welcome.

Old way: if the album has three directories and the first one has a subdirectory which has a subdirectory it would show something like:

Pet Photos | 1 folder

And then under that directory it would show also that there's a subdirectory. But then I thought: what if there are no images in the end? That's rather silly to show that there are directories if they're empty.

So the obvious solution was to recurse and if no images found don't include them like:

int numTotalImages = JAlbumUtilities.countCategories(ao,true).getCount(Category.image);
if (numTotalImages == 0) continue;


But since it's one directory at a time it might happen that the parent directory already found two directories and so it listed them even though one has no images.

I can think of some ways to resolve this but maybe there's a preferred method with jAlbum and that's what I'm after. To give you an idea this is from lines 77 through 140 in the attached index.htt.

Is there a preferred jAlbum method for this? Maybe there's even a reason to include empty directories? I don't know why there would be but it would also make it simpler. Then again it might even be that i'm not thinking of a much simpler solution and if I take a break and look at it again it'll be very obvious. I could believe that too.

Thanks.
RobM

Posts: 3,949
Registered: 4-Aug-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 30 Jul 20, 23:03   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
JeffTucker

Posts: 8,008
Registered: 31-Jan-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 30 Jul 20, 23:04   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
The user may be building a project with many branches, and wants to set up the structure before populating it with images. He'll just be puzzled about why he's not seeing the structure he's created.

Hiding empty directories falls into the category of doing the user a "favor" that he didn't ask for. If he wants to have empty directories ignored, the core already gives him a way to do that - he can hide or exclude them with a click.
RobM

Posts: 3,949
Registered: 4-Aug-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 30 Jul 20, 23:09   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
Another option is to let users add a standard ‘dummy’ image in empty folders. See this tool that does that
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums