This question is answered.


Permlink Replies: 250 - Pages: 17 [ Previous | 1 ... 6 7 8 9 10 11 12 | Next ] - Last Post: 20 Jul 21, 17:45 Last Post By: davidekholm Threads: [ Previous | Next ]
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 28 Jun 20, 17:22   in response to: ctwist in response to: ctwist
 
  Click to reply to this thread Reply
ctwist wrote:
xexyl wrote:
I made it HTML5 (I think)
Feed some album pages into Nu Html Checker. It will identify HTML5 violations.

Good point. After a few fixes here's what I get:

Warning: The type attribute is unnecessary for JavaScript resources.
From line 60, column 1; to line 60, column 31
r"></div>↩<script type="text/javascript"><!--//


However that is from the widget injection which I have no control over. Dave?

And then I also get this:

Warning: Consider adding a lang attribute to the html start tag to declare the language of this document.
From line 1, column 16; to line 2, column 6
TYPE html>↩<html>↩<head
For further guidance, consult Declaring the overall language of a page and Choosing language tags.
If the HTML checker has misidentified the language of this document, please file an issue report or send e-mail to report the problem.


I presume this is from a variable in jAlbum that I am unaware of. I will have a look at it later on unless you know it immediately?

Those were for indexes. For slides it's the same thing (after adding a missing quote in one of the elements).

So this means I have to check with jAlbum variables and then Dave needs to fix the widget injections. Or maybe that is something I have control over?

Ta.
JeffTucker

Posts: 8,158
Registered: 31-Jan-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 28 Jun 20, 17:35   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
Yeah, the widget code is a little creaky and could use some updating. That's actually Anders' territory, but he's got a lot on his plate. And it is just a warning, not an error.

The type attributes are a mixed bag in that I can understand why some validators might not flag them as errors, or even give a warning. For <style>, there is no type other than text/css. So that one is completely redundant - it would be like putting a type="image" on an <img> tag - duh. ;)

For the <script> tag, there are technically types other than text/javascript, but they're almost never used. HTML5 assumes that it's text/javascript unless you specify otherwise. So, not wrong, but not needed, either.
JeffTucker

Posts: 8,158
Registered: 31-Jan-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 28 Jun 20, 17:37   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
And BTW, "Dave" is an English nickname for "David," but our David is persistently, willfully, and stubbornly Swedish.
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 28 Jun 20, 18:24   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
jGromit wrote:
Yeah, the widget code is a little creaky and could use some updating. That's actually Anders' territory, but he's got a lot on his plate. And it is just a warning, not an error.

I know what that's like!


The type attributes are a mixed bag in that I can understand why some validators might not flag them as errors, or even give a warning. For <style>, there is no type other than text/css. So that one is completely redundant - it would be like putting a type="image" on an <img> tag - duh. ;)

Well what if there's a language where img means something different from image? :) But point taken. I've removed it from the templates.


For the <script> tag, there are technically types other than text/javascript, but they're almost never used. HTML5 assumes that it's text/javascript unless you specify otherwise. So, not wrong, but not needed, either.

Right which is why I figured I should include it - that there are other script types. However since the validator flagged it I already removed it.

Thanks for clarifying.
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 28 Jun 20, 18:28   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
jGromit wrote:
And BTW, "Dave" is an English nickname for "David," but our David is persistently, willfully, and stubbornly Swedish.

Yes. For some reason I thought I had read Dave. Or maybe it was because I am knackered.

It might also be because my best mate goes by 'Dave'. That's probably the real thing (well and I am knackered).

As for 'David' and other languages the only other spelling I'm familiar with is in Polish - Dawid. But I've no idea in Swedish though I have some good friends who would be able to tell me how that works as they're also Swedish. It appears to be 'David' though. Besides English and computer languages the only other language I know - and in this case only a bit (i.e. not fluently) - is German.

Thanks for correcting me.
RobM

Posts: 4,171
Registered: 4-Aug-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 28 Jun 20, 18:58   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
xexyl wrote:> TYPE html>↩<html>↩<head
For further guidance, consult Declaring the overall language of a page and Choosing language tags.
If the HTML checker has misidentified the language of this document, please file an issue report or send e-mail to report the problem.[/code]

I presume this is from a variable in jAlbum that I am unaware of. I will have a look at it later on unless you know it immediately?

The variable is language
So this means I have to check with jAlbum variables and then Dave needs to fix the widget injections. Or maybe that is something I have control over?
If you really want to have control of the widget code, add ‘autoWidgetInjection=false’ as a property to the skin.properties file. Then add your own widget code where jAlbum’s would have been.
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 28 Jun 20, 21:55   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
xexyl wrote:> TYPE html>↩<html>↩<head
For further guidance, consult Declaring the overall language of a page and Choosing language tags.
If the HTML checker has misidentified the language of this document, please file an issue report or send e-mail to report the problem.[/code]

I presume this is from a variable in jAlbum that I am unaware of. I will have a look at it later on unless you know it immediately?

The variable is language

Thanks mate. I actually checked and found it - all is good there.

So this means I have to check with jAlbum variables and then Dave needs to fix the widget injections. Or maybe that is something I have control over?
If you really want to have control of the widget code, add ‘autoWidgetInjection=false’ as a property to the skin.properties file. Then add your own widget code where jAlbum’s would have been.

Ahh right. I knew that that I had seen something like that. I'm not too worried about this though - if it gets fixed it gets fixed but it doesn't bother me for redundancy. (I thought of even removing widgets but something told me that's not a good idea.) Thanks though! Much appreciated.
JeffTucker

Posts: 8,158
Registered: 31-Jan-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 28 Jun 20, 23:28   in response to: xexyl in response to: xexyl
 
  Click to reply to this thread Reply
xexyl wrote:
I thought of even removing widgets but something told me that's not a good idea.

I don't support them in any of my skins. They just intrude on the viewport, and provide things that aren't needed - a visit counter (your visitors don't care how many other people have been there before them), an "about" popup (most skins provide their own style-matched mechanism for that), and commenting (once the spammers find your site, you might as well turn that one off).

Before adding any screen clutter to your albums, make sure there's a good reason for drawing attention away from the images.
davidekholm

Posts: 4,059
Registered: 18-Oct-2002
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 29 Jun 20, 11:57   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
I react to "Dave" too even if Swedes simply call me "David" :-). I've updated jAlbum's widget injection code to drop the type="text/javascript attribute. Any other things to adjust with the widget injection code?
AndreWolff

Posts: 2,344
Registered: 14-Dec-2007
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 29 Jun 20, 14:06   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
davidekholm wrote:
Any other things to adjust with the widget injection code?
If you open the injected code in VSCode, you see 2 errors. see enclosed screenshot.

Corrected code:
<div id="jalbumwidgetcontainer"></div>
<script>
_jaSkin = "FancyBox";
_jaStyle = "Gray-Textile.css";
_jaVersion = "20.2.7";
_jaGeneratorType = "desktop";
_jaLanguage = "en";
_jaPageType = "index";
_jaRootPath = ".";
_jaUserId = "107704";
var script = document.createElement("script");
script.type = "text/javascript";
script.src = "http"+("https:"==document.location.protocol?"s":"")+"://jalbum.net/widgetapi/load.js";
document.getElementById("jalbumwidgetcontainer").appendChild(script);
</script>


Edited by: AndreWolff on 29-Jun-2020 14:14
JeffTucker

Posts: 8,158
Registered: 31-Jan-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 29 Jun 20, 14:12   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
davidekholm wrote:
Any other things to adjust with the widget injection code?

That was the only remaining thing that either of my "go to" validators complained about (the W3 validator and Total Validator). I finally plunked down the money for a pro license for Total Validator. It will check an entire site in one shot, and even includes things like link checking and spell checking. A huge time-saver.

ETA: I suspect that the whole CDATA nonsense can be dumped. That was necessary for pages that were written in XHTML and parsed as XML. But XHTML pages have always been parsed as HTML, not XML (it's a long, ugly story, but in short, XML parsing was not available in any version of IE, and would also render a completely broken page if there were any syntax errors at all). Even in a true XHTML document there's no need for CDATA, since the widget code itself doesn't contain any of the "problem" characters, specifically, &, <, and >
davidekholm

Posts: 4,059
Registered: 18-Oct-2002
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 29 Jun 20, 15:07   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
Thanks André and jGromit! I've updated the b5 beta to use the updated widget syntax (all at http://jalbum.net/download/beta/jalbum-core.jar)
JeffTucker

Posts: 8,158
Registered: 31-Jan-2006
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 29 Jun 20, 15:19   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
Both validators are happy with that.

If you're heading for a new release, I've got a couple of tiny Minimal patches (minor validation issues). I'll email you....
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 29 Jun 20, 22:40   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
jGromit wrote:
xexyl wrote:
I thought of even removing widgets but something told me that's not a good idea.

I don't support them in any of my skins. They just intrude on the viewport, and provide things that aren't needed - a visit counter (your visitors don't care how many other people have been there before them), an "about" popup (most skins provide their own style-matched mechanism for that), and commenting (once the spammers find your site, you might as well turn that one off).


Funny you'd say that because I was just thinking of that about 20 minutes ago. I guess it's a matter of setting that variable to false that disables it? Because it would be a lot easier than to worry about adding css or the other themes.


Before adding any screen clutter to your albums, make sure there's a good reason for drawing attention away from the images.

Good point too.
xexyl

Posts: 181
Registered: 1-Sep-2009
Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 29 Jun 20, 22:43   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
davidekholm wrote:
I react to "Dave" too even if Swedes simply call me "David" :-). I've updated jAlbum's widget injection code to drop the type="text/javascript attribute. Any other things to adjust with the widget injection code?

My father is called David and he goes by that.

My best mate is also David but he goes by Dave. I talk to him much more than my father and I tend to not call my father by his given name (though every so often I do). Probably why I said Dave on top of being exhausted.

But I'd be surprised if you didn't react to 'Dave'. Of course the idea that I thought I read 'Dave' I see is now not possible: since your handle here is your name proper rather than referring to Dave.
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums