Thread Locked This thread is locked - replies are not allowed.



Permlink Replies: 110 - Pages: 8 [ Previous | 1 2 3 4 5 6 7 8 | Next ] - Last Post: 14-May-2020 15:17 Last Post By: JeffTucker Threads: [ Previous | Next ]
AndreWolff

Posts: 1,879
Registered: 14-Dec-2007
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 11:25   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
I could print a discrete console window warning, and naturally add this info to the release notes
I don't think you should print a discrete console window warning, because normal users will not see that.
I think you should give a standard warning message which is visible outside the console!
davidekholm

Posts: 3,455
Registered: 18-Oct-2002
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 12:33   in response to: AndreWolff in response to: AndreWolff
AndreWolff wrote:
davidekholm wrote:
It's "empty-page.htt", not "empty_page.htt"
OK I changed the name, but this does not solve the problem, see attached screenshot

It partly does. Now your version of empty-page.htt is picked when users choose "Empty page", but there should naturally not be a duplicate entry further down the menu. Now fixed in b16
davidekholm

Posts: 3,455
Registered: 18-Oct-2002
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 12:34   in response to: AndreWolff in response to: AndreWolff
AndreWolff wrote:
davidekholm wrote:
I could print a discrete console window warning, and naturally add this info to the release notes
I don't think you should print a discrete console window warning, because normal users will not see that.
I think you should give a standard warning message which is visible outside the console!

Let's await response from users. These errors mostly mean that the user has left a stale album folder behind, so we shouldn't bother users more than necessary.
AndreWolff

Posts: 1,879
Registered: 14-Dec-2007
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 12:38   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
It partly does. Now your version of empty-page.htt is picked when users choose "Empty page", but there should naturally not be a duplicate entry further down the menu. Now fixed in b16
Yes indeed that problem has now been solved, but I still get the java.lang.OutOfMemoryError: Java heap space
crash.
AndreWolff

Posts: 1,879
Registered: 14-Dec-2007
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 12:58   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
Let's await response from users. These errors mostly mean that the user has left a stale album folder behind, so we shouldn't bother users more than necessary.
I doin't understand this, I think as suddenly an album disappears, you should say the user why it did disappear!
karlmistelberger

Posts: 207
Registered: 5-Dec-2013
Make changes log
Posted: 13-May-2020 13:01   in response to: davidekholm in response to: davidekholm
Exception in thread "AWT-EventQueue-0" java.lang.UnsupportedOperationException: Taskbar API is not supported on the current platform
RobM

Posts: 3,375
Registered: 4-Aug-2006
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 13:09   in response to: AndreWolff in response to: AndreWolff
AndreWolff wrote:
davidekholm wrote:
Let's await response from users. These errors mostly mean that the user has left a stale album folder behind, so we shouldn't bother users more than necessary.
I doin't understand this, I think as suddenly an album disappears, you should say the user why it did disappear!
Why are you adding res folders to subfolders when they could be added to the root folder’s res folder? If it is to add files with the same name then the folder structure could be replicated inside the root res folder.
JeffTucker

Posts: 7,362
Registered: 31-Jan-2006
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 13:09   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
These errors mostly mean that the user has left a stale album folder behind....

That's not the situation he's describing. Let's say you have a MyDog project, and a MyCat project, and you're using a skin that creates a res directory in the image directory, to store a logo file, for example. Now you want to create a MyPets project, with your dog and cat as folders, so you drag in the original separate projects, each of which contains a res folder.

Rare case, but it could happen.

ETA: I believe I've detected David trying to take a shortcut to ignoring a leftover album directory, but this approach backfires in some strange ways. ;)
RobM

Posts: 3,375
Registered: 4-Aug-2006
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 13:16   in response to: JeffTucker in response to: JeffTucker
jGromit wrote:
davidekholm wrote:
These errors mostly mean that the user has left a stale album folder behind....

That's not the situation he's describing. Let's say you have a MyDog project, and a MyCat project, and you're using a skin that creates a res directory in the image directory, to store a logo file, for example. Now you want to create a MyPets project, with your dog and cat as folders, so you drag in the original separate projects, each of which contains a res folder.

Rare case, but it could happen.

It might be better to not let subfolders have a res folder, either have them ignored or shown but as permanently excluded.
davidekholm

Posts: 3,455
Registered: 18-Oct-2002
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 13:16   in response to: JeffTucker in response to: JeffTucker
jGromit wrote:
RobM wrote:
In the ‘Add’ drop down menu, new page defaults to offer an ‘Empty page’ for all skins.

And it shouldn't. I wish this could be taken care of. If the skin indicates, in its skin.properties file, that it doesn't support extra pages (fullSiteSupport=false), this context menu item should be absent, or at least grayed out.


Right. I've fixed this for b17 now
davidekholm

Posts: 3,455
Registered: 18-Oct-2002
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 13:24   in response to: davidekholm in response to: davidekholm
Attachment album.rss (2.4 KB)
I've released yet another beta. It's b17 and I hope it's the last before release

Changes since earlier betas:
  • Fixed issue where dates could be mixed up between images during album build (found such a mix-up within media.rss, assuming the same mix-up can happen to camera EXIF data too for instance). It turned out that the date formatter I use (SimpleDateFormat) wasn't thread safe. Now I've made a thread-safe subclass of it called SafeSimpleDateFormat.
  • If skins supply their own templates/empty-page.htt, this will be used for the New empty page action instead of the default from system/empty-page.htt
  • Disables "New Empty page" for skins that don't have full site support
  • Moves physical album folder if the location of the album folder is edited under Settings - General
  • Detects and ignores stale album folders if they show up under the image directory. A message is printed to the system console about this
  • Introduced new "addedDateRSS" variable, which behaves like "addedDate" but is formatted according to the MediaRSS specification. Updated album.rss to use this variable for the "pubDate" element instead of the earlier mediarssDate, which simply held the last modified date of the output folder. I've attached the updated album.rss file (should go under the system folder)
JeffTucker

Posts: 7,362
Registered: 31-Jan-2006
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 13:26   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
jGromit wrote:
RobM wrote:
In the ‘Add’ drop down menu, new page defaults to offer an ‘Empty page’ for all skins.

And it shouldn't. I wish this could be taken care of. If the skin indicates, in its skin.properties file, that it doesn't support extra pages (fullSiteSupport=false), this context menu item should be absent, or at least grayed out.

Right. I've fixed this for b17 now


It's a little flaky. Launch, choose Minimal (no full site support), create a new project, right-click, and it will let you add an Empty page. Delete the page, save, close, re-open, and right-click. Now the empty page choice is grayed out.
JeffTucker

Posts: 7,362
Registered: 31-Jan-2006
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 13:29   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
Moves physical album folder if the location of the album folder is edited under Settings - General

Not working in Win10. OK in macOS.

Detects and ignores stale album folders if they show up under the image directory. A message is printed to the system console about this

Some unintended side effects, as posted above. If the routine for moving the existing output is solid, maybe there's no need to try ignoring the old output, since it should no longer be there, anyway. Would that cure the "res in a folder" problem?
davidekholm

Posts: 3,455
Registered: 18-Oct-2002
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 13:30   in response to: JeffTucker in response to: JeffTucker
jGromit wrote:

It's a little flaky. Launch, choose Minimal (no full site support), create a new project, right-click, and it will let you add an Empty page. Delete the page, save, close, re-open, and right-click. Now the empty page choice is grayed out.

Can't reproduce :-(. You should only be able to do this in theory if you select the Minimal skin and then DIRECTLY thereafter try to add a page, I mean within the fraction of second it takes to load the skin. Were you THAT fast?
JeffTucker

Posts: 7,362
Registered: 31-Jan-2006
Re: jAlbum 20.1 beta for testing
Posted: 13-May-2020 13:36   in response to: davidekholm in response to: davidekholm
Attachment EmptyPage.mp4 (1.6 MB)
Consistent.

ETA: It happens only if the default skin does not support full site pages. So, if I launch, create a new project, switch to, say, Neptune, the choice is grayed out. If I switch back to Minimal, it's OK, too. In fact, if I start a new project, then just choose Minimal again, it works properly. :)

Edited by: jGromit on 13-May-2020 07:38
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums