Thread Locked This thread is locked - replies are not allowed.



Permlink Replies: 135 - Pages: 10 [ Previous | 1 2 3 4 5 6 | Next ] - Last Post: 19-Oct-2018 00:38 Last Post By: davidekholm Threads: [ Previous | Next ]
davidekholm

Posts: 3,551
Registered: 18-Oct-2002
Re: jAlbum 16.3 beta for testing
Posted: 14-Sep-2018 11:46   in response to: RobM in response to: RobM
RobM wrote:

When the disable chroma subsampling has been checked and then I switch back to Images/General settings and move the jpeg quality setting up to 95% I still get the yellow warning triangle 'This causes excess file size without any significant quality improvement.' Shouldn't that warning be turned off?

No, in either case you'll end up with rather large JPEGs compared to the quality gain so I think it's justified to show that warning.
jGromit

Posts: 7,261
Registered: 31-Jan-2006
Re: jAlbum 16.3 beta for testing
Posted: 14-Sep-2018 13:31   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
General use/testing is enough. I've removed some deprecated APIs and it's hard to know what skins are eventually using them....

Perhaps if you told us which API's have been removed.... ;)
davidekholm

Posts: 3,551
Registered: 18-Oct-2002
Re: jAlbum 16.3 beta for testing
Posted: 18-Sep-2018 14:26   in response to: jGromit in response to: jGromit
jGromit wrote:
davidekholm wrote:
General use/testing is enough. I've removed some deprecated APIs and it's hard to know what skins are eventually using them....

Perhaps if you told us which API's have been removed.... ;)


Yeah, If I remember that ;-). One was engine.getCharacterEncoding (now getTextEncoding) and another one was engine.supressIEWarnings. I also believe I removed engine.jpegName (now engine.getTargetName()).

It was really old stuff where I clearly point to another route so it's unlikely to break any skins that have been updated the last 3-4 years.
jGromit

Posts: 7,261
Registered: 31-Jan-2006
Re: jAlbum 16.3 beta for testing
Posted: 18-Sep-2018 14:35   in response to: davidekholm in response to: davidekholm
Sounds like your version control system is almost as robust as mine. "Hmmmm, now what did I do? And when? And I hope someone can tell me what I had for breakfast this morning."

The key isn't really whether a skin has been updated recently. It probably has more to do with when it was created. There are chunks of code in Matrix that I probably haven't touched in 10 years. Haven't seen any smoke and flames yet, however, so it's unlikely that I ever used any of the arcane things that are now gone. But it wouldn't surprise me to run into a "current" skin that still has something buried in it about things like IE warnings.
RobM

Posts: 3,065
Registered: 4-Aug-2006
Re: jAlbum 16.3 beta for testing
Posted: 18-Sep-2018 14:51   in response to: davidekholm in response to: davidekholm
Classically aligned 2 uses isSuppressIEWarnings and fails, the skin was updated June last year.
RobM

Posts: 3,065
Registered: 4-Aug-2006
Re: jAlbum 16.3 beta for testing
Posted: 18-Sep-2018 14:55   in response to: RobM in response to: RobM
Mr Burns 5 fails with
Stack trace for jAlbum 16.3b1 using skin Mr.Burn5 1.1:
 
se.datadosen.util.ScriptException: bsh.TargetError: Sourced file: inline evaluation of: ``      int num = 0;      StringBuilder b = new StringBuilder();      for(Iterator . . . '' : Typed variable declaration : Method Invocation JsonWriter.toJson : at Line: 8 : in file: inline evaluation of: ``      int num = 0;      StringBuilder b = new StringBuilder();      for(Iterator . . . '' : JsonWriter .toJson ( ( ImageData ) it .next ( ) ) 
 
Target exception: java.lang.NoClassDefFoundError: java/sql/Date
 in index.htt at line number 163
	at se.datadosen.jalbum.TemplateParser.eval(TemplateParser.java:897)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:819)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.handleScriptlet(TemplateParser.java:826)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:222)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:183)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:137)
	at se.datadosen.jalbum.TemplateParser.parseElements(TemplateParser.java:152)
	at se.datadosen.jalbum.AlbumBean.makeIndexPages(AlbumBean.java:3220)
	at se.datadosen.jalbum.AlbumBean.makeAlbumForFolder(AlbumBean.java:1439)
	at se.datadosen.jalbum.AlbumBean.makeAlbum(AlbumBean.java:2771)
	at se.datadosen.jalbum.AlbumBean.smartMakeAlbum(AlbumBean.java:2690)
	at se.datadosen.jalbum.JAlbumFrame$5.run(JAlbumFrame.java:1057)
Caused by: java.lang.NoClassDefFoundError: java/sql/Date
	at com.cedarsoftware.util.io.JsonWriter.writeObject(JsonWriter.java:890)
	at com.cedarsoftware.util.io.JsonWriter.writeImpl(JsonWriter.java:321)
	at com.cedarsoftware.util.io.JsonWriter.write(JsonWriter.java:197)
	at com.cedarsoftware.util.io.JsonWriter.objectToJson(JsonWriter.java:170)
	at com.cedarsoftware.util.io.JsonWriter.objectToJson(JsonWriter.java:135)
	at com.cedarsoftware.util.io.JsonWriter.toJson(JsonWriter.java:150)
	at com.cedarsoftware.util.io.JsonWriter.toJson(JsonWriter.java:122)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
	at bsh.Reflect.invokeMethod(Reflect.java:146)
	at bsh.Reflect.invokeStaticMethod(Reflect.java:94)
	at bsh.Name.invokeMethod(Name.java:875)
	at bsh.BSHMethodInvocation.eval(BSHMethodInvocation.java:75)
	at bsh.BSHPrimaryExpression.eval(BSHPrimaryExpression.java:102)
	at bsh.BSHPrimaryExpression.eval(BSHPrimaryExpression.java:47)
	at bsh.BSHVariableDeclarator.eval(BSHVariableDeclarator.java:86)
	at bsh.BSHTypedVariableDeclaration.eval(BSHTypedVariableDeclaration.java:84)
	at bsh.BSHBlock.evalBlock(BSHBlock.java:130)
	at bsh.BSHBlock.eval(BSHBlock.java:80)
	at bsh.BSHBlock.eval(BSHBlock.java:46)
	at bsh.BSHForStatement.eval(BSHForStatement.java:111)
	at bsh.Interpreter.eval(Interpreter.java:672)
	at bsh.Interpreter.eval(Interpreter.java:766)
	at bsh.Interpreter.eval(Interpreter.java:755)
	at bsh.BshScriptEngine.evalSource(BshScriptEngine.java:82)
	at bsh.BshScriptEngine.eval(BshScriptEngine.java:57)
	at java.scripting/javax.script.AbstractScriptEngine.eval(Unknown Source)
	at se.datadosen.jalbum.AlbumBean.doProcessExpression(AlbumBean.java:2546)
	at se.datadosen.jalbum.TemplateParser.eval(TemplateParser.java:886)
	... 38 more
Caused by: java.lang.ClassNotFoundException: java.sql.Date
	at java.base/java.net.URLClassLoader.findClass(Unknown Source)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	... 69 more
jGromit

Posts: 7,261
Registered: 31-Jan-2006
Re: jAlbum 16.3 beta for testing
Posted: 18-Sep-2018 15:21   in response to: RobM in response to: RobM
Two good catches - I get the same errors with CA2 and MrBurn5.

Especially nasty in the latter case, since the skin is bundled.
davidekholm

Posts: 3,551
Registered: 18-Oct-2002
Re: jAlbum 16.3 beta for testing
Posted: 18-Sep-2018 17:29   in response to: RobM in response to: RobM
Attachment Mr.Burn5.jaskin (142.9 KB)
RobM wrote:
Mr Burns 5 fails with codeStack trace for jAlbum 16.3b1 using skin Mr.Burn5 1.1:

Ah. That's not due to deprecated APIs. It's due to us skipping parts of the Java APIs that shouldn't be needed (like java.sql). It turned out that MrBurn5 used an old JSON generating code that needed that API. I've now rewritten it to use the new JSON API we're using. Try the attached one!
davidekholm

Posts: 3,551
Registered: 18-Oct-2002
Re: jAlbum 16.3 beta for testing
Posted: 18-Sep-2018 17:32   in response to: RobM in response to: RobM
RobM wrote:
Classically aligned 2 uses isSuppressIEWarnings and fails, the skin was updated June last year.

Here's a fix that simply ignores that deprecated call:
jGromit

Posts: 7,261
Registered: 31-Jan-2006
Re: jAlbum 16.3 beta for testing
Posted: 18-Sep-2018 17:40   in response to: davidekholm in response to: davidekholm
Re: Mr.Burn5 - that's better.

Some odd version numbering, however. The last version on the skin page is 1.0.2, but the bundled version is 1.1, which can't be downloaded from anywhere, and has no release notes.
jGromit

Posts: 7,261
Registered: 31-Jan-2006
Re: jAlbum 16.3 beta for testing
Posted: 18-Sep-2018 17:43   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
RobM wrote:
Classically aligned 2 uses isSuppressIEWarnings and fails, the skin was updated June last year.

Here's a fix that simply ignores that deprecated call:


Probably better to leave that to H-P. There's nothing wrong with tinkering with an orphan skin, but wading into the skin of an active developer is another matter.
RobM

Posts: 3,065
Registered: 4-Aug-2006
Re: jAlbum 16.3 beta for testing
Posted: 18-Sep-2018 21:10   in response to: jGromit in response to: jGromit
I have tried several older skins and have not found any other problems.
davidekholm

Posts: 3,551
Registered: 18-Oct-2002
Re: jAlbum 16.3 beta for testing
Posted: 19-Sep-2018 12:42   in response to: RobM in response to: RobM
RobM wrote:
I have tried several older skins and have not found any other problems.

Thanks for taking on that task.
Dschuwi

Posts: 457
Registered: 12-Nov-2003
Re: jAlbum 16.3 beta for testing
Posted: 19-Sep-2018 14:10   in response to: davidekholm in response to: davidekholm
davidekholm wrote:
RobM wrote:
Classically aligned 2 uses isSuppressIEWarnings and fails, the skin was updated June last year.

Here's a fix that simply ignores that deprecated call:


It seems it is just this one orphaned line of code, indeed, in init.bsh, line 544.

I shall release an updated version soon with one or two more really minor bug fixes not worth an upgrade so far ...
davidekholm

Posts: 3,551
Registered: 18-Oct-2002
Re: jAlbum 16.3 beta for testing
Posted: 19-Sep-2018 15:33   in response to: Dschuwi in response to: Dschuwi
Dschuwi wrote:

I shall release an updated version soon with one or two more really minor bug fixes not worth an upgrade so far ...

Thanks
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums