This question is not answered. Helpful answers available: 1. Correct answers available: 1.


Permlink Replies: 103 - Pages: 7 [ Previous | 1 2 3 4 5 6 7 | Next ] - Last Post: 23-Jul-2019 15:33 Last Post By: AndreWolff Threads: [ Previous | Next ]
jGromit

Posts: 7,277
Registered: 31-Jan-2006
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 18-Jul-2019 13:03   in response to: AndreWolff in response to: AndreWolff
 
  Click to reply to this thread Reply
AndreWolff wrote:
I think we don't need 3 user variables, I tested it with only user variable 'gpsLocation'.

Translation: "My skins don't use the other two, therefore they shouldn't be provided."

RobM, leave them there - I have three skins that use all three (gpsLocation, gpsLatitude, gpsLongitude), in different contexts.
RobM

Posts: 3,049
Registered: 4-Aug-2006
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 18-Jul-2019 13:04   in response to: AndreWolff in response to: AndreWolff
 
  Click to reply to this thread Reply
AndreWolff wrote:
I think we don't need 3 user variables, I tested it with only user variable 'gpsLocation'.
Three variables are needed as I don’t know what a sin developer will use.
AndreWolff

Posts: 1,715
Registered: 14-Dec-2007
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 18-Jul-2019 13:21   in response to: jGromit in response to: jGromit
 
  Click to reply to this thread Reply
jGromit wrote:
AndreWolff wrote:
I think we don't need 3 user variables, I tested it with only user variable 'gpsLocation'.

Translation: "My skins don't use the other two, therefore they shouldn't be provided."

Another nonsense remark, it did said that only to make it easier for Rob.
AndreWolff

Posts: 1,715
Registered: 14-Dec-2007
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 18-Jul-2019 13:23   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
AndreWolff wrote:
I think we don't need 3 user variables, I tested it with only user variable 'gpsLocation'.
Three variables are needed as I don’t know what a skin developer will use.
No problem for me!

But you can derive the other two variables from gpsLocation, that is what my function getLocation() is doing.

And gpsLocation can be derived from the other two. It is importanr that the user needs to enter only 2 values.

Edited by: AndreWolff on 18-Jul-2019 13:29
jGromit

Posts: 7,277
Registered: 31-Jan-2006
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 18-Jul-2019 13:27   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
...a sin developer....

Hey, I didn't come here to be insulted! ;)
AndreWolff

Posts: 1,715
Registered: 14-Dec-2007
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 18-Jul-2019 13:55   in response to: jGromit in response to: jGromit
 
  Click to reply to this thread Reply
jGromit wrote:
RobM wrote:
...a sin developer....

Hey, I didn't come here to be insulted! ;)


You are the expert in insulting!
jGromit

Posts: 7,277
Registered: 31-Jan-2006
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 18-Jul-2019 14:17   in response to: AndreWolff in response to: AndreWolff
 
  Click to reply to this thread Reply
AndreWolff wrote:
You are the expert in insulting!

Thank you. I do my best.
AndreWolff

Posts: 1,715
Registered: 14-Dec-2007
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 18-Jul-2019 20:40   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
RobM wrote:
There will be another update tonight to increase the accuracy, from two to four decimal places, for the decimal seconds value.
New file uploaded, fixed accuracy, changed grep to properly remove any number of leading zeros from latitude or longitude.

Rob, I still see a small problem in your tool: If I use your tool with a Vimeo or YouTube video in a web-location, I get the pop-up 'Create a Google Maps URL link for the selected video?'. If I next click the OK button I get no confirmation whether the GPS data are found or not. I see the same effect if I use the tool for an image.

I think you should first check whether the item is a correct video and if that is not the case you should show another text in your first pop-up.
RobM

Posts: 3,049
Registered: 4-Aug-2006
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 18-Jul-2019 21:05   in response to: AndreWolff in response to: AndreWolff
 
  Click to reply to this thread Reply
AndreWolff wrote:
Rob, I still see a small problem in your tool: If I use your tool with a Vimeo or YouTube video in a web-location, I get the pop-up 'Create a Google Maps URL link for the selected video?'. If I next click the OK button I get no confirmation whether the GPS data are found or not. I see the same effect if I use the tool for an image.

I think you should first check whether the item is a correct video and if that is not the case you should show another text in your first pop-up.

The tool clearly states it is for videos, not weblocations or images, so I'm not going to check for all misuse cases.

If you read the tools original post you will find my statement:
'This was made purely as an exercise for myself, not really sure anyone would want to use it for real.'

Now there is a real use for it, I'll improve it a bit more, but from my perspective I have achieved what I set out to do. I'll add more comments to the code, then anyone that wants to further improve or alter it is free to do so, just publish it with a slightly different name, like improved or MK2.
RobM

Posts: 3,049
Registered: 4-Aug-2006
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 19-Jul-2019 01:48   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
New version uploaded, with test for accidental selection of non-video file and manual entry option for videos without gps data.

That's all folks!
AndreWolff

Posts: 1,715
Registered: 14-Dec-2007
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 19-Jul-2019 09:11   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
New version uploaded, with test for accidental selection of non-video file and manual entry option for videos without gps data.
Excellent Rob, you implemented all my wishes! Thanks a lot!
Very good that you shows also a pop-up 'Manually entered GPS data already exists.'
That's all folks!
Not so fast! I still see possibilities to make it even more user friendly:

The pop-up 'Create a Google Maps URL link for the selected video?' is superfluously, after all the user did select a tool named 'Create GMaps link for video'.

Instead in the 'Processed video' window I think you should add text below the reported values:
'Save these values?' and add a Cancel button.
I think too that you should remove the '+' characters in the Latitude and Longitude, like with currency these character are normally not used. See also the notation in the Google Earth way-points window. And I am sure that 'gpsLocation=51.800198, 5.247233' is accepted in all skins.

I like of course the new window 'Past GPS latitude and longitude into the fields below'. But if I enter values without a + sign, the next message 'Sorry, latitude needs to start with + or -' is incorrect, these values are normally reported without a + sign, only a – sign might be needed. All GPS applications will accept GPS values without a + sign.

And after you close this error message window, you should go back to the 'Past GPS latitude ...' window to give the user the opportunity to correct his input'

But as said already the current version is already very good and I hope that David will add it to the distributed tools in the next jAlbum version!

Thanks again!
AndreWolff

Posts: 1,715
Registered: 14-Dec-2007
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 19-Jul-2019 09:18   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
davidekholm wrote:
It's not particularly clean to have to rely on an external executable for this. Better to have the Metadata-extractor library updated to handle this.
OK but then I hope you will add Robs Tool to get GPS link from video with GPS metadata untill you can solve this this in the jAlbum program.

See also the discussion above.
RobM

Posts: 3,049
Registered: 4-Aug-2006
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 19-Jul-2019 10:09   in response to: AndreWolff in response to: AndreWolff
 
  Click to reply to this thread Reply
AndreWolff wrote:
Excellent Rob, you implemented all my wishes! Thanks a lot!
Very good that you shows also a pop-up 'Manually entered GPS data already exists.'
Thanks.
That's all folks!
Not so fast! I still see possibilities to make it even more user friendly:
Sorry, but it’s good enough for me and I have other, non-jAlbum, things that need to be done over the next few months.
The pop-up 'Create a Google Maps URL link for the selected video?' is superfluously, after all the user did select a tool named 'Create GMaps link for video'.
Anyone can rename the tool to what they want - I just haven’t done it, I may do much later.
Instead in the 'Processed video' window I think you should add text below the reported values:
'Save these values?' and add a Cancel button.
The whole point was to extract gps data, why would you not want to save the data? So, that stays as is.
I think too that you should remove the '+' characters in the Latitude and Longitude, like with currency these character are normally not used. See also the notation in the Google Earth way-points window. And I am sure that 'gpsLocation=51.800198, 5.247233' is accepted in all skins.
Ffmpeg extracts the data and it always shows a + or -, I just kept to what is given - and it saves bloating the code with more tests.
I like of course the new window 'Past GPS latitude and longitude into the fields below'. But if I enter values without a + sign, the next message 'Sorry, latitude needs to start with + or -' is incorrect, these values are normally reported without a + sign, only a – sign might be needed. All GPS applications will accept GPS values without a + sign.
As above, I’m just keeping the internal code simple by following the ffmpeg presented coordinate format - I can just use those pasted values without additional tests - is it likely to be a valid ordinate and not ‘my dog has fleas’.
And after you close this error message window, you should go back to the 'Past GPS latitude ...' window to give the user the opportunity to correct his input'
It is only a one off event, unless of course the user repeatedly pastes the same information expecting a different result.
But as said already the current version is already very good and I hope that David will add it to the distributed tools in the next jAlbum version!
Highly unlikely, especially given the name of the coder ;)
jGromit

Posts: 7,277
Registered: 31-Jan-2006
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 19-Jul-2019 12:13   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
RobM wrote:
Anyone can rename the tool to what they want - I just haven’t done it, I may do much later.

I renamed my copy GPS from video. Makes it easier to find in the (growing) list of tools.
RobM

Posts: 3,049
Registered: 4-Aug-2006
Re: Make it possible to add GPS coordinates to movies and pictures in jAlbum
Posted: 19-Jul-2019 12:20   in response to: jGromit in response to: jGromit
 
  Click to reply to this thread Reply
jGromit wrote:
RobM wrote:
Anyone can rename the tool to what they want - I just haven’t done it, I may do much later.

I renamed my copy GPS from video. Makes it easier to find in the (growing) list of tools.

Out of date already, GPS to/from video now ;)
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums