Enlarge panoramic pictures automatically ...

jimberry

Posts: 603
Registered: 30-Aug-2004

Re: Enlarge panoramic pictures automatically
Posted: 9 Jun 15, 10:36

in response to: AndreWolff

Reply

If you did not intend it to be insulting, it certainly comes across as insulting. You have received a lot of help from people on this forum and and it is distressing for them to see such arrogant and yes, insulting remarks.
You seem to think that any suggestions you make should be implemented, but in fact your success rate of 5% is probably far in excess of the rate you can expect from much larger software companies with more resources.

davidekholm

Posts: 4,335
Registered: 18-Oct-2002

Re: Enlarge panoramic pictures automatically
Posted: 9 Jun 15, 11:06

in response to: AndreWolff

Reply

AndreWolff wrote:

davidekholm wrote:
For now I'd suggest that you simply create an image filter that performs the desired scaling/cropping for your skin

It is a waste of time if every skin implements his own solution for this skin Independent common problem and it is apparantly useless to propose improvements, because they are never implemented!l

If it was a common problem, then I'm sure we would have had requests for this years ago. It's perfectly possible to implement this as an image filter, and if it turns out to be an appreciated feature it can later be incorporated in jAlbum's core. There is a good reason for not implementing all bells and whistles as core features as it makes code maintenance harder. We're a very small team and has to consider this aspect carefully.

AndreWolff

Posts: 2,360
Registered: 14-Dec-2007

Re: Enlarge panoramic pictures automatically
Posted: 9 Jun 15, 19:50

in response to: davidekholm

Reply

davidekholm wrote:
It's perfectly possible to implement this as an image filter

The proposal of ctwist as discussed here can be implemented as an image filter in a custom panel, but the full automatic method proposed in this thread can as far as I can see not be implemented by a skin designer without changing anything to the nucleus of jAlbum.

If it can be done by a skin designer I hope that another skin designer takes the challenge!

davidekholm

Posts: 4,335
Registered: 18-Oct-2002

Re: Enlarge panoramic pictures automatically
Posted: 10 Jun 15, 10:16

in response to: AndreWolff

Reply

It's not that hard. Check out the source code of the CropFilter under jAlbum's "plugins" folder

AndreWolff

Posts: 2,360
Registered: 14-Dec-2007

Re: Enlarge panoramic pictures automatically
Posted: 10 Jun 15, 13:55

in response to: davidekholm

Reply

davidekholm wrote:
It's not that hard. Check out the source code of the CropFilter under jAlbum's "plugins" folder

As far as I can see is this CropFilter function executed via a right mouse click on an image. So even if I was so clever that I could modify this for a panorama picture, I sill have to indicate what a panorama picture is and that is not what I propose in this thread.

davidekholm

Posts: 4,335
Registered: 18-Oct-2002

Re: Enlarge panoramic pictures automatically
Posted: 10 Jun 15, 14:28

in response to: AndreWolff

Reply

AndreWolff wrote:

davidekholm wrote:
It's not that hard. Check out the source code of the CropFilter under jAlbum's "plugins" folder

As far as I can see is this CropFilter function executed via a right mouse click on an image. So even if I was so clever that I could modify this for a panorama picture, I sill have to indicate what a panorama picture is and that is not what I propose in this thread.

It's not the kind of front-end crop tool that you right click on, this crop filter runs behind the scenes, being controlled by either jAlbum's engine or a skin. A skin simply creates an instance of such a filter inside init.bsh and installs it by calling engine.addFilter()

AndreWolff

Posts: 2,360
Registered: 14-Dec-2007

Re: Enlarge panoramic pictures automatically
Posted: 10 Jun 15, 17:55

in response to: davidekholm

Reply

davidekholm wrote:
It's not the kind of front-end crop tool that you right click on, this crop filter runs behind the scenes, being controlled by either jAlbum's engine or a skin. A skin simply creates an instance of such a filter inside init.bsh and installs it by calling engine.addFilter()

So I can take a copy of your code, modify it and load it in the Plugin folder of the skin?
Do I have to change something in init,bsh?

Is there somewhere example code and/or documentation for making such an image filter?

davidekholm

Posts: 4,335
Registered: 18-Oct-2002

Re: Enlarge panoramic pictures automatically
Posted: 12 May 18, 13:12

in response to: AndreWolff

Reply

AndreWolff wrote:

davidekholm wrote:
It's not the kind of front-end crop tool that you right click on, this crop filter runs behind the scenes, being controlled by either jAlbum's engine or a skin. A skin simply creates an instance of such a filter inside init.bsh and installs it by calling engine.addFilter()

So I can take a copy of your code, modify it and load it in the Plugin folder of the skin?

Yes

Do I have to change something in init,bsh?

Just install the filter with engine.addFilter(new NameOfYourFilter()); in init.bsh or refer to it with a "filter1" user variable, for instance filter1=class=NameOfYourFilter param=value param2=value ...

Is there somewhere example code and/or documentation for making such an image filter?

All source code is available under the plugins folder. There is also a .sh and .bat file to compile them there. A filter simply needs to implement the JAFilter interface's filter method.

AndreWolff

Posts: 2,360
Registered: 14-Dec-2007

Re: Enlarge panoramic pictures automatically
Posted: 14 May 18, 09:19

in response to: davidekholm

Reply

davidekholm wrote:
Yes

Nice that I see an answer after 3 years!
I could not wait so long: the PhotoSwipe skin the Slide Show 4 skin uses now a panoramic user panel to enlarge panoramic pictures.

But as you see I was not the only one who was interested in the feature!