Reply to this Thread Reply to this Thread Search Forum Search Forum Back to Thread List Back to Thread List

Permlink Replies: 10 - Pages: 1 - Last Post: 26 Jun 26, 11:26 Last Post By: davidekholm Threads: [ Previous | Next ]
phil44

Posts: 195
Registered: 18-Jun-2010
Spell checker not always accessible via right-click.
Posted: 23 Jun 26, 11:58
  Click to reply to this thread Reply
I’ve noticed for a long time that right-clicking on a misspelled word doesn't always give access to the spell checker. Sometimes it works, sometimes it doesn't.

I just understood why:
  • if the text cursor is positioned on the misspelled word, the spell checker is accessible and the error can be corrected.
  • if the text cursor is outside the misspelled word, right-clicking on that word doesn't move the cursor to the clicked word, and the spell checker option in the context menu remains greyed out.
I checked other applications: when you click on a misspelled word, the text cursor automatically moves to the word you clicked, which grants access to the spell checker.

It's not a show-stopping bug, but IMHO, it's worth fixing.
Would it be possible to correct that in jAlbum?
RobM

Posts: 3,992
Registered: 4-Aug-2006
Re: Spell checker not always accessible via right-click.
Posted: 23 Jun 26, 20:13   in response to: phil44 in response to: phil44
  Click to reply to this thread Reply
Not sure if it is a bug, the manual states To look for a suggested alternative spelling select the word and control/right clicking to bring up a contextual menu, select Spelling. I can’t remember though if that was intentional or not.
phil44

Posts: 195
Registered: 18-Jun-2010
Re: Spell checker not always accessible via right-click.
Posted: 24 Jun 26, 15:58   in response to: RobM in response to: RobM
  Click to reply to this thread Reply
RobM wrote:
Not sure if it is a bug, the manual states To look for a suggested alternative spelling select the word and control/right clicking to bring up a contextual menu, select Spelling. I can’t remember though if that was intentional or not.
Sometimes the line between a bug and a feature request is blurry and very thin, and IMO that's the case here.

That said, fixing this can only improve the user experience, which is a good thing :-)
RobM

Posts: 3,992
Registered: 4-Aug-2006
Re: Spell checker not always accessible via right-click.
Posted: 24 Jun 26, 17:14   in response to: phil44 in response to: phil44
  Click to reply to this thread Reply
Bug or feature request, it seems a reasonable thing to ask for. Odd it’s never been mentioned before.
JeffTucker

Posts: 8,362
Registered: 31-Jan-2006
Re: Spell checker not always accessible via right-click.
Posted: 24 Jun 26, 17:42   in response to: RobM in response to: RobM
  Click to reply to this thread Reply
RobM wrote:
Odd it’s never been mentioned before.

Truly "quality" jAlbum users don't make spelling mistakes.
MarkusD

Posts: 886
Registered: 13-Apr-2006
Re: Spell checker not always accessible via right-click.
Posted: 24 Jun 26, 17:54   in response to: JeffTucker in response to: JeffTucker
  Click to reply to this thread Reply
JeffTucker wrote:
RobM wrote:
Odd it’s never been mentioned before.

Truly "quality" jAlbum users don't make spelling mistakes.

Yes, they don't write anything at all. :-))
davidekholm

Posts: 3,976
Registered: 18-Oct-2002
Re: Spell checker not always accessible via right-click.
Posted: 24 Jun 26, 18:21   in response to: RobM in response to: RobM
  Click to reply to this thread Reply
Interesting... I noticed that this bug only manifests on Windows.
The behaviour is controlled by a 3:rd party app (JOrtho). I've tried updating to the latest version but it didn't help.
phil44

Posts: 195
Registered: 18-Jun-2010
Re: Spell checker not always accessible via right-click.
Posted: 24 Jun 26, 19:17   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
JOrtho doesn't seem to have been updated since 2013, so there isn't much to hope for on that front :(

You might be able to patch or override the library's code to move the caret to the click location before starting the spell check.

Based on what I see in the JOrtho source code -- specifically in com.inet.jortho.PopupListener.java within the maybeShowPopup(MouseEvent ev) method -- inserting a call like the one below might solve the issue:
ev.getComponent().setCaretPosition(ev.getComponent().viewToModel(e.getPoint()));
There is probably some casts to insert, to avoid compilation errors.

I don't have the proper setup to check if it works, I'll leave that to you.
This is just an idea, I hope this can help :)
davidekholm

Posts: 3,976
Registered: 18-Oct-2002
Re: Spell checker not always accessible via right-click.
Posted: 24 Jun 26, 20:46   in response to: phil44 in response to: phil44
  Click to reply to this thread Reply
That worked fine! I've implemented this in v39.6.2 now. Just do a core update to get the fix (Tools->External tools->jAlbum core update)
phil44

Posts: 195
Registered: 18-Jun-2010
Re: Spell checker not always accessible via right-click.
Posted: 25 Jun 26, 16:28   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
Great, it works perfectly! Thanks, David :)
davidekholm

Posts: 3,976
Registered: 18-Oct-2002
Re: Spell checker not always accessible via right-click.
Posted: 26 Jun 26, 11:26   in response to: phil44 in response to: phil44
  Click to reply to this thread Reply
You're welcome. Thanks for pointing this out and for the coding :-)
Pages: 1
Back to Thread List Back to Thread List
Threads: [ Previous | Next ]
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums