This question is not answered. Helpful answers available: 2. Correct answers available: 1.

Reply to this Thread Reply to this Thread Search Forum Search Forum Back to Thread List Back to Thread List

Permlink Replies: 8 - Pages: 1 - Last Post: 8 Jun 26, 19:52 Last Post By: JeffTucker Threads: [ Previous | Next ]
JeffTucker

Posts: 8,338
Registered: 31-Jan-2006
Menu choice to embed album
Posted: 21 Apr 26, 22:00 		 
  Click to reply to this thread Reply
Attachment embedError.png (26.6 KB)
With the introduction of Laza's new Embed skin, perhaps this is the time to do a little cleaning up in that general vicinity.

The menu choice for Album > Embed album should be grayed out if the current project has not been uploaded anywhere. Currently, it just coughs up an error - screenshot.

While you're in there, that menu choice should also be grayed out at all times if the skin includes an empty embed.htt file (rather than no file at all - in that case it falls back on the core default). This should be taken as an indication that the skin developer doesn't think an album made with this skin should ever be embedded.
JeffTucker

Posts: 8,338
Registered: 31-Jan-2006
Re: Menu choice to embed album
Posted: 21 Apr 26, 22:06   in response to: JeffTucker in response to: JeffTucker 		 
  Click to reply to this thread Reply
One more item: the current default embed.htt includes the frameborder attribute, which is not supported in HTML5 (in other words, it's really, really obsolete). It should be using CSS for that:
<iframe src="${albumURL}" style="border:0px; height:${albumHeight}px; width:${albumWidth}px;"></iframe>
JeffTucker

Posts: 8,338
Registered: 31-Jan-2006
Re: Menu choice to embed album
Posted: 22 Apr 26, 14:54   in response to: JeffTucker in response to: JeffTucker 		 
  Click to reply to this thread Reply
JeffTucker wrote:
While you're in there, that menu choice should also be grayed out at all times if the skin includes an empty embed.htt file...

...or let the skin disable the menu entry, perhaps by adding something to disabledControls in skin.properties.
davidekholm

Posts: 3,969
Registered: 18-Oct-2002
Re: Menu choice to embed album
Posted: 23 Apr 26, 11:18   in response to: JeffTucker in response to: JeffTucker 		 
  Click to reply to this thread Reply
Thanks Jeff
JeffTucker

Posts: 8,338
Registered: 31-Jan-2006
Re: Menu choice to embed album
Posted: 7 May 26, 15:30   in response to: davidekholm in response to: davidekholm 		 
  Click to reply to this thread Reply
Sorry to see that none of this made it into jAlbum 39.5. These have been on my "hit list" for about a decade.

You should give Sparky a good talking-to. ;)
davidekholm

Posts: 3,969
Registered: 18-Oct-2002
Re: Menu choice to embed album
Posted: 7 May 26, 16:09   in response to: JeffTucker in response to: JeffTucker 		 
  Click to reply to this thread Reply
The plan is to soon bundle Embed skin with jAlbum, then I can revisit this behavior
JeffTucker

Posts: 8,338
Registered: 31-Jan-2006
Re: Menu choice to embed album
Posted: 8 Jun 26, 18:46   in response to: davidekholm in response to: davidekholm 		 
  Click to reply to this thread Reply
In jAlbum 39.6, I'm not seeing any change in the behavior of embedding. The obsolete "frameborder" attribute is still there, it's still coughing up an error if the album hasn't been uploaded yet (the choice should be grayed out in that case), and I can't see a way for my skins to keep that choice disabled at all times.

Not sure what the line in the release notes is referring to, but it's not any of these problems.
davidekholm

Posts: 3,969
Registered: 18-Oct-2002
Re: Menu choice to embed album
Posted: 8 Jun 26, 19:33   in response to: JeffTucker in response to: JeffTucker 		 
  Click to reply to this thread Reply
Where do you see frameborder being referred? In the code? Skins that supplies a custom embed.htt have full control of the code generated.
JeffTucker

Posts: 8,338
Registered: 31-Jan-2006
Re: Menu choice to embed album
Posted: 8 Jun 26, 19:48   in response to: davidekholm in response to: davidekholm 		 
  Click to reply to this thread Reply
davidekholm wrote:
Where do you see frameborder being referred?

It's in jAlbum/system/embed.htt.

Skins that supplies a custom embed.htt have full control of the code generated.

In most of my skins, I don't want Album > Embed album to be enabled at all. The albums should never be embedded. Perhaps if a skin supplies an empty embed.htt, the core could take the hint, and gray out that menu option.

ETA: Here's the logic:

  • Skin includes an empty embed.htt, gray out Album > Embed album at all times.
  • Skin includes a non-empty embed.htt or no template at all, but album hasn't be uploaded, gray out Album > Embed album.
  • Skin includes a non-empty embed.htt or no template, and album has been uploaded, enable Album > Embed album.
Pages: 1
Back to Thread List Back to Thread List
Threads: [ Previous | Next ]
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums