This question is answered.


Permlink Replies: 40 - Pages: 3 [ Previous | 1 2 3 ] - Last Post: 9 Feb 26, 19:08 Last Post By: zif
JeffTucker

Posts: 8,335
Registered: 31-Jan-2006
Re: Hero image low resolution
Posted: 8 Feb 26, 11:33   in response to: Laza in response to: Laza
 
  Click to reply to this thread Reply
Laza wrote:
I guess it's futile to work around the jAlbum bug, so I'll wait until David fixes this.

Agreed - the skins would have to take over the slide image scaling and cropping. No thank you! ;)
Laza

Posts: 1,511
Registered: 6-Sep-2005
Re: Hero image low resolution
Posted: 8 Feb 26, 11:37   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
Tiger skin first applies the PRESCALE filters to the theme images, then it scales to the tighter dimension, then crops it, and finally applies the POSTSCALE filters. I have no idea how jAlbum should handle cropped images. Perhaps cropping should not be applied in the PRESCALE stage? Or is that applied in the POSTSCALE stage? Both will screw up the theme image cropping.
JeffTucker

Posts: 8,335
Registered: 31-Jan-2006
Re: Hero image low resolution
Posted: 8 Feb 26, 17:09   in response to: Laza in response to: Laza
 
  Click to reply to this thread Reply
The ThemeImageProcessor() method in the core doesn't apply any of the image edits to the theme image. So, you can crop it like crazy, invert the colors, apply watermarks, whatever. But the theme image is generated from the unmodified image, as added to the project. Just watch the "theme image" box on the lower right as you make edits to the image. Its Explore thumbnail changes, but the theme image and its crop mask do not.

That may not be perfect, but it's a reasonable approach to take. The cropping requirements for a regular image in the gallery aren't likely to be the same as the cropping requirements for that same image when used as a theme image. It's not possible to get them both right.

The theme image crop mask is what gets applied to the image when it's used as the theme image. If regular cropping were also applied, how would you figure out how to do that? Which one goes first? Regular cropping for the thumbnail and slide versions of the image, theme image cropping for the theme image. You can't mix the two.

If a user wants to apply cropping to an image for its use as the theme image, he needs to pre-crop it. He could add it to a project with the NoPages skin, set the image bounds crazy large (like 10000x10000), apply cropping and whatever other image editing he wants to do, hit Make Album, and grab the output slide image. Then add that image to the real project, exclude it, and then select it as the theme image.

ETA: This is why I try to avoid "rolling my own." ;)
Laza

Posts: 1,511
Registered: 6-Sep-2005
Re: Hero image low resolution
Posted: 9 Feb 26, 10:06   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
The ThemeImageProcessor came 10 years later than my skins introduced theme images. They generate 3 sizes, plus 2x versions, and can generate B&W versions too. This is why they don't use this handy library.

Creating a copy of the file in the album could fix this. The one that goes to the lightbox can then be cropped; the other one is used as the theme image and excluded.
JeffTucker

Posts: 8,335
Registered: 31-Jan-2006
Re: Hero image low resolution
Posted: 9 Feb 26, 14:03   in response to: Laza in response to: Laza
 
  Click to reply to this thread Reply
Laza wrote:
The ThemeImageProcessor came 10 years later than my skins introduced theme images. They generate 3 sizes, plus 2x versions, and can generate B&W versions too. This is why they don't use this handy library.

For a bundled, in-house skin, I'm not sure that's a good idea from a company standpoint, or for future maintainability.

BTW, you can do B&W background images with CSS.
background-color: #ffffff;
background-blend-mode: luminosity;
By changing the background color, you can get some weird effects. Not good, but certainly interesting. ;)
Laza

Posts: 1,511
Registered: 6-Sep-2005
Re: Hero image low resolution
Posted: 9 Feb 26, 14:24   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
Yes, I will ask David whether the additional sizes can be added.
RobM

Posts: 3,982
Registered: 4-Aug-2006
Re: Hero image low resolution
Posted: 9 Feb 26, 14:48   in response to: Laza in response to: Laza
 
  Click to reply to this thread Reply
Wouldn’t method 3: https://jalbum.net/help/en/Sample_scripts#Theme_images
Do the job, by changing the themeFile reference and the dimension bounds to create the other images.
JeffTucker

Posts: 8,335
Registered: 31-Jan-2006
Re: Hero image low resolution
Posted: 9 Feb 26, 15:17   in response to: RobM in response to: RobM
 
  Click to reply to this thread Reply
We're getting ahead of ourselves. This needs to be a separate discussion involving the need for so many variations on the same thing, and on providing user control over them (for example, the "small display" version of the theme image in Tiger, used for phones and iPad Minis in portrait mode, is cropped differently, but there's no way for the user to adjust the crop mask).
Laza

Posts: 1,511
Registered: 6-Sep-2005
Re: Hero image low resolution
Posted: 9 Feb 26, 15:50   in response to: zif in response to: zif
Correct
  Click to reply to this thread Reply
David has fixed the bug with the cropped image dimensions. Use Tools / External tool / jAlbum core update to get the latest jAlbum, v39.2.1.

The source of the theme image is supposed to be large enough after cropping - 920x240 px in this case - to avoid blurred theme images.
JeffTucker

Posts: 8,335
Registered: 31-Jan-2006
Re: Hero image low resolution
Posted: 9 Feb 26, 15:58   in response to: Laza in response to: Laza
 
  Click to reply to this thread Reply
Not just the theme image. It was also "scaling then cropping" the slide image, with equally lousy results. It looks like that's gotten fixed.

Now, to go check a decade-old bug involving thumbnail images that I've been keeping on the back burner for years.... ;)

ETA: Nope, that one is still there. It's a case in which the fixed-shape filter is being applied after the scaling, producing a thumbnail that's smaller than necessary. I'm glad that some things never change - it provides constancy in my life.
zif

Posts: 30
Registered: 8-Nov-2009
Re: Hero image low resolution
Posted: 9 Feb 26, 19:08   in response to: Laza in response to: Laza
 
  Click to reply to this thread Reply
Laza wrote:
David has fixed the bug with the cropped image dimensions. Use Tools / External tool / jAlbum core update to get the latest jAlbum, v39.2.1.

The source of the theme image is supposed to be large enough after cropping - 920x240 px in this case - to avoid blurred theme images.


I can confirm that the bug with the cropped image dimensions has been fixed with the update.

Thank you for your support!!!

PS: I still have the problem with the fileiterator code. But that's a different topic, and I'll probably open another thread.
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums