Thread Locked This thread is locked - replies are not allowed.


This question is answered. Helpful answers available: 2. Correct answers available: 1.


Permlink Replies: 10 - Pages: 1 - Last Post: 5 Aug 23, 16:48 Last Post By: JeffTucker
JeffTucker

Posts: 8,522
Registered: 31-Jan-2006
Odd failure in Skin Info panel
Posted: 3 Aug 23, 19:30
 
Attachment ss011077.png (18.7 KB)
If the skin name contains a space - Opus 16, Classic Aligned 2 - the link to the download page for it fails. It's not that the URL is bad - it doesn't even launch the default browser.

See screenshot.
JeffTucker

Posts: 8,522
Registered: 31-Jan-2006
Re: Odd failure in Skin Info panel
Posted: 3 Aug 23, 21:17   in response to: JeffTucker in response to: JeffTucker
 
Intriguingly, it also fails on the skin's About panel. The routine is fetching the correct string, however:
SkinProperties skinProps = new SkinProperties(skinDirectory);
skinPage = skinProps.getProperty(SkinProperties.TITLE);
It fails once it's assigned to a label:
JLinkLabel linkSkin = new JLinkLabel(skinPage, "jAlbum Skin Page");
And therein lies a hint. If I do this, it works:
JLinkLabel linkSkin = new JLinkLabel(skinPage.replaceAll(" ", "%20"), "jAlbum Skin Page");
It ain't pretty, but....
davidekholm

Posts: 4,014
Registered: 18-Oct-2002
Re: Odd failure in Skin Info panel
Posted: 4 Aug 23, 13:51   in response to: JeffTucker in response to: JeffTucker
 
Do a core update to v32.0.1 and tell me if it works satisfactory now
JeffTucker

Posts: 8,522
Registered: 31-Jan-2006
Re: Odd failure in Skin Info panel
Posted: 4 Aug 23, 13:57   in response to: davidekholm in response to: davidekholm
 
No, the link is still unresponsive. Doesn't launch the browser.

(My fix works fine in my own About panel.)
davidekholm

Posts: 4,014
Registered: 18-Oct-2002
Re: Odd failure in Skin Info panel
Posted: 4 Aug 23, 14:14   in response to: JeffTucker in response to: JeffTucker
 
OK, now it should work.
JeffTucker

Posts: 8,522
Registered: 31-Jan-2006
Re: Odd failure in Skin Info panel
Posted: 4 Aug 23, 14:15   in response to: JeffTucker in response to: JeffTucker
 
BTW, the standard Java "encode" routines replace the space with a plus-sign, like Opus+16. But that still fails. It really does need the %20 encoding of the space.
JeffTucker

Posts: 8,522
Registered: 31-Jan-2006
Re: Odd failure in Skin Info panel
Posted: 4 Aug 23, 14:15   in response to: davidekholm in response to: davidekholm
 
davidekholm wrote:
OK, now it should work.

Yup, that's got it. Case closed. :)
waltbros

Posts: 15
Registered: 26-Dec-2006
Re: Odd failure in Skin Info panel
Posted: 5 Aug 23, 15:28   in response to: JeffTucker in response to: JeffTucker
 
Ok, I give up. How do I do a core update? I thought it was in the external tools section.
Walt
JeffTucker

Posts: 8,522
Registered: 31-Jan-2006
Re: Odd failure in Skin Info panel
Posted: 5 Aug 23, 15:48   in response to: waltbros in response to: waltbros
 
Attachment ss011081.png (19.5 KB)
That's where it is - see screenshot. And it's part of the standard jAlbum application - it's not something you have to install yourself.
waltbros

Posts: 15
Registered: 26-Dec-2006
Re: Odd failure in Skin Info panel
Posted: 5 Aug 23, 16:39   in response to: JeffTucker in response to: JeffTucker
 
JeffTucker wrote:
That's where it is - see screenshot. And it's part of the standard jAlbum application - it's not something you have to install yourself.

I guess at 81 I'm going blind. Passed right over it. Thanks
JeffTucker

Posts: 8,522
Registered: 31-Jan-2006
Re: Odd failure in Skin Info panel
Posted: 5 Aug 23, 16:48   in response to: waltbros in response to: waltbros
 
I'm 70, but with glasses, I still see pretty well. However, I'm often hopelessly bewildered. ;)
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums