Thread Locked This thread is locked - replies are not allowed.



Permlink Replies: 124 - Pages: 9 [ Previous | 1 2 3 4 5 6 | Next ] - Last Post: 29 Oct 25, 19:50 Last Post By: davidekholm
JeffTucker

Posts: 8,009
Registered: 31-Jan-2006
Re: jAlbum 38 release candidate for testing
Posted: 12 Oct 25, 14:19   in response to: RobM in response to: RobM
I bumped myself up to rc3 from rc1, and Journal still works with the simple case of internally-linked files. I gave Missive a shot, as well, and that also produced no errors, at least with the default settings.

(ETA: Off-topic, but in Missive, "Miscellaneous" should have two L's. Just sayin'.)
RobM

Posts: 3,877
Registered: 4-Aug-2006
Re: jAlbum 38 release candidate for testing
Posted: 12 Oct 25, 15:36   in response to: JeffTucker in response to: JeffTucker
JeffTucker wrote:
I bumped myself up to rc3 from rc1, and Journal still works with the simple case of internally-linked files. I gave Missive a shot, as well, and that also produced no errors, at least with the default settings.

(ETA: Off-topic, but in Missive, "Miscellaneous" should have two L's. Just sayin'.)

Sounds like my computer may be the problem, Tahoe operating system and there are things that I’m not convinced are an improvement on the previous system.

Off-topic, Keyboard issues, or at least me having issues using it, will fix it, thanks for noticing it.
davidekholm

Posts: 3,801
Registered: 18-Oct-2002
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 00:10   in response to: RobM in response to: RobM
Now v38rc6 is available. Apart from fixing a load of old and new bugs, it allows views to be sourced, not just from the root, but from the current directory they were created in.
JeffTucker

Posts: 8,009
Registered: 31-Jan-2006
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 14:44   in response to: davidekholm in response to: davidekholm
My skins were working just fine with "views," but are now failing. I know why, but I'm not sure how to fix it. I start out in earlyinit.groovy, where I filter out unsupported objects from the project. Apparently, a "view" is a new Category type. Easily fixed, but spare me the hunting - what's the correct category for a view?
CategoryFilter categoryFilter = new CategoryFilter().include(Category.folder, Category.image, Category.video, Category.audio, Category.webLocation).include("pdf");
rejectCounter = new RejectCounterFilter(categoryFilter);
factory.setFilter(rejectCounter);
ETA: Upon reflection, I fear this is going to cause all sorts of problems elsewhere. I do a lot of "category counting" in my skins, for a variety of reasons. If a view isn't recognized as a folder, I'm going to have many, many problems.

ETA: Found it: Category = view. Busy at the moment, but I'll do some testing later today (last of my beach house guests are leaving this morning.)
davidekholm

Posts: 3,801
Registered: 18-Oct-2002
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 16:39   in response to: JeffTucker in response to: JeffTucker
Hi Jeff,

Let me explain how I'm handling views: In the Explore view, a view is of the new category Category.view, but during an album make, after earlyinit but before init the object tree is traversed and all views are processed, rendering what looks like an ordinary object tree now. For compatibility, a processed view is of Category.folder, but you can still know it it's a former view by calling ao.isView() or by calling ao.getProperties().get(AOP.VIEW) != null

(Doing ao.getProperties().get(AOP.VIEW) will return a View object, describing details of the currently applied View. More on that later when I've updated the API docs)
davidekholm

Posts: 3,801
Registered: 18-Oct-2002
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 16:40   in response to: davidekholm in response to: davidekholm
Jeff, if it simplifies matters, I don't think anything breaks by me processing views even before earlyinit. Let me know!
JeffTucker

Posts: 8,009
Registered: 31-Jan-2006
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 17:04   in response to: davidekholm in response to: davidekholm
That sounds like it will be safe, with just a 30-second fiddle to each of my skins. If I just add the Category.view to the list of "acceptable" object types, everything from that point on seems to behave itself just fine. After that, I don't ever need to know if it's a view or an ordinary folder, as long as the core takes care of the object paths. If the view processing occurs before earlyinit ( reallyearlyinit? ), my skins should work as they're currently published. So, either way is fine.

(ETA: Just one interesting wrinkle. If I include Category.view in the list of acceptable objects, the skin will then require jAlbum 38 or better - they all currently require 33.3. That's OK with me, but it's something to remember for all skins.)

The only thing that I know is still a little sub-optimal is combining views with internally-linked objects. For example, the "alphabetic" view picks up the original AO, but also grabs an internally-linked AO. So. you get double entries in the album pages for the view. As I said earlier, that's getting into a very "fringe-y" case, so maybe just something to put on the "future exploration" list.
davidekholm

Posts: 3,801
Registered: 18-Oct-2002
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 18:49   in response to: JeffTucker in response to: JeffTucker
JeffTucker wrote:

The only thing that I know is still a little sub-optimal is combining views with internally-linked objects. For example, the "alphabetic" view picks up the original AO, but also grabs an internally-linked AO. So. you get double entries in the album pages for the view. As I said earlier, that's getting into a very "fringe-y" case, so maybe just something to put on the "future exploration" list.

Yes, I plan to address those fringe cases later on. Not the highest prio. I also noticed this while testing. Internal linking is best when it's implicitly used by views.
RobM

Posts: 3,877
Registered: 4-Aug-2006
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 20:28   in response to: davidekholm in response to: davidekholm
The view 'Recently added', seems to have an overly generous range for the 'N days' spinner. 0 to ? I stopped at just over 6000 days. 0 days would seem to only be valid for a new album, when everything is new.

I'd think 7 days for a lower limit and 365 for an upper would be ample.

If the result of the 'check size' test, any of the types, is zero then you get an empty web page for the view. I think either no page being generated or a fallback to the last nnn days, where the user can enter the fallback range.

Not yet checked the other view types, but if any produce an empty page the same holds true.
RobM

Posts: 3,877
Registered: 4-Aug-2006
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 20:30   in response to: davidekholm in response to: davidekholm
The review mode should be disabled for views, you just get a window filled with grey.
RobM

Posts: 3,877
Registered: 4-Aug-2006
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 20:44   in response to: davidekholm in response to: davidekholm
If I have a recently added view and a by date view, the recently added view is shown in the web page for the by date view. Logically this seems right, but somehow I feel it should not be shown. Maybe all views should be mutually exclusive, their results only appearing in the view itself?

A more urgent problem is that the by date view includes the folder for alphabetically ordered view. On the webpage navigating the 'By Date' view until I see the 'Alphabetically' view, clicking on that folder gives a 404 error e.g. Stocks/Views/By%20date/2025/Oct/Alphabetically
JeffTucker

Posts: 8,009
Registered: 31-Jan-2006
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 22:12   in response to: RobM in response to: RobM
RobM wrote:
The view 'Recently added', seems to have an overly generous range for the 'N days' spinner. 0 to ? I stopped at just over 6000 days. 0 days would seem to only be valid for a new album, when everything is new.

I'd think 7 days for a lower limit and 365 for an upper would be ample.


The upper limit is 50000 days, which works out to 137 years. That does seem to be a tad large. ;)

I'd leave the lower limit at 0. For someone who wants to test the functionality, they need that kind of lower limit. I think a max of 365 would be sensible, but it could top out at 999 (which means the field doesn't need to be formatted).
JeffTucker

Posts: 8,009
Registered: 31-Jan-2006
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 22:17   in response to: RobM in response to: RobM
RobM wrote:
The review mode should be disabled for views, you just get a window filled with grey.

Not sure I follow that. When I go into review mode, I can't actually "enter" the view folder. At most, I can see the representing image for the folder, but not its constituents.
RobM

Posts: 3,877
Registered: 4-Aug-2006
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 22:30   in response to: JeffTucker in response to: JeffTucker
JeffTucker wrote:
RobM wrote:
The review mode should be disabled for views, you just get a window filled with grey.

Not sure I follow that. When I go into review mode, I can't actually "enter" the view folder. At most, I can see the representing image for the folder, but not its constituents.

In Explore mode, and from the 'Projects panel', I selected the 'Views' folder and then invoked the review mode from the menu (SHIFT + CMD + F). If you try it from outside a view folder it doesn't happen.
JeffTucker

Posts: 8,009
Registered: 31-Jan-2006
Re: jAlbum 38 release candidate for testing
Posted: 16 Oct 25, 22:37   in response to: RobM in response to: RobM
Stranger and stranger. In the project panel, I'm not seeing the folder for the "recently added" view, so I can't select it to begin with. Screenshot.
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums