Posts:
8,330
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 16:23
in response to: davidekholm
|
|
|
b20 now available, adding a context menu when clicking an attachment....
Not sure what you mean by that. Where would I right-click on an attachment? |
|
|
Posts:
3,965
Registered:
18-Oct-2002
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 17:14
in response to: JeffTucker
|
|
|
b20 now available, adding a context menu when clicking an attachment....
Not sure what you mean by that. Where would I right-click on an attachment?
The paper clip status icon of the top-right corner of a thumbnail that has an attachment can be clicked to reveal options. |
|
|
Posts:
3,965
Registered:
18-Oct-2002
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 17:16
in response to: davidekholm
|
|
|
|
b22 now available, ensuring that non-images that have image attachments will always have closeups generated.
|
|
|
Posts:
8,330
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 17:42
in response to: davidekholm
|
|
|
The paper clip status icon of the top-right corner of a thumbnail that has an attachment can be clicked to reveal options.
Ah, I see. Not sure I'd offer a "show in file system" option. The .jalbum folder should be a dark, scary place into which a user should never venture.  |
|
|
Posts:
8,330
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 17:51
in response to: davidekholm
|
|
|
b22 now available, ensuring that non-images that have image attachments will always have closeups generated.
Much better. 
For a video with an attachment, the edit mode now lets you use the sliders. If you use the lower "choose a thumbnail" slider, of course, your attachment is effectively replaced by the newly-chosen thumbnail image for the video, which is rational. If a user does that, then complains about the results, I think my response would be, "WTF did you think you were doing when you used the slider to choose a new thumbnail?!" He can always revert by deleting and re-attaching the RI. Happily, trimming a video with the upper slider doesn't mangle things.
Only the JPG AO plus JPG RI combination does something a little counter-intuitive, but I'm not sure how the core should handle that. If you choose Use original, you get the RI thumbnail, and the AO slide image, which is fine. But if you're doing scaling, the RI replaces the AO in the album, both for the thumbnail and for the slide image. But again, one has to wonder what a user who chooses that combination of options is expecting to have happen - maybe an RI thumbnail and a scaled AO for the slide? Kind of a fringe case, I think. |
|
|
Posts:
3,965
Registered:
18-Oct-2002
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 17:55
in response to: JeffTucker
|
|
|
Ah, I see. Not sure I'd offer a "show in file system" option. The .jalbum folder should be a dark, scary place into which a user should never venture.
Yes, I'll probably remove that function. User should't manipulate the contents of the attachments directory directly. |
|
|
Posts:
3,965
Registered:
18-Oct-2002
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 17:57
in response to: davidekholm
|
|
|
|
b23 out, the Explore view now paints faint icons on top of audio files and other files having attached images (to distinguish these files from plain images)
|
|
|
Posts:
8,330
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 19:52
in response to: davidekholm
|
|
|
|
Not testable. I've had to do a Force Quit almost every time I've launched it. Sometimes I can open one project, but as soon as I try to close that one and open another, I'm dead in the water.
|
|
|
Posts:
3,982
Registered:
4-Aug-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 20:46
in response to: JeffTucker
|
|
|
Not testable. I've had to do a Force Quit almost every time I've launched it. Sometimes I can open one project, but as soon as I try to close that one and open another, I'm dead in the water.
Must be a Windows issue, projects open, make and close OK on a Mac. |
|
|
Posts:
8,330
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 21:00
in response to: RobM
|
|
|
|
I’m on my Mac.
ETA: I've narrowed it down. There's something in one of my test projects that's choking it. If I move them all out of the way, jAlbum doesn't get hung. Time to try one at a time....
ETAETA: Found the culprit, but with all the mucking about I've been doing, it's hard to say what it was about that one particular project that was making trouble. I was tinkering around with using an RI on an MP4, but then using the sliders to choose another thumbnail, then re-adding the RI, etc., etc. Can't recreate the problem now, but that one project was a killer, even without opening it.
ETA: David, check your email for a link to the zipped-up project in question. Still don't know why, but planting it in My Albums causes lots of trouble!
|
|
|
Posts:
8,330
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
29 Sep 25, 21:43
in response to: JeffTucker
|
|
|
|
|
|
I'm seeing some oddities in the project previews in the left panel, the ones that appear when you hover on the thumbnail for one of the projects. I'm getting partial web page views (e.g., just a theme image, with no thumbs), and previews that don't belong to the project in question. I think there's trouble lurking in there somewhere.
Attachments: the hover image vs. the web page itself.
ETA: I'm seeing the same thing in jAlbum 37, so this is not a new issue. Maybe I just never noticed it before.
|
|
|
Posts:
3,965
Registered:
18-Oct-2002
|
|
|
|
Re: Cleaning up path variables
Posted:
30 Sep 25, 22:22
in response to: JeffTucker
|
|
|
Jeff, the new b24 fixes the UI locking up.
This was a hell of a tricky thing to track down. The basic problem is that loading AlbumObjectProperties was triggered during the painting of thumbnails after me adding the code that superimposes icons onto representing images. Now, the loading of AlbumObjectProperties in itself shouldn't have any side effects, but it turned out that when it instantiates applied image tools, that in turn also sets up the UI for these tools, and that in turn causes a deadlock as the whole UI mechanism is locked during a paint operation.
It's a bad design to have the whole image tools UI set up when the only thing needed is the filter mechanism itself, but here I can blame our dear German interns that wrote these image tools back in the early days. 
I've now worked around the issue, but the image tools should really be rewritten... |
|
|
Posts:
8,330
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
30 Sep 25, 23:44
in response to: davidekholm
|
|
|
Jeff, the new b24 fixes the UI locking up.
I moved my "problem project" back into My Albums, and it no longer causes trouble. RobM and I thought we had ID'ed the issue, but that must have been a red herring. I certainly have been tinkering with image tools (when applied to an RI, for example), so I must have stumbled into the bug you've now fixed.
ETA: Oh, and yes, when in doubt, blame the interns.  |
|
|
Posts:
3,965
Registered:
18-Oct-2002
|
|
|
|
Re: Cleaning up path variables
Posted:
1 Oct 25, 10:46
in response to: JeffTucker
|
|
|
Jeff, the new b24 fixes the UI locking up.
I moved my "problem project" back into My Albums, and it no longer causes trouble. RobM and I thought we had ID'ed the issue, but that must have been a red herring. I certainly have been tinkering with image tools (when applied to an RI, for example), so I must have stumbled into the bug you've now fixed.
ETA: Oh, and yes, when in doubt, blame the interns.
Isn't it smart? They can't even defend themselves :->. To be graceful to them (him), it may not be obvious what code paths are activated during a deserialisation.
Nasty hanging though. Check out jAlbum's config folder for any thread dump files. If the watchdog was able to produce one, it should reveal the Sepia filter. I've identified this problem with the crop filter as well. |
|
|
Posts:
8,330
Registered:
31-Jan-2006
|
|
|
|
Re: Cleaning up path variables
Posted:
1 Oct 25, 14:30
in response to: davidekholm
|
|
|
No thread dumps, alas. For testing, one of my favorite filters is Invert, because it's immediately obvious in the Explore view, and in the finished album. It's not subtle, like adjusting the gamma. |
|
|
|
Legend
|
|
Forum admins
|
|
Helpful Answer
|
|
Correct Answer
|
|
