This question is not answered. Helpful answers available: 2. Correct answers available: 1.


Permlink Replies: 7 - Pages: 1 - Last Post: 5 Jun 25, 08:27 Last Post By: davidekholm
JeffTucker

Posts: 8,098
Registered: 31-Jan-2006
Image bounds bug
Posted: 25 May 25, 13:41
 
  Click to reply to this thread Reply
While experimenting, to figure out the possible source of an error a user is seeing, I stumbled across this old gem. I've been reporting this for years, but it remains unfixed, and it's a real "trap door" bug, one that leaves the user fumbling around to get out of it.

Go to Settings > Images > General, and for either the thumbnail bounds or image bounds, scroll down and choose the "..." entry, as if you were going to enter your own bounds. Now, instead of entering new bounds, just click away to something else.

The core defaults to setting the bounds to 0x0, and you're in no-man's-land. You can't make an album, you can't switch skins, you can't reload the defaults, nothing. You're trapped, unless you figure out what you've done, and reset the bounds to rational values. You just get an endless series of console warnings, crashes, etc.

If the user chooses "..." and doesn't then enter new bounds, or tries to enter 0x0 (or any combination in which one of the dimensions is zero), the core should ignore him, and retain the bounds that were there to start with.

In fact, I think I'd set something like 50x50 as the minimum allowable entry. Stupidly small, but at least the user would get visible images of some sort.
davidekholm

Posts: 3,711
Registered: 18-Oct-2002
Re: Image bounds bug
Posted: 26 May 25, 14:10   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
You're right. That's a really bad user experience. The UI component may even update to the previously correct value, but still there's an invalid value traveling around. The only way to get rid of the error was to explicitly choose another valid image size.

I'll put it on the todo to fix this
JeffTucker

Posts: 8,098
Registered: 31-Jan-2006
Re: Image bounds bug
Posted: 26 May 25, 15:29   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
It's possible to land in the same spot by entering an illegal value for the bounds, like 300abc35q, but at least in that case, the user should be well aware of what he's done.

This, of course, is why I always use a JSpinner for entry of a numeric value. ;)
davidekholm

Posts: 3,711
Registered: 18-Oct-2002
Re: Image bounds bug
Posted: 30 May 25, 17:11   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
Do a core update to v37.5.5 now. This version only accepts valid dimensions (at least 50x50).
This update also fixes a drag and drop bug introduced in v37.5 (One needed to peek before dnd worked). You can also now continue dragging after a peek has been initiated (will cancel peek)
JeffTucker

Posts: 8,098
Registered: 31-Jan-2006
Re: Image bounds bug
Posted: 30 May 25, 18:52   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
That's almost got it, with one exception. Try a skin like Neptune, which allows the user to specify image bounds for the folder thumbnails. In that one, if the user doesn't enter a value, it ends up being blank. Doesn't cause any errors, and doesn't crash, but the folder thumbnails end up being the same size as the image thumbnails.

And you enter, e.g., 20x10 as the folder thumbnail bounds, it doesn't create a tiny thumbnail, but it doesn't correct the settings display, either.
davidekholm

Posts: 3,711
Registered: 18-Oct-2002
Re: Image bounds bug
Posted: 2 Jun 25, 11:57   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
Yes, the new behaviour isn't 100% perfect, but I believe it's far better than the stuck state jAlbum could get itself into. I'll make a silent release, fixing this issue + the drag&drop issue I introduced when adding the peek feature. (d&d didn't work prior to peeking)
JeffTucker

Posts: 8,098
Registered: 31-Jan-2006
Re: Image bounds bug
Posted: 4 Jun 25, 15:01   in response to: davidekholm in response to: davidekholm
 
  Click to reply to this thread Reply
davidekholm wrote:
I'll make a silent release....

It must be very silent. Invisible, too!
davidekholm

Posts: 3,711
Registered: 18-Oct-2002
Re: Image bounds bug
Posted: 5 Jun 25, 08:27   in response to: JeffTucker in response to: JeffTucker
 
  Click to reply to this thread Reply
JeffTucker wrote:
davidekholm wrote:
I'll make a silent release....

It must be very silent. Invisible, too!


I took a bigger stab at it. Now 37.5.6 is being fed as a critical update, fixing the drag & drop issue. Also, if you initiate a drag, but do it so slowly that Peek is triggered, continue dragging will close the Peek.

Stay tuned for jAlbum 37.6 beta!
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums