Thread Locked This thread is locked - replies are not allowed.


This question is not answered. Helpful answers available: 2. Correct answers available: 1.

Search Forum Search Forum Back to Thread List Back to Thread List

Permlink Replies: 21 - Pages: 2 [ 1 2 | Next ] - Last Post: 25 Jun 24, 12:10 Last Post By: davidekholm
nigel-aves

Posts: 66
Registered: 23-May-2023
Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 18 Jun 24, 15:55 		 
When I delete an Album, the entire directory structure is not deleted. It's deleting all the files but leaving all the directories. I reproduced using SFTP and FTPES. I checked the "Output," and all the files there are correct, so I think this is an "FTP" issue.

Starting place in Jalbum
Link: https://serendipity.soft-focus-imagining.com/#img=Image1.jpg

Delete album "In_The_Park" and add three more albums
Link: https://serendipity.soft-focus-imagining.com/#img=Image2.jpg

After Make Album and Upload everything looks good
Link: https://serendipity.soft-focus-imagining.com/#img=Image3.jpg

But when I look at the files on the web-server, "In_The_Park" is still there.
Link: https://serendipity.soft-focus-imagining.com/#img=Image4.jpg

Two empty folders are left. (If album had sub-albums their directories are also left.
Link: https://serendipity.soft-focus-imagining.com/#img=Image5.jpg

Nigel

Edited by: nigel-aves on 18 Jun 2024, 07:56
JeffTucker

Posts: 8,062
Registered: 31-Jan-2006
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 18 Jun 24, 16:40   in response to: nigel-aves in response to: nigel-aves 		 
Have you ever used something like FileZilla to do the uploading, instead of the jAlbum uploader? If so, that's why some things might not get removed. The jAlbum uploader, as a safety measure, will not remove anything that it didn't create. So if it encounters a directory on the server that it didn't create, it won't delete it, even if it's part of an album.
nigel-aves

Posts: 66
Registered: 23-May-2023
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 18 Jun 24, 16:44   in response to: JeffTucker in response to: JeffTucker 		 
Jeff,

jAlbum created all the folders. Filezilla was not used, nor do I have it loaded.
JeffTucker

Posts: 8,062
Registered: 31-Jan-2006
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 18 Jun 24, 17:01   in response to: nigel-aves in response to: nigel-aves 		 
Confirmed. I would swear this was working properly before, but it is no longer behaving properly. The uploader is deleting the contents of the no-longer-needed folders, but not deleting the directories themselves.

Something for David to look at.

ETA: One more data point. It works properly on jalbum.net hosting, but not on other hosting.
nigel-aves

Posts: 66
Registered: 23-May-2023
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 18 Jun 24, 17:09   in response to: JeffTucker in response to: JeffTucker 		 
Jeff,

100% correct. This was all working correctly. I think it's the last "update" to jAlbum that caused this issue.

"but not on other hosting." Blow and Blast! At least it's not affecting people of jAlbum.new

Nigel.
davidekholm

Posts: 3,825
Registered: 18-Oct-2002
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 19 Jun 24, 10:54   in response to: nigel-aves in response to: nigel-aves 		 
Nigel, can you email me login details for your ftp server so I can see if I can reproduce? The current jAlbum version uses the same uploader code as the version before so I have a hard time thinking a recent change in jAlbum could be the cause. https://jalbum.net/forum/thread.jspa?threadID=59726&tstart=0 has an updated SFTP library. That can be worth checking out, but if you have problems with ordinary ftp as well, then it's probably not the ftp library itself.
JeffTucker

Posts: 8,062
Registered: 31-Jan-2006
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 19 Jun 24, 14:12   in response to: davidekholm in response to: davidekholm 		 
David, better to play with my "just for screwing around" domain - I just emailed you the credentials.

And I'm using the latest jAlbum beta, with all new libraries, so that's not the issue.

ETA: No problem with deleting an entire project, either - that successfully deletes the entire directory structure.
davidekholm

Posts: 3,825
Registered: 18-Oct-2002
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 19 Jun 24, 16:22   in response to: JeffTucker in response to: JeffTucker 		 
Thanks, so it's only when selecting to delete a folder from within the publish view that it fails, or does it fail if you delete an album folder locally after an initial upload and then re-upload?
JeffTucker

Posts: 8,062
Registered: 31-Jan-2006
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 19 Jun 24, 16:27   in response to: davidekholm in response to: davidekholm 		 
New project, two folders - F1 and F2 - make album, upload.

In Explore, delete F2, create F3, make album, upload.

Server still shows F1, F2, and F3. F2 is just a skeleton - F2, F2/slides, F2/thumbs - no files.
nigel-aves

Posts: 66
Registered: 23-May-2023
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 19 Jun 24, 17:43   in response to: davidekholm in response to: davidekholm 		 
David,

I've no idea if this will help or not, but here is the configuration of SFTP that I used after; Jeff was adamant I should use that protocol! :). I've also included a section of log file where all I did was delete one "album". The jAlbum web output is 100% correct.

Debian 12
NGINX web-server
Proftp version 1.3.8 >> with this section added to support SFTP

Code: 
<IfModule mod_sftp.c>
 
        SFTPEngine on
        Port 2222
        SFTPLog /var/log/proftpd/sftp.log
 
        # Configure both the RSA and DSA host keys, using the same host key
        # files that OpenSSH uses.
        SFTPHostKey /etc/ssh/ssh_host_rsa_key
        SFTPHostKey /etc/ssh/ssh_host_dsa_key
 
        SFTPAuthMethods publickey
 
        SFTPAuthorizedUserKeys file:/etc/proftpd/authorized_keys/%u
 
        # Enable compression
        SFTPCompression delayed
 
Match Group adult-sitemap.gallery-adult
    # Chroot the connection into the specified directory
           ChrootDirectory /home/%u
    # Force the connection to use the built-in SFTP support
           ForceCommand internal-sftp -d /soft-focus-imagining/domains/gallery-adult.soft-focus-imagining.com/public_html
           
Match Group gallery-sitemap.gallery
    # Chroot the connection into the specified directory
           ChrootDirectory /home/%u
    # Force the connection to use the built-in SFTP support
           ForceCommand internal-sftp -d /soft-focus-imagining/domains/gallery.soft-focus-imagining.com/public_html
           
Match Group savage-van-sage.savage-van-sage
    # Chroot the connection into the specified directory
           ChrootDirectory /home/%u
    # Force the connection to use the built-in SFTP support
           ForceCommand internal-sftp -d /soft-focus-imagining/domains/savage-van-sage.soft-focus-imagining.com/public_html/jAlbum_Savage
           
Match Group serendipity.soft-focus-imagining
    # Chroot the connection into the specified directory
           ChrootDirectory /home/%u
    # Force the connection to use the built-in SFTP support
           ForceCommand internal-sftp -d /soft-focus-imagining/domains/serendipity.soft-focus-imagining.com/public_html
           
Match Group nsaphoto-sitemap.nigel-aves-photography
    # Chroot the connection into the specified directory
           ChrootDirectory /home/%u
    # Force the connection to use the built-in SFTP support
           ForceCommand internal-sftp -d /nigel-aves-photography/public_html/jAlbum_Nigel_Aves_Photography  
 
</IfModule>

Here is the section of the log file after all the "auth/setup" messages:

Code: 

using SFTP protocol version 3 for this session (channel ID 0)
2024-06-19 09:20:22,994 mod_sftp/1.1.1[2233039]: sending userauth success
2024-06-19 09:20:22,994 mod_sftp/1.1.1[2233039]: user 'serendipity.soft-focus-imagining' authenticated via 'password' method
2024-06-19 09:20:22,994 mod_sftp/1.1.1[2233038]: 'subsystem' channel request for 'sftp' subsystem
2024-06-19 09:20:22,994 mod_sftp/1.1.1[2233036]: 'subsystem' channel request for 'sftp' subsystem
2024-06-19 09:20:22,998 mod_sftp/1.1.1[2233040]: 'subsystem' channel request for 'sftp' subsystem
2024-06-19 09:20:23,001 mod_sftp/1.1.1[2233041]: using SFTP protocol version 3 for this session (channel ID 0)
2024-06-19 09:20:23,003 mod_sftp/1.1.1[2233037]: 'subsystem' channel request for 'sftp' subsystem
2024-06-19 09:20:23,003 mod_sftp/1.1.1[2233039]: 'subsystem' channel request for 'sftp' subsystem
2024-06-19 09:20:23,004 mod_sftp/1.1.1[2233036]: using SFTP protocol version 3 for this session (channel ID 0)
2024-06-19 09:20:23,004 mod_sftp/1.1.1[2233038]: using SFTP protocol version 3 for this session (channel ID 0)
2024-06-19 09:20:23,010 mod_sftp/1.1.1[2233040]: using SFTP protocol version 3 for this session (channel ID 0)
2024-06-19 09:20:23,013 mod_sftp/1.1.1[2233037]: using SFTP protocol version 3 for this session (channel ID 0)
2024-06-19 09:20:23,013 mod_sftp/1.1.1[2233039]: using SFTP protocol version 3 for this session (channel ID 0)
2024-06-19 09:20:23,062 mod_sftp/1.1.1[2233034]: unable to check '/home/soft-focus-imagining/domains/serendipity.soft-focus-imagining.com/public_html/1718810423445.tmp': No such file or directory
2024-06-19 09:20:23,146 mod_sftp/1.1.1[2233035]: disconnecting client (received EOF)
2024-06-19 09:20:23,147 mod_sftp/1.1.1[2233038]: disconnecting client (received EOF)
2024-06-19 09:20:23,147 mod_sftp/1.1.1[2233037]: disconnecting client (received EOF)
2024-06-19 09:20:23,147 mod_sftp/1.1.1[2233036]: disconnecting client (received EOF)
2024-06-19 09:20:23,147 mod_sftp/1.1.1[2233041]: disconnecting client (received EOF)
2024-06-19 09:20:23,147 mod_sftp/1.1.1[2233039]: disconnecting client (received EOF)
2024-06-19 09:20:23,147 mod_sftp/1.1.1[2233040]: disconnecting client (received EOF)
2024-06-19 09:20:37,740 mod_sftp/1.1.1[2233034]: disconnecting client (received EOF)


Nigel.
davidekholm

Posts: 3,825
Registered: 18-Oct-2002
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 22 Jun 24, 17:28   in response to: nigel-aves in response to: nigel-aves 		 
v35 b14 available at https://jalbum.net/download/beta/jalbum-core.jar

Changes:
  • Removes leftover empty directories during upload process.
nigel-aves

Posts: 66
Registered: 23-May-2023
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 22 Jun 24, 19:50   in response to: davidekholm in response to: davidekholm 		 
David,

I dropped the jalbum-core.jar into the C:\Program Files\jAlbum\lib - directory.

I added four albums (one had a second level album) and uploaded them. Deleted two albums. Re-ran Make Album and Upload; Gallery displayed correctly (One album) in a browser, but sadly, the empty directories were still there. :(

I tried both SFTP and FTPES.

If I did something wrong, please let me know.

Nigel.
JeffTucker

Posts: 8,062
Registered: 31-Jan-2006
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 22 Jun 24, 20:03   in response to: nigel-aves in response to: nigel-aves 		 
nigel-aves wrote:
...the empty directories were still there. :(

I got the same non-result, and let David know earlier today, so not something you did wrong!
davidekholm

Posts: 3,825
Registered: 18-Oct-2002
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 23 Jun 24, 11:07   in response to: nigel-aves in response to: nigel-aves 		 
Odd. It really should work.

Just to be 100% sure we're running the same beta, I've bumped it to b15 and uploaded it to https://jalbum.net/download/beta/jalbum-core.jar again.
nigel-aves

Posts: 66
Registered: 23-May-2023
Re: Directory trees are not being deleted if an Album is deleted in jAlbum
Posted: 23 Jun 24, 23:09   in response to: davidekholm in response to: davidekholm 		 
David,

Do not know if you heard from Jeff today, just tried your version "B", still failed but I have some meaningful messages for you to look at from the sftp.log. Could you be missing a "/" between test2 and thumbs and slides?

2024-06-23 15:04:07,437 mod_sftp/1.1.12920431: error removing directory '/home/soft-focus-imagining/domains/serendipity.soft-focus-imagining.com/public_html/test2thumbs': No such file or directory
2024-06-23 15:04:07,441 mod_sftp/1.1.12920431: error removing directory '/home/soft-focus-imagining/domains/serendipity.soft-focus-imagining.com/public_html/test2slides': No such file or directory
2024-06-23 15:04:07,444 mod_sftp/1.1.12920431: error removing directory '/home/soft-focus-imagining/domains/serendipity.soft-focus-imagining.com/public_html/test2': Directory not empty

Nigel.
Pages: 2 [ 1 2 | Next ]
Back to Thread List Back to Thread List
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums