Posts:
3,581
Registered:
18-Oct-2002
|
|
|
Re: jAlbum on Java 18
Posted:
12 Sep 22, 12:16
in response to: JeffTucker
|
|
|
Yes, I'll soon plan to move to source/binary format 18. When skins are compiled against jalbum-core.jar, then they will also need to have their source/binary format bumped.
Appreciate the "heads up." I'm always compiling to the latest core, even if it's just a beta, so that might have caught me unawares. Easy enough to do a set of "jAlbum 29 compatible" skin releases, as long as I know they're needed! Takes longer to update the user's manuals than it does to recompile and package the skin updates (I've got a lot of that stuff scripted).
Your only real motivation for updating the source/binary format of your skins if if you like to use more modern Java language features, like using the "var" keyword for variable declarations or use more modern switch statements.
|
|
|
Posts:
3,581
Registered:
18-Oct-2002
|
|
|
Posts:
1,158
Registered:
14-Dec-2007
|
|
|
Re: jAlbum on Java 18
Posted:
14 Sep 22, 13:24
in response to: davidekholm
|
|
|
You said that with the Multi Maker, clicking F7 would display the Console window, but this is not working.
If I start the processing of a list of files, the Multi Maker window has the focus. Pressing F7 in that case gives no reaction.
To get the console window, I have to click on the main window in the backgrounsd and click next F7.
|
|
|
Posts:
1,158
Registered:
14-Dec-2007
|
|
|
Re: jAlbum on Java 18
Posted:
14 Sep 22, 13:41
in response to: davidekholm
|
|
|
I see too that you did not implement a final pou-up window and As far as I understand nothing is cahnged on the notification window.
During the upload of the list of projects I see in the console window an error: Uploading "LG_Carousel" to https://andrewolff.jalbum.net/LG_Carousel/
Zip stream support detected
"LG_Carousel" uploaded to https://andrewolff.jalbum.net/LG_Carousel/ in 0,759s
Posting albumUrl: https://andrewolff.jalbum.net/LG_Carousel/
Posting thumbnailUrl: https://andrewolff.jalbum.net/LG_Carousel/thumbs/Vecht_121027_1221.jpg
java.io.IOException: Error while adding album. Server reported: Album image not found. Your "web root" setting in the publish window might be wrong: url = https://andrewolff.jalbum.net/LG_Carousel/thumbs/Vecht_121027_1221.jpg
at se.datadosen.jalbum.Notifier.albumAdded(Notifier.java:130)
at se.datadosen.jalbum.UploadBean.doAfterUploadAlbum(UploadBean.java:933)
at se.datadosen.jalbum.UploadBean.uploadAlbum(UploadBean.java:879)
at se.datadosen.jalbum.UploadBean.uploadAlbum(UploadBean.java:769)
at se.datadosen.jalbum.UploadAlbumTask.doInBackground(UploadAlbumTask.java:142)
at se.datadosen.jalbum.TaskManager$BackgroundTask.call(TaskManager.java:113)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
All workers shut down
but this is not reported in a notification or final pop-up window.
However the uploaded album is OK, so I don't understand the error message
Edit
This is an album with only webp images, The thumbs folder contains an image Vecht_121027_1221.webp, which is correctly uploaded.
II think this is a bug in jAlbum, because it tries to upload a jpg file to https://andrewolff.jalbum.net/LG_Carousel/thumbs/Vecht_121027_1221.jpg
Edited by: AndreWolff on 14 Sep 2022, 13:53
|
|
|
Posts:
3,581
Registered:
18-Oct-2002
|
|
|
Re: jAlbum on Java 18
Posted:
14 Sep 22, 18:12
in response to: AndreWolff
|
|
|
You said that with the Multi Maker, clicking F7 would display the Console window, but this is not working.
If I start the processing of a list of files, the Multi Maker window has the focus. Pressing F7 in that case gives no reaction.
I haven't rebuilt all archives yet. Been working on M1 compatibility lately.
|
|
|
Posts:
3,581
Registered:
18-Oct-2002
|
|
|
Re: jAlbum on Java 18
Posted:
14 Sep 22, 18:32
in response to: AndreWolff
|
|
|
I see too that you did not implement a final pou-up window and As far as I understand nothing is cahnged on the notification window.
Again, I've been working on other stuff. Such remarks carry a condescending attitude which seriously puts me off against implementing a final notification or popup.
During the upload of the list of projects I see in the console window an error: Uploading "LG_Carousel" to https://andrewolff.jalbum.net/LG_Carousel/
Zip stream support detected
"LG_Carousel" uploaded to https://andrewolff.jalbum.net/LG_Carousel/ in 0,759s
Posting albumUrl: https://andrewolff.jalbum.net/LG_Carousel/
Posting thumbnailUrl: https://andrewolff.jalbum.net/LG_Carousel/thumbs/Vecht_121027_1221.jpg
java.io.IOException: Error while adding album. Server reported: Album image not found. Your "web root" setting in the publish window might be wrong: url = https://andrewolff.jalbum.net/LG_Carousel/thumbs/Vecht_121027_1221.jpg
at se.datadosen.jalbum.Notifier.albumAdded(Notifier.java:130)
at se.datadosen.jalbum.UploadBean.doAfterUploadAlbum(UploadBean.java:933)
at se.datadosen.jalbum.UploadBean.uploadAlbum(UploadBean.java:879)
at se.datadosen.jalbum.UploadBean.uploadAlbum(UploadBean.java:769)
at se.datadosen.jalbum.UploadAlbumTask.doInBackground(UploadAlbumTask.java:142)
at se.datadosen.jalbum.TaskManager$BackgroundTask.call(TaskManager.java:113)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
All workers shut down
but this is not reported in a notification or final pop-up window.
However the uploaded album is OK, so I don't understand the error message
Edit
This is an album with only webp images, The thumbs folder contains an image Vecht_121027_1221.webp, which is correctly uploaded.
II think this is a bug in jAlbum, because it tries to upload a jpg file to https://andrewolff.jalbum.net/LG_Carousel/thumbs/Vecht_121027_1221.jpg
It's indeed a bug, but I can't reproduce it. Please see if you can reproduce it with the Minimal skin. If so, pass me the final album URL and I'll inspect it.
(The server side also has issues reading webp images. That's something we should address.)
|
|
|
Posts:
8,392
Registered:
31-Jan-2006
|
|
|
Re: jAlbum on Java 18
Posted:
14 Sep 22, 18:40
in response to: davidekholm
|
|
|
Such remarks carry a condescending attitude....
And you probably didn't even see the post that I deleted, which sounded like something written by a particularly unpleasant 9-year-old, full of victimhood and accusations of favoritism.
|
|
|
Posts:
1,158
Registered:
14-Dec-2007
|
|
|
Re: jAlbum on Java 18
Posted:
14 Sep 22, 19:22
in response to: davidekholm
|
|
|
|
It's indeed a bug, but I can't reproduce it. Please see if you can reproduce it with the Minimal skin. If so, pass me the final album URL and I'll inspect it.
The same error with the minimal skin: Uploading "LG_Carousel" to https://andrewolff.jalbum.net/LG_Carousel_Minimal/
Zip stream support detected
"LG_Carousel" uploaded to https://andrewolff.jalbum.net/LG_Carousel_Minimal/ in 3,555s
Posting albumUrl: https://andrewolff.jalbum.net/LG_Carousel_Minimal/
Posting thumbnailUrl: https://andrewolff.jalbum.net/LG_Carousel_Minimal/thumbs/Vecht_121027_1221.webp
java.io.IOException: Error while adding album. Server reported: Could not read album image. Not an image: url = https://andrewolff.jalbum.net/LG_Carousel_Minimal/thumbs/Vecht_121027_1221.webp
at se.datadosen.jalbum.Notifier.albumAdded(Notifier.java:130)
at se.datadosen.jalbum.UploadBean.doAfterUploadAlbum(UploadBean.java:933)
at se.datadosen.jalbum.UploadBean.uploadAlbum(UploadBean.java:879)
at se.datadosen.jalbum.JPublishWizard$PublishStep$19.run(JPublishWizard.java:2054)
All workers shut down
See https://andrewolff.jalbum.net/LG_Carousel_Minimal/ and attached screenshot
Edit: Notice that the contents of the error message is different from what you see above.
Edited by: AndreWolff on 14 Sep 2022, 20:38
|
|
|
Posts:
8,392
Registered:
31-Jan-2006
|
|
|
Re: jAlbum on Java 18
Posted:
14 Sep 22, 20:52
in response to: AndreWolff
|
|
|
|
|
Posts:
3,581
Registered:
18-Oct-2002
|
|
|
Re: jAlbum on Java 18
Posted:
16 Sep 22, 09:34
in response to: AndreWolff
|
|
|
André, in your last test album, the passed thumbnail URL is indeed having a correct .webp extension. Here the problem is on our server side, which I mentioned. We still haven't addressed handling webp on the server side.
|
|
|
Posts:
1,158
Registered:
14-Dec-2007
|
|
|
Re: jAlbum on Java 18
Posted:
16 Sep 22, 11:01
in response to: davidekholm
|
|
|
André, in your last test album, the passed thumbnail URL is indeed having a correct .webp extension. Here the problem is on our server side, which I mentioned. We still haven't addressed handling webp on the server side.
Yes I did understood that already from Jeff’s reply.
You can use this to test the error handling with the Multi Maker!
|
|
|
Posts:
3,949
Registered:
4-Aug-2006
|
|
|
Re: jAlbum on Java 18
Posted:
20 Sep 22, 22:13
in response to: davidekholm
|
|
|
David, my combined jAlbum core update tool is failing with this beta (28.2b5). Do I need to do a rewrite?
The error message is java.lang.reflect.InaccessibleObjectException:
Unable to make public long sun.net.www.protocol.https.HttpsURLConnectionImpl.getLastModified() accessible:
module java.base does not "exports sun.net.www.protocol.https" to unnamed module
@13e39c73 in jAlbum core update.bsh at line number 106
I'm using HttpURLConnection httpCon = (HttpURLConnection) url.openConnection(); to get the last modified date of the online file.
The code used is updateFile(URL url, File destDir) throws PermissionDeniedException, IOException {
startVersion = internalVersion;
String path = url.getPath();
String fileName = path.substring(path.lastIndexOf('/')+1);
File downloading = new File(destDir, fileName + ".downloading");
File downloaded = new File(destDir, fileName + ".downloaded");
System.out.println("Looking for " + fileName);
window.statusBar.popText("Looking for " + fileName + " ...");
HttpURLConnection httpCon = (HttpURLConnection) url.openConnection();
//Above line now fails
File existingFile = new File(destDir, fileName);
System.out.println(httpCon.getLastModified() + " > " + existingFile.lastModified());
|
|
|
Posts:
3,581
Registered:
18-Oct-2002
|
|
|
Re: jAlbum on Java 18
Posted:
21 Sep 22, 13:18
in response to: RobM
|
|
|
|
I suspect that good-old-BeanShell simply isn't supporting Java's Module system that was introduced in Java 9 and further enforced now. I switched your code to Groovy and then the problem disappeared. See attached Groovy version. (The switch took 5 min)
|
|
|
Posts:
3,949
Registered:
4-Aug-2006
|
|
|
Re: jAlbum on Java 18
Posted:
21 Sep 22, 13:49
in response to: davidekholm
|
|
|
I suspect that good-old-BeanShell simply isn't supporting Java's Module system that was introduced in Java 9 and further enforced now. I switched your code to Groovy and then the problem disappeared. See attached Groovy version. (The switch took 5 min)
Thanks, that was unexpected but very much appreciated. I’ll update the tool in the external tools forum with your Groovy version.
|
|
|
|
Legend
|
|
Forum admins
|
|
Helpful Answer
|
|
Correct Answer
|
|