What has changed the past 9 years that ...

xexyl

Posts: 157
Registered: 1-Sep-2009

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 00:46

in response to: JeffTucker

As for the linking method there was a reason for it but I no longer know why unless it’s to do with the filtering (I think that’s it but for more details I would have to give it more thought).

As for the image itself I was being forgetful. Seeing the filters and their dump of settings plus having played with it in an older release of jAlbum earlier I was in the mind of it working. But for the current version of jAlbum it’s not so of course you will see problems.

I saw some really odd things earlier when I was trying to figure out if I was losing my mind ir if there really was a problem! So I am not surprised that you see problems too. Once the filters are working with the current version then I could explain anything that might seem off.

And now I really am going for the night. I just checked because I realised that what I had said makes no sense!

xexyl

Posts: 157
Registered: 1-Sep-2009

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 00:47

in response to: ctwist

Reply

ctwist wrote:
This thread has some useful information about this problem https://jalbum.net/forum/thread.jspa?threadID=57082. In my skin, I was unable to fix the problem; I hope you are more fortunate.

Oh so it’s a known problem with the recent updates and filters? Is that what you’re saying? That’s discouraging to be sure. I will check it out tomorrow or so. Thank you!

Have a great night!

ctwist

Posts: 443
Registered: 27-Sep-2003

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 00:53

in response to: xexyl

Reply

xexyl wrote:
Oh so it’s a known problem with the recent updates and filters? Is that what you’re saying? That’s discouraging to be sure.

I wouldn't call it a known problem. "Known restriction" would be more accurate. The new approach is apparently a better way to write filters. The rationale for this is beyond my expertise.

xexyl

Posts: 157
Registered: 1-Sep-2009

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 15:27

in response to: ctwist

Reply

ctwist wrote:

xexyl wrote:
Oh so it’s a known problem with the recent updates and filters? Is that what you’re saying? That’s discouraging to be sure.

I wouldn't call it a known problem. "Known restriction" would be more accurate. The new approach is apparently a better way to write filters. The rationale for this is beyond my expertise.

I think it's worse than that actually; worse than a restriction that is. And it wasn't noted in the changelog. I replied to your post and I hope for a reply from David. I have already done what he's said is needed and it still does not work. And some of my filters are really complex. As I also said there I just renewed my subscription and it seems I wasted money on that. Really very annoying and I think not the right way to go about things. Of course i'm obviously biased there because I think I already have what was needed and I now have filters that are pointless (which makes my skin pointless) but still...

xexyl

Posts: 157
Registered: 1-Sep-2009

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 17:11

in response to: xexyl

Reply

I have some positive news: It seems that only ReflectionFilter is not working. That's a relief as it's one of the simpler (though not the simplest) ones and maybe I can get it to work after all. That would be great.

Funny one to not work when that is a new feature in jAlbum... I'll add a comment about this on the other post too. I'm still not sure why but maybe I'll be able to figure it out when I have a clearer head.

xexyl

Posts: 157
Registered: 1-Sep-2009

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 18 Jul 21, 21:22

in response to: xexyl

Reply

Just did the changes I'm supposed to make according to that thread and still no go. But there's one curious thing that did change and I'll put it in that thread and hopefully David can answer when he's back from holiday.

davidekholm

Posts: 3,576
Registered: 18-Oct-2002

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 19 Jul 21, 16:15

in response to: xexyl

Reply

It's sadly not enough to simply mark the skin's filter method as synchronized. The filter needs to follow the JavaBeans specification and not rely on states between each filter invocation. I commented in the other thread. Please upload the source code for your filter there and I'll see if I can figure out why it's not working properly. Also tell what incorrect behavior you get.

xexyl

Posts: 157
Registered: 1-Sep-2009

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 19 Jul 21, 21:07

in response to: davidekholm

Reply

davidekholm wrote:
It's sadly not enough to simply mark the skin's filter method as synchronized. The filter needs to follow the JavaBeans specification and not rely on states between each filter invocation. I commented in the other thread. Please upload the source code for your filter there and I'll see if I can figure out why it's not working properly. Also tell what incorrect behavior you get.

Well it now works wit your change to jalbum-core.jar; thank you so much! I have updated the skin and uploaded it with a note of how to update to 24.4.1 (ahead of the release) and also note that jAlbum 23 should work fine (with this most recent bug fix too).

Everything is in order on my part that I can tell. I just had to add Cloneable to the list of implemented classes. I don't know if it's necessary for the skin but it definitely seemed to be for the filters - but I kept it at both.

Really appreciate it all the more since you're on holiday. Enjoy the rest of it and stay safe!

davidekholm

Posts: 3,576
Registered: 18-Oct-2002

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 20 Jul 21, 11:24

in response to: xexyl

Reply

Thank you. You only need to add implements Cloneable to the filter itself, and you don't need to use any more getters and setters than you want external users of your filter to use.

xexyl

Posts: 157
Registered: 1-Sep-2009

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 20 Jul 21, 15:20

in response to: davidekholm

Reply

davidekholm wrote:
Thank you. You only need to add implements Cloneable to the filter itself, and you don't need to use any more getters and setters than you want external users of your filter to use.

Welcome.

Yes I realised I didn't need a getter/setter so I rolled back to the previous version. Thank you for the note about it only needing to be in the filter itself. I'll update and then in the next skin update it'll be uploaded (at least if I remember to do that when I next look at skin).

Have a good, safe holiday (or what remains of it) and thank you very much again!

davidekholm

Posts: 3,576
Registered: 18-Oct-2002

Re: What has changed the past 9 years that might break a skin rebuild?
Posted: 20 Jul 21, 17:40

in response to: xexyl

Reply

I will do

. I posted this one from earlier this afternoon. We're having vacation on the Swedish west coast this last week of vacation: https://www.facebook.com/ekholm.david/posts/10159954397456844?notif_id=1626795060082769&notif_t=feedback_reaction_generic&ref=notif (me and my daughter Frida trying body board in the waves)