Posts:
157
Registered:
1-Sep-2009
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
30 Jul 20, 23:12
in response to: JeffTucker
|
|
|
The user may be building a project with many branches, and wants to set up the structure before populating it with images. He'll just be puzzled about why he's not seeing the structure he's created.
Hiding empty directories falls into the category of doing the user a "favor" that he didn't ask for. If he wants to have empty directories ignored, the core already gives him a way to do that - he can hide or exclude them with a click.
Right. That's exactly what I was looking for. Thanks!
You too Rob of course but the above is I think key. |
|
|
Posts:
157
Registered:
1-Sep-2009
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 19:17
in response to: xexyl
|
|
|
|
|
|
I don't know if any of you have (1) the time; and (2) the inclination to look at what I think is ready for at least initial republication but in case here it is.
I have an additional filter (an old one in fact that I wrote back in 2009 or so) and new filter settings and options/features for the other filters too. The styles/*.jpg files are with the default settings/filters and include a slide page in the jAlbum album preview (which should be sufficient I think).
I include the source for the skin but not the filters though obviously I include the class files in the jar files.
I understand if you do not have the time or inclination of course; it's really not a big deal in the end. I will give it a bit and then probably republish it. After that I can update the albums here and on my website too.
Thanks for any feedback as well as the feedback/help/etc. from earlier on.
Edited by: xexyl on 27-Aug-2020 10:33
Trivial, insignificant change in init.bsh
|
|
|
Posts:
7,935
Registered:
31-Jan-2006
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 21:21
in response to: xexyl
|
|
|
|
|
|
Skin won't load. From the error message (attached), I suspect it's caused by having final in SkinModel.java.
|
|
|
Posts:
3,964
Registered:
4-Aug-2006
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 22:15
in response to: xexyl
|
|
|
As the skin won't load it is hard to see what the outputs should be like. But you have a postdir.bsh file in the skin, with the code template = new File(skinResDirectory, "common.css");
engine.processTemplateFile(template, new File(outputDirectory+File.separator+resPath, "common.css"));
Are the variables used in the skin's res/common.css file different for each folder? If not, why not just move common.css to the skin's root folder and delete postdir.bsh. |
|
|
Posts:
7,935
Registered:
31-Jan-2006
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 22:46
in response to: RobM
|
|
|
Agreed - that's completely superfluous. It's generating common.css over and over again, for each folder. But the index pages, at whatever level, are loading common.css from the root of the album, so those folder copies are never used for anything. The core will take care of this automatically if you just plant common.css at the root of the skin directory.
Ground that's been covered before, but....
From hints.jap, delete: cols=5
rows=0
(And makeThumbs defaults to true, so you can kill that line, as well - it would take a very determined user to set it to false.)
In skin.properties, add: enableThumbnailLayout=false
In init.bsh, just to make absolutely sure, add: engine.setRows(0);
|
|
|
Posts:
438
Registered:
27-Sep-2003
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 22:56
in response to: xexyl
|
|
|
Change public final String directions[] = {"up", "down", "left", "right"};
public final String chainDirections[] = {"clockwise", "anticlockwise"};
to public final String[] directions = {"up", "down", "left", "right"};
public final String[] chainDirections = {"clockwise", "anticlockwise"};
Also, you don't need these imports in SkinModel import se.datadosen.component.*;
import javax.swing.*;
import xexyl.jalbum.filters.transformations.*;
Edited by: ctwist on 27-Aug-2020 17:03 |
|
|
Posts:
157
Registered:
1-Sep-2009
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 23:02
in response to: JeffTucker
|
|
|
Skin won't load. From the error message (attached), I suspect it's caused by having final in SkinModel.java.
Okay that's bizarre because it does fine for me. I don't even remember adding the final there but so I did. I've removed it and will look at the other things. Not at all what I expected though. Next reply coming up. |
|
|
Posts:
7,935
Registered:
31-Jan-2006
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 23:04
in response to: xexyl
|
|
|
Okay that's bizarre because it does fine for me.
It works OK if you reload the skin, but during any jAlbum session, the first load of the skin fails. Try ctwist's solution first, but I don't think the final is doing anything in this context, either. |
|
|
Posts:
157
Registered:
1-Sep-2009
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 23:07
in response to: RobM
|
|
|
As the skin won't load it is hard to see what the outputs should be like. But you have a postdir.bsh file in the skin, with the code template = new File(skinResDirectory, "common.css");
engine.processTemplateFile(template, new File(outputDirectory+File.separator+resPath, "common.css"));
Are the variables used in the skin's res/common.css file different for each folder? If not, why not just move common.css to the skin's root folder and delete postdir.bsh.
Okay the reason I did this that way is a misunderstanding from an earlier comment. In the past I did this completely differently and didn't even have this file at all nor this bsh file.
The root directory of the skin. But then still it has to process the template. As for each directory (this in part to jGromit too) that's where a miscommunication resulted in but I no longer remember what it was even. Still I have to process the template so are you suggesting that it will be done automatically? Because that was my original problem - in the past whatever I had worked but it no longer did so I did it the way I did - which clearly is not right still. |
|
|
Posts:
7,935
Registered:
31-Jan-2006
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 23:08
in response to: xexyl
|
|
|
|
Yes. You don't need to tell jAlbum to process the common.css template. It does that automatically.
|
|
|
Posts:
157
Registered:
1-Sep-2009
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 23:12
in response to: JeffTucker
|
|
|
Agreed - that's completely superfluous. It's generating common.css over and over again, for each folder. But the index pages, at whatever level, are loading common.css from the root of the album, so those folder copies are never used for anything. The core will take care of this automatically if you just plant common.css at the root of the skin directory.
So it automatically processes the template? Okay. That was a misunderstanding from a reply by you a while back. I'll do this.
Ground that's been covered before, but....
From hints.jap, delete: cols=5
rows=0
(And makeThumbs defaults to true, so you can kill that line, as well - it would take a very determined user to set it to false.)
Oh but you should never trust users. Actually this is just an artefact of before and in any event I have the calls in init.bsh to do it anyway. Removed.
In skin.properties, add: enableThumbnailLayout=false
In init.bsh, just to make absolutely sure, add: engine.setRows(0);
Yep I already have that in init.bsh; the hints.jap I haven't touched in a long time unless it be that it was hinted I should set the rows to 0 instead of what I had it at (a really high value of old). That was Chris telling me that but I just duplicated it in the other place it was before (or so I suspect). I've also updated the skin.properties file. Thanks. |
|
|
Posts:
157
Registered:
1-Sep-2009
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 23:15
in response to: JeffTucker
|
|
|
Yes. You don't need to tell jAlbum to process the common.css template. It does that automatically.
I see that now, yes. I totally misunderstood you before. I think when you were talking earlier about res/ you were thinking in the target directory and I was thinking of the skin subdirectory itself. |
|
|
Posts:
7,935
Registered:
31-Jan-2006
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 23:20
in response to: xexyl
|
|
|
Oh but you should never trust users. Actually this is just an artefact of before and in any event I have the calls in init.bsh to do it anyway. Removed.
There was a time when there was a skin that set makeThumbs to false when you made an album, and it never reset it on the way out. It would stay set that way in the engine, even when you switched to another skin. Fun for the whole family!
My memory is a bit hazy, but I'm fairly sure the core now fixes that problem, and the troublesome skin (don't remember which one it was) long ago disappeared into the "legacy" bin. In short, this is an engine setting that you shouldn't need to touch. |
|
|
Posts:
7,935
Registered:
31-Jan-2006
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 23:21
in response to: xexyl
|
|
|
|
To be clear, common.css needs to be in the root of the skin directory, not in its res subdirectory. Things in res just get copied to the output, without being scanned for variables.
|
|
|
Posts:
157
Registered:
1-Sep-2009
|
|
|
|
Re: What has changed the past 9 years that might break a skin rebuild?
Posted:
27 Aug 20, 23:21
in response to: JeffTucker
|
|
|
Oh but you should never trust users. Actually this is just an artefact of before and in any event I have the calls in init.bsh to do it anyway. Removed.
There was a time when there was a skin that set makeThumbs to false when you made an album, and it never reset it on the way out. It would stay set that way in the engine, even when you switched to another skin. Fun for the whole family!
My memory is a bit hazy, but I'm fairly sure the core now fixes that problem, and the troublesome skin (don't remember which one it was) long ago disappeared into the "legacy" bin. In short, this is an engine setting that you shouldn't need to touch.
Ah okay. Good to know. It's been removed anyway. Working on the reply from Chris now - since it gave an error (test loading it by deleting the skin in the jAlbum directory and using the jaskin file). |
|
|
|
Legend
|
|
Forum admins
|
|
Helpful Answer
|
|
Correct Answer
|
|
