Just did a quick experiment. I reinstalled jAlbum 17.1.5, created a project with Slide Show 4, and tried to use the "Panoramic image" custom panel. Got multiple errors when I checked one of the boxes, then clicked in the "Max. image width" field. So these are not new problems.
Too many variables involved in this issue, to such an extent that I don’t see how posting anything further would be of use. My opinion stands, it stands the best chance of being fixed and, at the same time, making the code robust, it needs to be a compiled skin.
Please confirm the accuracy of that statement; are you saying the problem now occurs in your skins without using my external tool
and that they worked with previous versions of jAlbum when using the gps tool.
It has nothing to do with a GPS tool, only with panoramic images.
It did work a long time, but somewhere in time this problem was created. The user panel code is not changed the last 2 years, so I can't explain why I get now a silent crash. Nevertherless the parameters in the panel are correctly saved.
I couldn't resist having a fiddle with this. Between knowing that my own custom UI code doesn't call saveUI() at all (it's no longer necessary), and swiping some error-checking from ctwist's Mirage code, I arrived at this:
This enables a Panoramic checkbox in the edit panel only for images - disabled for folders, videos, etc., where it would make no sense. If you check the box, you can use the spinner to select a width. That action populates the user variables with an entry for maxImageWidth (not visible unless you close/open the edit panel, or move to the next object, but it's there nonetheless). If you uncheck the box, that value is removed from the user variables.
If the user manually removes the user variable, the image-specific maxImageWidth is no longer applied unless he toggles the Panoramic checkbox - the skin can't overcome all the odd things a user might do.
Well I don't know how you tested it, but I added it to the onload.bsh file of my FancyBox skin and got this error:
bsh.ParseException: Parse error at line 76, column 31. Encountered: , in onload.bsh at line number 76
I wouldn't even attempt to use this in an intepreted onload.bsh. That puts you into the BeanShell realm, and it's an unsupported dinosaur. This is the custom UI panel from a compiled UI. In fact, I used the demo project from this post for tinkering: https://jalbum.net/forum/thread.jspa?threadID=54799
As long as you stubbornly refuse to move to a compiled UI, you're going to keep having these kinds of problems, and none of the rest of us is willing to spend time trying to debug them. Working with onload.bsh is just miserable, and I won't do it.
(This thread started with a request for jAlbum to allow the addition of GPS coordinates to videos. How did we get here?)
Please confirm the accuracy of that statement; are you saying the problem now occurs in your skins without using my external tool, and that they worked with previous versions of jAlbum when using the gps tool.
Until now I tried to prevent a silent crash after using your tool by changing something in my skins, without success.
Now I tried to change something in your tool to prevent a silent crash.
This was more successfully: by removing the setAccessibility statements the silent crash is gone!
For future reference, the posted ’corrected version’is not a corrected version, it is a variant to possibly work around issues with SS4 and the like skins. The resultant code breaks jAlbum’s protocols.