This question is answered. Helpful answers available: 0. Correct answers available: 1.


Permlink Replies: 11 - Pages: 1 - Last Post: 28-May-2019 23:49 Last Post By: borisv Threads: [ Previous | Next ]
borisv

Posts: 19
Registered: 24-Oct-2005
Should ExhibitPlus be OK under 18.2.1 ?
Posted: 26-Apr-2019 16:54
 
  Click to reply to this thread Reply
Hi folks,
Today I've switched from JAlbum 15.3 to 18.2.1. Tried to re-build (Make All) the album and got ExhibitPlus error right away.
Had anyone tried that skin under 18.2.1? I mean successfully.
Thank you.

FYI:
Stack trace for jAlbum 18.2.1 using skin ExhibitPlus 1.8.1:

se.datadosen.tags.ElementException: Element ja:include has no matching ending tag (slide.htt:368)
at se.datadosen.tags.Elements.getNextElement(Elements.java:209)
at se.datadosen.tags.Elements.getNextElement(Elements.java:61)
at se.datadosen.jalbum.AST.buildTree(AST.java:104)
at se.datadosen.jalbum.ast.IfElseNode.<init>(IfElseNode.java:25)
at se.datadosen.jalbum.AST.buildTree(AST.java:109)
at se.datadosen.jalbum.AST.<init>(AST.java:48)
at se.datadosen.jalbum.AlbumBean.makeAlbum(AlbumBean.java:2743)
at se.datadosen.jalbum.AlbumBean.smartMakeAlbum(AlbumBean.java:2658)
at se.datadosen.jalbum.JAlbumFrame$6.run(JAlbumFrame.java:1101)
jGromit

Posts: 7,507
Registered: 31-Jan-2006
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 26-Apr-2019 17:02   in response to: borisv in response to: borisv
 
  Click to reply to this thread Reply
The newer jAlbum versions do more rigorous script-checking than the older versions, and it looks like there's a tiny, one-character error in E+. Open the skin directory - Tools, Open directories, Skin directory - replace the slide.htt file with the attached version, and see if you have better luck.

Edited by: ctwist on 28-May-2019 17:45
Removed the attached slide.htt. Install the latest version of ExhibitPlus for a comprehensive fix.
jGromit

Posts: 7,507
Registered: 31-Jan-2006
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 26-Apr-2019 17:04   in response to: jGromit in response to: jGromit
Helpful
  Click to reply to this thread Reply
That change gets past the script error, but I'm seeing other problems with the skin. It looks like the assistance of ctwist will be required.

But it really is time to switch to a modern, responsive skin, don't you think?

ETA: Chris, I think the problems revolve around non-curly-brace variable calls, which no longer work in the jAlbum core. But the fact that this is the first user post about it may indicate that it's time to retire the skin entirely, rather than fix it. My 2ยข.
ctwist

Posts: 555
Registered: 27-Sep-2003
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 26-Apr-2019 19:45   in response to: jGromit in response to: jGromit
 
  Click to reply to this thread Reply
I will look at this very soon (not today).

Edited by: ctwist on 26-Apr-2019 14:05
BTW I last tested ExhibitPlus 1.8.1 with jAlbum 16.
jGromit

Posts: 7,507
Registered: 31-Jan-2006
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 26-Apr-2019 20:10   in response to: ctwist in response to: ctwist
 
  Click to reply to this thread Reply
I suspect it was the new template parser in jAlbum 17.1 that broke the skin. I think that's when support for the old $var syntax was dropped, and when the last traces of tolerance for unclosed scripting tags disappeared.
borisv

Posts: 19
Registered: 24-Oct-2005
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 29-Apr-2019 01:03   in response to: jGromit in response to: jGromit
 
  Click to reply to this thread Reply
jGromit, the fix you've provided indeed got me through the first bump. My album is 20% built already and still going.

On the bigger question of transition: you are absolutely right. Fixing incremental and small incompatibility issues for diminishing number of users is not a good recipe, and I see the better use of your and/or Chris's time beyond E+.

I will see if I can stretch the time for E+ a little further for now (thank you for that) but I have to prepare for a switch, no doubt.
borisv

Posts: 19
Registered: 24-Oct-2005
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 29-Apr-2019 01:26   in response to: borisv in response to: borisv
 
  Click to reply to this thread Reply
Regenerated the whole album (6K photos, 130 folders, up to 3 layers deep) without a hitch.
Thanks a lot.
ctwist

Posts: 555
Registered: 27-Sep-2003
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 29-Apr-2019 03:36   in response to: borisv in response to: borisv
Helpful
  Click to reply to this thread Reply
I'm surprised that the album generated, because there are many other references to variables that use the old syntax. I have fixed all of these, but my album failed to generate because of an error in the internals of jAlbum that I don't understand. I have requested assistance with this. After this is fixed, I should be able to release a fixed version quickly.
borisv

Posts: 19
Registered: 24-Oct-2005
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 01-May-2019 00:23   in response to: ctwist in response to: ctwist
 
  Click to reply to this thread Reply
Hmm... The plot thickens.
borisv

Posts: 19
Registered: 24-Oct-2005
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 12-May-2019 22:36   in response to: borisv in response to: borisv
 
  Click to reply to this thread Reply
For two weeks I had no chance to touch my album. And finally today I looked more closely to what was actually generated last time. I realize that logic says "generation could not have succeeded at all", but it had.
But the resulting album doesn't display any photos. The folder structure, index pages, thumbnails are all there all right, but that's it. Any attempt to open any slide shows all the surrounding (titles, navigation, etc) but no picture in the middle.

My temporary joy was indeed temporary ;)
jGromit

Posts: 7,507
Registered: 31-Jan-2006
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 12-May-2019 22:41   in response to: borisv in response to: borisv
 
  Click to reply to this thread Reply
Install the latest release of E+, and hit Make Album again.
borisv

Posts: 19
Registered: 24-Oct-2005
Re: Should ExhibitPlus be OK under 18.2.1 ?
Posted: 20-May-2019 01:38   in response to: jGromit in response to: jGromit
 
  Click to reply to this thread Reply
Works flawlessly!
Guys, the level of service you provide is unparalleled.
It's uniquely friendly and productive.
That alone would have kept me hooked to JAlbum for another 12 years, no doubt.
And on top of that JAlbum is extremely useful, easy to operate, and greatly flexible program.
Who needs more than that!?
I sure don't.
My respect and gratitude, jGromit and ctwist!
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums