Permlink Replies: 20 - Pages: 2 [ Previous | 1 2 ] - Last Post: 03-Aug-2019 15:52 Last Post By: jGromit
AndreWolff

Posts: 1,693
Registered: 14-Dec-2007
Re: ConstrainRatioFilter
Posted: 17-Feb-2019 13:10   in response to: jGromit in response to: jGromit
  Click to reply to this thread Reply
jGromit wrote:
IYour history of asking for exactly such changes is a long one.
Yes indeed I think skin independend functions should be implemented in the jAlbum core.
But the fixed-ratio filter is already very old and has been implemented in almost all skins, so there is no immediate need to move it to the core now.
I think there are first more important things to do.
davidekholm

Posts: 3,611
Registered: 18-Oct-2002
Re: ConstrainRatioFilter
Posted: 17-Feb-2019 14:41   in response to: AndreWolff in response to: AndreWolff
  Click to reply to this thread Reply
If I'm to provide a UI to this filter, I guess it would fall in the Effects category as this is a filter you typically apply to all images (although it only acts on images outside the given aspect ratios). There could be another tab in the Effects panel, or better, a list of draggable effects one can drag and drop to apply to images
AndreWolff

Posts: 1,693
Registered: 14-Dec-2007
Re: ConstrainRatioFilter
Posted: 17-Feb-2019 15:54   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
davidekholm wrote:
If I'm to provide a UI to this filter, I guess it would fall in the Effects category
Personally I never open the Effects panel and I wonder how many users are familiar with that panel. So I would not serach it there.
I thought that the Effects panel was for the slides!

For me there is only one place were you should place this, in the panel where you define the thumbnails dimensions. In my own skin I have these two options now on a thumbnails tab.
davidekholm

Posts: 3,611
Registered: 18-Oct-2002
Re: ConstrainRatioFilter
Posted: 17-Feb-2019 16:21   in response to: AndreWolff in response to: AndreWolff
  Click to reply to this thread Reply
Thanks for your feedback André
jGromit

Posts: 7,545
Registered: 31-Jan-2006
Re: ConstrainRatioFilter
Posted: 17-Feb-2019 16:50   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
Sorry I brought it up. As I think about it, adding these choices to the core would make a mess of things. To avoid conflicts, new skin versions would be needed immediately - otherwise, what would a skin do if the user chose "fixed shape" in the core, but didn't choose "fixed shape" in the skin settings? And a non-updated skin wouldn't even know that it needed to check the core setting, which would produce a hell of a mess.

Tough to explain, but something like the justified gallery of thumbnails really doesn't behave well with fixed-shape thumbs. You end up with a lot of seemingly small, but very noticeable, 1- and 2- pixel alignment errors. So the skin really needs to know what it's being fed, and use very different coding for the thumbnail layout if fixed-shape thumbnails are coming its way.

Even after updating, older skin versions would be incompatible with the new jAlbum, and the new skin versions would be incompatible with the older jAlbum. The fixed-shape option is, indeed, in almost every current skin - even Neptune will add it in the next release (ready to go, but I'm tinkering with some other things).

But if these filters were added to the core settings, the thumbnail bounds panel would be the place for them. These aren't fancy "effects" that get added to the images - they're closely tied to the bounding dimensions. And I, too, think of "effects" as something for slides.
jGromit

Posts: 7,545
Registered: 31-Jan-2006
Re: ConstrainRatioFilter
Posted: 03-Aug-2019 15:52   in response to: davidekholm in response to: davidekholm
  Click to reply to this thread Reply
davidekholm wrote:
...as soon as the next jAlbum release is out, it won't be needed to include by skins....

I see this still isn't included in the jAlbum distribution. Probably should be.

But the same caution mentioned earlier still applies - any skin that uses the filter, but doesn't bundle it with the skin, will be restricted to the newest jAlbum release.
Legend
Forum admins
Helpful Answer
Correct Answer

Point your RSS reader here for a feed of the latest messages in all forums